[PATCH v3 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings

[PATCH v3 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings

[Jan Kiszka]

Changes in v3:
 - convert mux-controller from patternProperties to regular one
 - dropped k3-j72xx-mcu-wakeup patch after simple-bus conversion

Changes in v2:
 - reference reg-mux.yaml in am654-system-controller child node
 - base on top of dedicated am654-serdes-ctrl schema patch

This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20240518-dt-bindings-ti-soc-mfd-v1-0-b3952f104c9a@linaro.org/

As we are working in this area, having a zero-warning baseline helps a
lot finding own issues quicker. Maybe not all of the suggested
resolutions are optimal, open for feedback, just want to have them all
fixed now soon.

Jan

Jan Kiszka (3):
  arm64: dts: ti: k3-am642-evm: Silence schema warning
  dt-bindings: soc: ti: am645-system-controller: add child nodes used by
    main domain
  arm64: dts: ti: k3-am65-main: add system controller compatible

 .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-am642-evm.dts       |  4 +++
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi      |  2 +-
 3 files changed, 30 insertions(+), 1 deletion(-)

-- 
2.43.0

[PATCH v3 1/3] arm64: dts: ti: k3-am642-evm: Silence schema warning

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

The resolves

k3-am642-evm.dtb: adc: 'ti,adc-channels' is a required property
        from schema $id: http://devicetree.org/schemas/iio/adc/ti,am3359-adc.yaml#

As the adc is reserved, thus not used by Linux, this has no practical
impact.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 6bb1ad2e56ec..42015a55e0d3 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -646,6 +646,10 @@ cpsw3g_phy0: ethernet-phy@0 {
 &tscadc0 {
 	/* ADC is reserved for R5 usage */
 	status = "reserved";
+
+	adc {
+		ti,adc-channels = <0 1 2 3 4 5 6 7>;
+	};
 };
 
 &ospi0 {
-- 
2.43.0

[PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Expand bindings to cover both the MCU and the main usage of the AM654
system controller.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
index e79803e586ca..5a689ec3c5c9 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
@@ -29,11 +29,36 @@ properties:
 
   ranges: true
 
+  mux-controller:
+    type: object
+    ref: /schemas/mux/reg-mux.yaml#
+    description:
+      This is the SERDES lane control mux.
+
 patternProperties:
   "^phy@[0-9a-f]+$":
     type: object
     $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
 
+  "^clock@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
+
+  "^dss-oldi-io-ctrl@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/mfd/syscon.yaml#
+    properties:
+      compatible:
+        items:
+          - const: ti,am654-dss-oldi-io-ctrl
+          - const: syscon
+
+  "^clock-controller@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
+    description:
+      Clock provider for TI EHRPWM nodes.
+
 required:
   - compatible
   - reg
-- 
2.43.0

Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

On Tue, Aug 13, 2024 at 08:04:59AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Expand bindings to cover both the MCU and the main usage of the AM654
> system controller.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> index e79803e586ca..5a689ec3c5c9 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> @@ -29,11 +29,36 @@ properties:
>  
>    ranges: true
>  
> +  mux-controller:
> +    type: object
> +    ref: /schemas/mux/reg-mux.yaml#
> +    description:
> +      This is the SERDES lane control mux.
> +
>  patternProperties:
>    "^phy@[0-9a-f]+$":
>      type: object
>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>  
> +  "^clock@[0-9a-f]+$":

Could you explain to me why these are all patternProperties? Why are the
addresses of these things not fixed for an am654?

> +    type: object
> +    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
> +
> +  "^dss-oldi-io-ctrl@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/mfd/syscon.yaml#
> +    properties:
> +      compatible:
> +        items:
> +          - const: ti,am654-dss-oldi-io-ctrl
> +          - const: syscon
> +
> +  "^clock-controller@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> +    description:
> +      Clock provider for TI EHRPWM nodes.
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Jan Kiszka]

On 13.08.24 17:40, Conor Dooley wrote:
> On Tue, Aug 13, 2024 at 08:04:59AM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Expand bindings to cover both the MCU and the main usage of the AM654
>> system controller.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>> index e79803e586ca..5a689ec3c5c9 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
>> @@ -29,11 +29,36 @@ properties:
>>  
>>    ranges: true
>>  
>> +  mux-controller:
>> +    type: object
>> +    ref: /schemas/mux/reg-mux.yaml#
>> +    description:
>> +      This is the SERDES lane control mux.
>> +
>>  patternProperties:
>>    "^phy@[0-9a-f]+$":
>>      type: object
>>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>>  
>> +  "^clock@[0-9a-f]+$":
> 
> Could you explain to me why these are all patternProperties? Why are the
> addresses of these things not fixed for an am654?
> 

I could indeed spell out dss-oldi-io-ctrl@41e0 and
clock-controller@4140, and their addresses are likely fixed, indeed. But
there are also clock@4080 and clock@4090 - should I duplicate their
object descriptions while moving them to the regular properties?

Jan

>> +    type: object
>> +    $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
>> +
>> +  "^dss-oldi-io-ctrl@[0-9a-f]+$":
>> +    type: object
>> +    $ref: /schemas/mfd/syscon.yaml#
>> +    properties:
>> +      compatible:
>> +        items:
>> +          - const: ti,am654-dss-oldi-io-ctrl
>> +          - const: syscon
>> +
>> +  "^clock-controller@[0-9a-f]+$":
>> +    type: object
>> +    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
>> +    description:
>> +      Clock provider for TI EHRPWM nodes.
>> +
>>  required:
>>    - compatible
>>    - reg
>> -- 
>> 2.43.0
>>

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]

On Wed, Aug 14, 2024 at 06:49:39AM +0200, Jan Kiszka wrote:
> On 13.08.24 17:40, Conor Dooley wrote:
> > On Tue, Aug 13, 2024 at 08:04:59AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@siemens.com>
> >>
> >> Expand bindings to cover both the MCU and the main usage of the AM654
> >> system controller.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >>  .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
> >>  1 file changed, 25 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> index e79803e586ca..5a689ec3c5c9 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> @@ -29,11 +29,36 @@ properties:
> >>  
> >>    ranges: true
> >>  
> >> +  mux-controller:
> >> +    type: object
> >> +    ref: /schemas/mux/reg-mux.yaml#
> >> +    description:
> >> +      This is the SERDES lane control mux.
> >> +
> >>  patternProperties:
> >>    "^phy@[0-9a-f]+$":
> >>      type: object
> >>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
> >>  
> >> +  "^clock@[0-9a-f]+$":
> > 
> > Could you explain to me why these are all patternProperties? Why are the
> > addresses of these things not fixed for an am654?
> > 
> 
> I could indeed spell out dss-oldi-io-ctrl@41e0 and
> clock-controller@4140, and their addresses are likely fixed, indeed. But
> there are also clock@4080 and clock@4090 - should I duplicate their
> object descriptions while moving them to the regular properties?

If you're going to itemise the 3 clocks, I think you should mention
what's different about each of them. Otherwise, if they're all
identical, leave them as a patternProperty.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v3 3/3] arm64: dts: ti: k3-am65-main: add system controller compatible

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

Now that the TI K3 AM654 system controller bindings also cover the usage
in the main domain, add its compatible to address dtbs_check complaints:

  k3-am654-base-board.dtb: scm-conf@100000: compatible: ['syscon', 'simple-mfd'] is too short

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
index 06ed74197f89..a8664b246795 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
@@ -471,7 +471,7 @@ sdhci1: mmc@4fa0000 {
 	};
 
 	scm_conf: scm-conf@100000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,am654-system-controller", "syscon", "simple-mfd";
 		reg = <0 0x00100000 0 0x1c000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.43.0