[PATCH 0/3] Panel orientation quirks for AYA NEO handhelds

[PATCH 0/3] Panel orientation quirks for AYA NEO handhelds

[tjakobi]

From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>

Hello,

this is a re-submit of panel orientation quirks for some of the handheld
devices by vendor AYA NEO.

The quirks were posted to dri-devel some time ago, but got lost:
https://lore.kernel.org/lkml/20230621220615.1253571-2-samsagax@gmail.com/T/#u

With best wishes,
Tobias

Joaquín Ignacio Aramendía (3):
  drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model
  drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition
  drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK

 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

-- 
2.44.2

[PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

[tjakobi]

From: Joaquín Ignacio Aramendía <samsagax@gmail.com>

Add quirk orientation for AYA NEO 2. The name appears without spaces in
DMI strings. That made it difficult to reuse the 2021 match. Also the
display is larger in resolution.

Tested by the JELOS team that has been patching their own kernel for a
while now and confirmed by users in the AYA NEO and ChimeraOS discord
servers.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 2166208a961d..3044927c0c5c 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* AYA NEO AYANEO 2 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
+		},
+		.driver_data = (void *)&lcd1200x1920_rightside_up,
 	}, {	/* AYA NEO 2021 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
-- 
2.44.2

Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

[Dmitry Baryshkov]

On Mon, Sep 16, 2024 at 03:18:51PM GMT, tjakobi@math.uni-bielefeld.de wrote:
> From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> 
> Add quirk orientation for AYA NEO 2. The name appears without spaces in
> DMI strings. That made it difficult to reuse the 2021 match. Also the
> display is larger in resolution.
> 
> Tested by the JELOS team that has been patching their own kernel for a
> while now and confirmed by users in the AYA NEO and ChimeraOS discord
> servers.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 2166208a961d..3044927c0c5c 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
>  		},
>  		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* AYA NEO AYANEO 2 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
> +		},
> +		.driver_data = (void *)&lcd1200x1920_rightside_up,

I thought that AYANEO should come after AYADEVICE, but the array doesn't
seem really sorted. Thus:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

If I hear no objections and if noone beats me, I'll apply the series
within few days.


>  	}, {	/* AYA NEO 2021 */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
> -- 
> 2.44.2
> 

-- 
With best wishes
Dmitry

Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

[Hans de Goede]

Hi,

On 21-Sep-24 10:02 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 16, 2024 at 03:18:51PM GMT, tjakobi@math.uni-bielefeld.de wrote:
>> From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
>>
>> Add quirk orientation for AYA NEO 2. The name appears without spaces in
>> DMI strings. That made it difficult to reuse the 2021 match. Also the
>> display is larger in resolution.
>>
>> Tested by the JELOS team that has been patching their own kernel for a
>> while now and confirmed by users in the AYA NEO and ChimeraOS discord
>> servers.
>>
>> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index 2166208a961d..3044927c0c5c 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
>>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
>>  		},
>>  		.driver_data = (void *)&lcd800x1280_rightside_up,
>> +	}, {	/* AYA NEO AYANEO 2 */
>> +		.matches = {
>> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
>> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
>> +		},
>> +		.driver_data = (void *)&lcd1200x1920_rightside_up,
> 
> I thought that AYANEO should come after AYADEVICE, but the array doesn't
> seem really sorted

It is sorted but it is sorted by the Vendor - Model in the comments,
not by the DMI strings since sometimes those are e.g. "SYS_VENDOR",
"Default String" and stuff like that.

The entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

> Thus:
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> If I hear no objections and if noone beats me, I'll apply the series
> within few days.

I'm currently travelling so if you can apply this series
to drm-misc-fixes that would be great.

Regards,

Hans


> 
> 
>>  	}, {	/* AYA NEO 2021 */
>>  		.matches = {
>>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
>> -- 
>> 2.44.2
>>
> 

Re: [PATCH 1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model

[Dmitry Baryshkov]

On Sun, 22 Sept 2024 at 13:11, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 21-Sep-24 10:02 PM, Dmitry Baryshkov wrote:
> > On Mon, Sep 16, 2024 at 03:18:51PM GMT, tjakobi@math.uni-bielefeld.de wrote:
> >> From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> >>
> >> Add quirk orientation for AYA NEO 2. The name appears without spaces in
> >> DMI strings. That made it difficult to reuse the 2021 match. Also the
> >> display is larger in resolution.
> >>
> >> Tested by the JELOS team that has been patching their own kernel for a
> >> while now and confirmed by users in the AYA NEO and ChimeraOS discord
> >> servers.
> >>
> >> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> >> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> >> ---
> >>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> >> index 2166208a961d..3044927c0c5c 100644
> >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> >> @@ -184,6 +184,12 @@ static const struct dmi_system_id orientation_data[] = {
> >>                DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"),
> >>              },
> >>              .driver_data = (void *)&lcd800x1280_rightside_up,
> >> +    }, {    /* AYA NEO AYANEO 2 */
> >> +            .matches = {
> >> +              DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> >> +              DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYANEO 2"),
> >> +            },
> >> +            .driver_data = (void *)&lcd1200x1920_rightside_up,
> >
> > I thought that AYANEO should come after AYADEVICE, but the array doesn't
> > seem really sorted
>
> It is sorted but it is sorted by the Vendor - Model in the comments,
> not by the DMI strings since sometimes those are e.g. "SYS_VENDOR",
> "Default String" and stuff like that.

Ah, I didn't notice that.  I think it's still not fully sorted (e.g.
KUN comes after NEXT), but that's probably fine.

>
> The entire series looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> for the series.
>
> > Thus:
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >
> > If I hear no objections and if noone beats me, I'll apply the series
> > within few days.
>
> I'm currently travelling so if you can apply this series
> to drm-misc-fixes that would be great.

Done.

>
> Regards,
>
> Hans
>
>
> >
> >
> >>      }, {    /* AYA NEO 2021 */
> >>              .matches = {
> >>                DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYADEVICE"),
> >> --
> >> 2.44.2
> >>
> >
>


-- 
With best wishes
Dmitry

[PATCH 2/3] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition

[tjakobi]

From: Joaquín Ignacio Aramendía <samsagax@gmail.com>

Add quirk orientation for AYA NEO Founder. The name appears with spaces in
DMI strings as other devices of the brand. The panel is the same as the
NEXT and 2021 models. Those could not be reused as the former has VENDOR
name as "AYANEO" without spaces and the latter has "AYADEVICE".

Tested by the JELOS team that has been patching their own kernel for a
while now and confirmed by users in the AYA NEO and ChimeraOS discord
servers.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3044927c0c5c..d1302123071e 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -202,6 +202,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_MATCH(DMI_PRODUCT_NAME, "AIR"),
 		},
 		.driver_data = (void *)&lcd1080x1920_leftside_up,
+	}, {	/* AYA NEO Founder */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYA NEO"),
+		  DMI_MATCH(DMI_PRODUCT_NAME, "AYA NEO Founder"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* AYA NEO NEXT */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
-- 
2.44.2

Re: [PATCH 2/3] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition

[Dmitry Baryshkov]

On Mon, Sep 16, 2024 at 03:18:53PM GMT, tjakobi@math.uni-bielefeld.de wrote:
> From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> 
> Add quirk orientation for AYA NEO Founder. The name appears with spaces in
> DMI strings as other devices of the brand. The panel is the same as the
> NEXT and 2021 models. Those could not be reused as the former has VENDOR
> name as "AYANEO" without spaces and the latter has "AYADEVICE".
> 
> Tested by the JELOS team that has been patching their own kernel for a
> while now and confirmed by users in the AYA NEO and ChimeraOS discord
> servers.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

[PATCH 3/3] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK

[tjakobi]

From: Joaquín Ignacio Aramendía <samsagax@gmail.com>

Add quirk orientation for AYA NEO GEEK. The name appears without
spaces in DMI strings. The board name is completely different to
the previous models making it difficult to reuse their quirks
despite being the same resolution and using the same orientation.

Tested by the JELOS team that has been patching their own kernel for a
while now and confirmed by users in the AYA NEO and ChimeraOS discord
servers.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index d1302123071e..1e556f9dd574 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -208,6 +208,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_MATCH(DMI_PRODUCT_NAME, "AYA NEO Founder"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* AYA NEO GEEK */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
+		  DMI_MATCH(DMI_PRODUCT_NAME, "GEEK"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* AYA NEO NEXT */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
-- 
2.44.2

Re: [PATCH 3/3] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK

[Dmitry Baryshkov]

On Mon, Sep 16, 2024 at 03:18:55PM GMT, tjakobi@math.uni-bielefeld.de wrote:
> From: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> 
> Add quirk orientation for AYA NEO GEEK. The name appears without
> spaces in DMI strings. The board name is completely different to
> the previous models making it difficult to reuse their quirks
> despite being the same resolution and using the same orientation.
> 
> Tested by the JELOS team that has been patching their own kernel for a
> while now and confirmed by users in the AYA NEO and ChimeraOS discord
> servers.
> 
> Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
-- 
With best wishes
Dmitry

Re: [PATCH 0/3] Panel orientation quirks for AYA NEO handhelds

[Dmitry Baryshkov]

On Mon, 16 Sep 2024 15:18:49 +0200, tjakobi@math.uni-bielefeld.de wrote:
> From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> 
> Hello,
> 
> this is a re-submit of panel orientation quirks for some of the handheld
> devices by vendor AYA NEO.
> 
> [...]

Applied to drm-misc-next, thanks!

[1/3] drm: panel-orientation-quirks: Add quirk for AYA NEO 2 model
      commit: 361ebf5ef843b0aa1704c72eb26b91cf76c3c5b7
[2/3] drm: panel-orientation-quirks: Add quirk for AYA NEO Founder edition
      commit: d7972d735ca80a40a571bf753c138263981a5698
[3/3] drm: panel-orientation-quirks: Add quirk for AYA NEO GEEK
      commit: 428656feb972ca99200fc127b5aecb574efd9d3d

Best regards,
-- 
With best wishes
Dmitry