linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tjakobi@math.uni-bielefeld.de
To: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Subject: [PATCH 0/4] hwmon: (oxp-sensors) Cleanup device type handling
Date: Thu, 26 Dec 2024 18:00:15 +0100	[thread overview]
Message-ID: <cover.1735232354.git.tjakobi@math.uni-bielefeld.de> (raw)

From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>

Hello,

this series tries to cleanup the handling of the various device types
in the oxp-sensors drivers. The current approach is error-prone
since it relies on ever-growing switch-statements, which are
present in multiple functions. Adding a single new device involves
touching a bunch of functions.

That this is problematic is already demonstrated by this bug in
the driver: While oxp_pwm_disable() handles the aya_neo_air_1s
model, the inverse function oxp_pwm_enable() does not handle the
model. This is obviously wrong and a result of the current design.

Introduce a different design with better separation of logic and
data. While at it, also fix some typos, wording and add a cache
for the PWM enable mode.

With best wishes,
Tobias

Tobias Jakobi (4):
  hwmon: (oxp-sensors) Separate logic from device-specific data
  hwmon: (oxp-sensors) Fix typos in documentation
  hwmon: (oxp-sensors) Fix wording in code comment
  hwmon: (oxp-sensors) Cache state of PWM enable mode

 Documentation/hwmon/oxp-sensors.rst |   2 +-
 drivers/hwmon/oxp-sensors.c         | 576 +++++++++++++---------------
 2 files changed, 275 insertions(+), 303 deletions(-)

-- 
2.45.2


             reply	other threads:[~2024-12-26 17:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 17:00 tjakobi [this message]
2024-12-26 17:00 ` [PATCH 1/4] hwmon: (oxp-sensors) Separate logic from device-specific data tjakobi
2024-12-26 20:54   ` Guenter Roeck
2024-12-26 22:59     ` Tobias Jakobi
2025-01-07 17:33       ` Guenter Roeck
2024-12-26 21:04   ` Guenter Roeck
2024-12-26 23:05     ` Tobias Jakobi
2025-01-07 17:34       ` Guenter Roeck
2024-12-26 17:00 ` [PATCH 2/4] hwmon: (oxp-sensors) Fix typos in documentation tjakobi
2024-12-26 17:00 ` [PATCH 3/4] hwmon: (oxp-sensors) Fix wording in code comment tjakobi
2024-12-26 20:52   ` Guenter Roeck
2024-12-26 22:56     ` Tobias Jakobi
2025-01-07 17:24       ` Guenter Roeck
2024-12-26 17:00 ` [PATCH 4/4] hwmon: (oxp-sensors) Cache state of PWM enable mode tjakobi
2024-12-26 21:05   ` Guenter Roeck
2024-12-26 23:13     ` Tobias Jakobi
2025-01-07 17:43       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1735232354.git.tjakobi@math.uni-bielefeld.de \
    --to=tjakobi@math.uni-bielefeld.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).