Re: [PATCH v7 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM

Uwe Kleine-König
2025-02-05T16:33:41Z

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

Hello,

On Wed, Feb 05, 2025 at 08:57:20PM +0800, Chen Wang wrote:
> On 2025/2/5 18:06, Uwe Kleine-König wrote:
> > I was tempted to apply this patch while reading throug it until nearly
> > the end ...
> >
> > > + reset_control_assert(rst);
> >
> > This is wrong (well, or unneeded). With
> > devm_reset_control_get_optional_shared_deasserted() the devm cleanup
> > cares for reasserting the reset.
> >
> > > + return dev_err_probe(dev, ret, "Failed to register PWM chip\n");
> > > + }
> > > +
> > > + return 0;
> > > +}
> >
> > If you want I can apply and squash the following in:
> >
> > [...]
> >
> > ack?
>
> Ack.

Great. Pushed to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

with the suggested fixup.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]