Re: [PATCH v2 17/45] power: supply: ab8500_chargalg: Switch to use hrtimer_setup()

Sebastian Reichel
2025-02-08T17:42:38Z

[-- Attachment #1: Type: text/plain, Size: 1828 bytes --]

Hi,

On Wed, Feb 05, 2025 at 11:46:05AM +0100, Nam Cao wrote:
> hrtimer_setup() takes the callback function pointer as argument and
> initializes the timer completely.
>
> Replace hrtimer_init() and the open coded initialization of
> hrtimer::function with the new setup mechanism.
>
> Patch was created by using Coccinelle.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Zack Rusin <zack.rusin@broadcom.com>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> drivers/power/supply/ab8500_chargalg.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
> index 7a8d1feb8e90..dc6c8b0dd1cf 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -1787,13 +1787,12 @@ static int ab8500_chargalg_probe(struct platform_device *pdev)
> psy_cfg.drv_data = di;
>
> /* Initilialize safety timer */
> - hrtimer_init(&di->safety_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> - di->safety_timer.function = ab8500_chargalg_safety_timer_expired;
> + hrtimer_setup(&di->safety_timer, ab8500_chargalg_safety_timer_expired, CLOCK_MONOTONIC,
> + HRTIMER_MODE_REL);
>
> /* Initilialize maintenance timer */
> - hrtimer_init(&di->maintenance_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> - di->maintenance_timer.function =
> - ab8500_chargalg_maintenance_timer_expired;
> + hrtimer_setup(&di->maintenance_timer, ab8500_chargalg_maintenance_timer_expired,
> + CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>
> /* Init work for chargalg */
> INIT_DEFERRABLE_WORK(&di->chargalg_periodic_work,
> --
> 2.39.5
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]