From: Nicolin Chen <nicolinc@nvidia.com>
To: <jgg@nvidia.com>
Cc: <robin.murphy@arm.com>, <joro@8bytes.org>, <will@kernel.org>,
<kevin.tian@intel.com>, <baolu.lu@linux.intel.com>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<nathan@kernel.org>, <arnd@arndb.de>
Subject: [PATCH v5 0/3] iommu: Clean up cookie and sw_msi in struct iommu_domain
Date: Mon, 24 Mar 2025 21:05:14 -0700 [thread overview]
Message-ID: <cover.1742871535.git.nicolinc@nvidia.com> (raw)
A few things in iommu_domain structure (such as iova_cookie, iommufd_hwpt,
fault handler, and etc) are exclusive to certain types of iommu_domains.
So, all of them can be seen as domain cookies in different cookie types.
Furthermore, iova_cookie is shared with the msi_cookie use case. It could
be cleaner by decoupling these too.
Define an enum iommu_domain_cookie_type to fit all those cookies in.
Since there are only two sw_msi implementations, check domain->cookie_type
in iommu_dma_prepare_msi() to call the corresponding sw_msi function.
This is a clean-up series for the previous sw_msi Part-1 core series. It's
on github:
https://github.com/nicolinc/iommufd/commits/iommufd_msi_cleanup-v5
Changelog
v5
* Add IMPORT line for IOMMUFD_INTERNAL and change IOMMUFD_DRIVER_CORE
to a "bool" module, fixing build module errors reported by Arnd:
https://lore.kernel.org/all/20250324210329.2809869-1-arnd@kernel.org/
* In iommu_dma_prepare_msi(), let all IDENTITY DOMAINs pass through,
fixing the regression with IDENTITY domains reported by Nathan:
https://lore.kernel.org/linux-iommu/20250324162558.GA198799@ax162/
v4
https://lore.kernel.org/all/cover.1741294235.git.nicolinc@nvidia.com/
* Rebase on top of a bug fix for hwpt_iommufd cookie
https://lore.kernel.org/all/20250305211800.229465-1-nicolinc@nvidia.com/
* Add Reviewed-by from Robin and Kevin
* Add missing "break;" in iommu_domain_free()
* Drop "linux/msi.h" header from the iommufd/device code
* Set iommufd_sw_msi_install's SYMBOL to "IOMMUFD_INTERNAL"
* Update commit messages for typo fixing and size comparison
* Add a local msi_page_list to cache cookie_msi_pages(domain) return
* Add an inline iommufd_group_setup_msi() for !CONFIG_IRQ_MSI_IOMMU
v3
https://lore.kernel.org/all/cover.1741034885.git.nicolinc@nvidia.com/
* Integrate Robin's patch
https://lore.kernel.org/linux-iommu/4e68d5820be06adc1b34fc0d1c9399481151daee.1740742271.git.robin.murphy@arm.com/
replacing private_data_owner with the new cookie_type
* Move iommu_sw_msi stub from the public header to iommu-priv.h
v2
https://lore.kernel.org/all/cover.1740705776.git.nicolinc@nvidia.com/
* Drop sw_msi function pointer
* Add a new private_data_owner tag in iommu_domain
* Let iommu core call the two sw_msi implementations directly
v1
https://lore.kernel.org/all/cover.1740600272.git.nicolinc@nvidia.com/
Thanks
Nicolin
Nicolin Chen (2):
iommufd: Move iommufd_sw_msi and related functions to driver.c
iommu: Drop sw_msi from iommu_domain
Robin Murphy (1):
iommu: Sort out domain user data
drivers/iommu/iommufd/Kconfig | 2 +-
drivers/iommu/dma-iommu.h | 14 ++
drivers/iommu/iommu-priv.h | 13 ++
drivers/iommu/iommufd/iommufd_private.h | 7 +-
include/linux/iommu.h | 35 ++--
drivers/iommu/dma-iommu.c | 208 ++++++++++++------------
drivers/iommu/iommu-sva.c | 1 +
drivers/iommu/iommu.c | 36 +++-
drivers/iommu/iommufd/device.c | 131 +--------------
drivers/iommu/iommufd/driver.c | 126 ++++++++++++++
drivers/iommu/iommufd/hw_pagetable.c | 6 +-
11 files changed, 323 insertions(+), 256 deletions(-)
base-commit: da0c56520e880441d0503d0cf0d6853dcfb5f1a4
--
2.43.0
next reply other threads:[~2025-03-25 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 4:05 Nicolin Chen [this message]
2025-03-25 4:05 ` [PATCH v5 1/3] iommu: Sort out domain user data Nicolin Chen
2025-03-25 4:05 ` [PATCH v5 2/3] iommufd: Move iommufd_sw_msi and related functions to driver.c Nicolin Chen
2025-03-25 4:05 ` [PATCH v5 3/3] iommu: Drop sw_msi from iommu_domain Nicolin Chen
2025-03-25 4:14 ` [PATCH v5 0/3] iommu: Clean up cookie and sw_msi in struct iommu_domain Nicolin Chen
2025-03-25 12:40 ` Jason Gunthorpe
2025-03-25 13:21 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1742871535.git.nicolinc@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=arnd@arndb.de \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox