From: Ying Lu <luying526@gmail.com>
To: oneukum@suse.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, luying1 <luying1@xiaomi.com>
Subject: [PATCH v1 0/1] usbnet:fix NPE during rx_complete
Date: Tue, 1 Apr 2025 18:18:00 +0800 [thread overview]
Message-ID: <cover.1743497376.git.luying1@xiaomi.com> (raw)
From: luying1 <luying1@xiaomi.com>
The patchset fix the issue caused by the following modifications:
commit 04e906839a053f092ef53f4fb2d610983412b904
(usbnet: fix cyclical race on disconnect with work queue)
The issue:
The usb_submit_urb function lacks a usbnet_going_away validation,
whereas __usbnet_queue_skb includes this check. This inconsistency
creates a race condition where: A URB request may succeed, but
the corresponding SKB data fails to be queued.
Subsequent processes (e.g., rx_complete → defer_bh → __skb_unlink(skb, list))
attempt to access skb->next, triggering a NULL pointer dereference (Kernel Panic).
Fix issue:
adding the usbnet_going_away check in usb_submit_urb to synchronize the validation logic.
luying1 (1):
usbnet:fix NPE during rx_complete
drivers/net/usb/usbnet.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.40.1
next reply other threads:[~2025-04-01 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 10:18 Ying Lu [this message]
2025-04-01 10:18 ` [PATCH v1 1/1] usbnet:fix NPE during rx_complete Ying Lu
2025-04-01 10:29 ` Greg KH
2025-04-01 12:48 ` Ying Lu
2025-04-01 13:46 ` Greg KH
2025-04-02 0:12 ` Ying Lu
2025-04-02 7:11 ` Greg KH
2025-04-02 8:17 ` Ying Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1743497376.git.luying1@xiaomi.com \
--to=luying526@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luying1@xiaomi.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).