From: Nicolin Chen <nicolinc@nvidia.com>
To: <jgg@nvidia.com>, <joro@8bytes.org>, <will@kernel.org>,
<robin.murphy@arm.com>, <bhelgaas@google.com>
Cc: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <patches@lists.linux.dev>,
<pjaroszynski@nvidia.com>, <vsethi@nvidia.com>
Subject: [PATCH RFC v1 0/2] iommu&pci: Disable ATS during FLR resets
Date: Mon, 9 Jun 2025 11:45:12 -0700 [thread overview]
Message-ID: <cover.1749494161.git.nicolinc@nvidia.com> (raw)
Hi all,
Per PCIe r6.3, sec 10.3.1 IMPLEMENTATION NOTE, software should disable ATS
before initiating a Function Level Reset, and then ensure no invalidation
requests being issued to a device when its ATS capability is disabled.
Both pci_enable_ats() and pci_disable_ats() are called by an IOMMU driver,
but an unsolicited FLR can happen at any time in the PCI layer. This might
result in a race between them, breaking the rules given by the PCIe Spec.
Therefore, there needs to be a sync between IOMMU and PCI subsystems, to
ensure that ATS will be disabled and never gets re-enabled until the FLR
finishes. Add a pair of new IOMMU helpers for PCI reset functions to call
before and after the reset routines. These two helpers will temporally
attach the device's RID/PASID to IOMMU_DOMAIN_BLOCKED, which should allow
its IOMMU driver to pause any DMA traffic and disable ATS feature until
the FLR is done.
This is on Github:
https://github.com/nicolinc/iommufd/commits/iommu_dev_reset-rfcv1
Thanks
Nicolin
Nicolin Chen (2):
iommu: Introduce iommu_dev_reset_prepare() and iommu_dev_reset_done()
pci: Suspend ATS before doing FLR
include/linux/iommu.h | 12 +++++
drivers/iommu/iommu.c | 106 ++++++++++++++++++++++++++++++++++++++++++
drivers/pci/pci.c | 42 +++++++++++++++--
3 files changed, 156 insertions(+), 4 deletions(-)
--
2.43.0
next reply other threads:[~2025-06-09 18:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 18:45 Nicolin Chen [this message]
2025-06-09 18:45 ` [PATCH RFC v1 1/2] iommu: Introduce iommu_dev_reset_prepare() and iommu_dev_reset_done() Nicolin Chen
2025-06-10 4:26 ` Baolu Lu
2025-06-10 7:07 ` Nicolin Chen
2025-06-10 13:04 ` Jason Gunthorpe
2025-06-10 14:40 ` Robin Murphy
2025-06-10 15:36 ` Jason Gunthorpe
2025-06-10 16:31 ` Robin Murphy
2025-06-10 16:43 ` Jason Gunthorpe
2025-06-10 20:19 ` Nicolin Chen
2025-06-10 23:41 ` Jason Gunthorpe
2025-06-09 18:45 ` [PATCH RFC v1 2/2] pci: Suspend ATS before doing FLR Nicolin Chen
2025-06-10 4:27 ` Baolu Lu
2025-06-10 6:55 ` Nicolin Chen
2025-06-10 15:37 ` [PATCH RFC v1 0/2] iommu&pci: Disable ATS during FLR resets Robin Murphy
2025-06-10 16:30 ` Jason Gunthorpe
2025-06-10 20:36 ` Nicolin Chen
2025-06-10 23:43 ` Jason Gunthorpe
2025-06-13 19:27 ` Bjorn Helgaas
2025-06-13 21:10 ` Nicolin Chen
2025-06-16 13:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1749494161.git.nicolinc@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=pjaroszynski@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=vsethi@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).