From: Abdun Nihaal <abdun.nihaal@gmail.com>
To: andy@kernel.org
Cc: Abdun Nihaal <abdun.nihaal@gmail.com>,
dan.carpenter@linaro.org, gregkh@linuxfoundation.org,
lorenzo.stoakes@oracle.com, tzimmermann@suse.de,
riyandhiman14@gmail.com, willy@infradead.org, notro@tronnes.org,
thomas.petazzoni@free-electrons.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] staging: fbtft: cleanup fbtft_framebuffer_alloc()
Date: Sun, 29 Jun 2025 20:10:09 +0530 [thread overview]
Message-ID: <cover.1751207100.git.abdun.nihaal@gmail.com> (raw)
Fix a potential memory leak and cleanup error handling in
fbtft_framebuffer_alloc().
v3:
- Remove a redundant check before calling kfree
v2:
- Change the earlier patch to also handle the error code returned by
fb_deferred_io_init() and update Fixes tag to point to the commit that
introduced the memory allocation (which leads to leak).
- Add second patch to make the error handling order symmetric to
fbtft_framebuffer_release() and also remove managed allocation for
txbuf as suggested by Andy and Dan.
Link to v2: https://lore.kernel.org/linux-staging/cover.1751086324.git.abdun.nihaal@gmail.com/T/#md111471ddd69e6ddb0a6b98e565551ffbd791a34
Link to v1: https://lore.kernel.org/all/20250626172412.18355-1-abdun.nihaal@gmail.com/
Abdun Nihaal (2):
staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc()
staging: fbtft: cleanup error handling in fbtft_framebuffer_alloc()
drivers/staging/fbtft/fbtft-core.c | 38 +++++++++++++++++-------------
1 file changed, 21 insertions(+), 17 deletions(-)
--
2.43.0
next reply other threads:[~2025-06-29 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 14:40 Abdun Nihaal [this message]
2025-06-29 14:40 ` [PATCH v3 1/2] staging: fbtft: fix potential memory leak in fbtft_framebuffer_alloc() Abdun Nihaal
2025-06-29 14:40 ` [PATCH v3 2/2] staging: fbtft: cleanup error handling " Abdun Nihaal
2025-06-30 17:16 ` Greg KH
2025-06-30 19:17 ` Abdun Nihaal
2025-07-01 5:14 ` Greg KH
2025-07-01 7:03 ` Andy Shevchenko
2025-07-01 8:51 ` Abdun Nihaal
2025-07-01 14:22 ` Dan Carpenter
2025-06-30 9:58 ` [PATCH v3 0/2] staging: fbtft: cleanup fbtft_framebuffer_alloc() Andy Shevchenko
2025-06-30 16:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1751207100.git.abdun.nihaal@gmail.com \
--to=abdun.nihaal@gmail.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=notro@tronnes.org \
--cc=riyandhiman14@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tzimmermann@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).