Re: [PATCH v1 1/3] dt-bindings: iio: adc: Add AD4134

Conor Dooley
2025-11-10T19:07:30Z

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Mon, Nov 10, 2025 at 09:45:18AM -0300, Marcelo Schmitt wrote:

> + adi,control-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Describes whether the device is wired to an SPI interface or not. The

Can you explain how you don't automagically know this from what bus
you're on?

> + PIN/SPI pin on the device must be set accordingly, i.e., PIN/SPI must be
> + set to logic high for SPI Control Mode, low for Pin Control Mode. When
> + absent, implies the SPI interface configuration.
> + enum: [ spi-control-mode, pin-control-mode ]
> + default: spi-control-mode
> +
> + adi,asrc-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Asynchronous Sample Rate Converter (ASRC) operation mode control input.
> + Describes whether the MODE pin is set to a high level (for master mode
> + operation) or to a low level (for slave mode operation).

I don't really get this one. If this is an input to the device that
controls behaviour (master v slave) why is an option needed too? Clearly
this is not a gpio but it seems like it could be one, in which case you'd
need some sort of asrc-gpios property. Is it not possible to read the
value of this setting out of the device's registers (maybe it's not when
there's no spi interface connected?)?
It's not used in your driver, so I can't look there easily to see what's
going on.

> + enum: [ high, low ]
> + default: low

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]