Re: [PATCH v1 0/3] iio: adc: Add AD4134 minimum I/O support

Andy Shevchenko
2025-11-10T12:54:09Z

On Mon, Nov 10, 2025 at 09:44:56AM -0300, Marcelo Schmitt wrote:
> This patch series adds basic support for ad4134. AD4134 is a very flexible
> device that can be configured in many different ways. This series aims to
> support the simplest way of interfacing with AD4134 which is called minimum I/O
> mode in data sheet. This is essentially usual SPI with the addition of an ODR
> (Output Data Rate) GPIO which functions as conversion start signal in minimum
> I/O mode. The CS pin may be connected to a host controller CS pin or grounded.
>
> This set provides just one feature:
> - Single-shot ADC sample read.
>
> [PATCH 1] Device tree documentation for AD4134.
> [PATCH 2] IIO Linux driver for AD4134.
> [PATCH 3] Initial IIO documentation.
>
> There is a driver by Cosmin on ADI Linux tree that supports AD4134 in wiring
> configurations suited for high speed data transfers. Even though the minimum I/O
> support was initialy based on that high speed transfer driver, the result ended
> up becoming entirely different. Also, because the different wiring
> configurations are likely going to use different resources and software
> interfaces, the code for AD4134 support was split into ad4134-spi.c,
> ad4134-common.h, and ad4134-common.c.

The cover letter misses the answer to: "Why do we need a brand new driver?
Don't we have anything similar already in IIO that can be expanded to cover
this one?"

--
With Best Regards,
Andy Shevchenko