Re: [PATCH v1 0/3] iio: adc: Add AD4134 minimum I/O support

Nuno Sá
2025-11-10T14:48:12Z

On Mon, 2025-11-10 at 09:44 -0300, Marcelo Schmitt wrote:
> This patch series adds basic support for ad4134. AD4134 is a very flexible
> device that can be configured in many different ways. This series aims to
> support the simplest way of interfacing with AD4134 which is called minimum I/O
> mode in data sheet. This is essentially usual SPI with the addition of an ODR
> (Output Data Rate) GPIO which functions as conversion start signal in minimum
> I/O mode. The CS pin may be connected to a host controller CS pin or grounded.
>
> This set provides just one feature:
> - Single-shot ADC sample read.
>
> [PATCH 1] Device tree documentation for AD4134.
> [PATCH 2] IIO Linux driver for AD4134.
> [PATCH 3] Initial IIO documentation.
>
> There is a driver by Cosmin on ADI Linux tree that supports AD4134 in wiring
> configurations suited for high speed data transfers. Even though the minimum I/O
> support was initialy based on that high speed transfer driver, the result ended
> up becoming entirely different. Also, because the different wiring
> configurations are likely going to use different resources and software
> interfaces, the code for AD4134 support was split into ad4134-spi.c,
> ad4134-common.h, and ad4134-common.c.

I'm familiar with the odd way this part is implemented in ADI tree :). Question is, are
you intending to support the high speed bits? I guess so, otherwise having the above split
would not make much sense.

- Nuno Sá

>
> With best regards,
> Marcelo
>
> Marcelo Schmitt (3):
>   dt-bindings: iio: adc: Add AD4134
>   iio: adc: Initial support for AD4134
>   Docs: iio: Add AD4134
>
>  .../bindings/iio/adc/adi,ad4134.yaml          | 209 +++++++++++++
>  Documentation/iio/ad4134.rst                  |  58 ++++
>  Documentation/iio/index.rst                   |   1 +
>  MAINTAINERS                                   |   9 +
>  drivers/iio/adc/Kconfig                       |  15 +
>  drivers/iio/adc/Makefile                      |   2 +
>  drivers/iio/adc/ad4134-common.c               | 200 ++++++++++++
>  drivers/iio/adc/ad4134-common.h               | 132 ++++++++
>  drivers/iio/adc/ad4134-spi.c                  | 287 ++++++++++++++++++
>  9 files changed, 913 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
>  create mode 100644 Documentation/iio/ad4134.rst
>  create mode 100644 drivers/iio/adc/ad4134-common.c
>  create mode 100644 drivers/iio/adc/ad4134-common.h
>  create mode 100644 drivers/iio/adc/ad4134-spi.c
>
>
> base-commit: c5411c8b9ed1caf53604bb1a5be3f487988efc98