From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 842E026E6F5 for ; Tue, 18 Nov 2025 00:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763425646; cv=none; b=AL0fSs7/+dEib0SNZzpxNZgCkYtQReoS+m9KU3tMFzDcpJrHwCUAN75Li13cqoyRbb4SWdhAtKsizEEBi7bwSo3i2MgfgFCC/BYwstRiPuMfA6ZdilMW+4l9TzjuJMPRdUsqtmopEazpq6a18HgO7wvP0b/ZuRfm9xp6v/DrFqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763425646; c=relaxed/simple; bh=nlPHRzqL3P7AYSrGKbubBYTx+jzUX2FJFkFsKmVcKEQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rkh/pHg7BHEQeE6ieFlbifCtBCHt96hmcMWPTu2it0weJYjg0xpKcN2xQSoYAxXgZXlaidWfZb3bBqsE8ZW1VFJiEdAqJfP2IRE9RWHdBxQvgNniIZqOkl3kxmDVsYt/SnVFTpw3eEG3tx54mXlQq5g05pwQtyahzxHhEZnXlrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DMwiMV5y; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DMwiMV5y" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b7373fba6d1so510246066b.3 for ; Mon, 17 Nov 2025 16:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763425643; x=1764030443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=prCp0tfH2qTYxZSAKZHBGjZXVGST3CfQUhmEicSbPrs=; b=DMwiMV5ysVJZp+S7d6WtOuTYTVx0l90cXxY/h4UCPq2ym13EWt372WjDk1261PcZWZ r2uLKmH6aWX8NLVXzK/uN/i6T9Fm6zB2eM06HOSdbvT4UY5cBR2JYAXvzgUDSaPG3Y60 u3775XfAkO2z6F+ueY6snbUI8ivW7yggqk0+G4JL3YpltC0W6W9k5Ih7rtpQShzLrECn nXMDmFKR/8zhjbPY7TFQhqwe9kGb5SY58kKyZV3wQ+yTl7z6NUbXbxi5+0K5AYnm5Vmr nbuZU5qVubqzDKsCgsx5H0Q6wLrORqrv26c02Y5a7HWpIcXAhUZLZ5ba/+ePeygL2X1B aU4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763425643; x=1764030443; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=prCp0tfH2qTYxZSAKZHBGjZXVGST3CfQUhmEicSbPrs=; b=qJeAS8iiZY9qxtJnD9Vx25GmG/9qVS2NQpoUMhMwvtKrkHzDKVjJjKLs3r5b5MRMcr KMjVyiKUjd2QJPLvd0mZ2DMOrI17tTexou9kB4vRVFR/TFRr2ELvqrk+nSXsAwL3vRUi n4dzBtFoihwb0v10oEvm8jvUBWJbkw5UJTvFrIpb8xK6GzZFPxeC+afAU51/TDa1RPbM Ak6/LJftm9EOyHJUPUpH7K9oZOLSS0kKnW+SYpcNTbJQzN9Ff8Uxl077FyyGO+0A4b01 LjRD2UOxK05qjgHhJJXDw+P7tV+7p15O1o0g6OArpfGvOOFLcAqBcFTrt9UaUJ3jVAQ+ wERA== X-Forwarded-Encrypted: i=1; AJvYcCU/3uog4QMi1elC1qSOnM6axuLAOj129ufS0IXA2w9f10yeIAD4qZ5J6WC0KBqJhk/DmZMJxYhCBmiCVDU=@vger.kernel.org X-Gm-Message-State: AOJu0YzqNZ/Wkozt6lHbw08J6QXZAh1ScsqlZf+6KHv93xrpDRmSeRtR IsKSIABZMqPVYFf4G+Nqhgd+9oBj5uC7jsnwViGhCUc5ljf/UMaO11hX X-Gm-Gg: ASbGncs9DCDvu2U2DC7GVEpKlPpIaGBUJAIMbanfRbCJ/lNY/Oo7EBUrsCIeDJtdts8 KEgfoPmF1+BCgjidkdQVdo+PM3iZhxzDEqZB6eYwtGHm/F8iXnL5dCS7w9X2ww/O7WXOApRcWo+ Wnolq0RfpqlOEunLXbCVLjRck8HO3T64lRjmiYOKcJgzC21kdeWG6odhIS5g17suC4W00OuQJkh dCpq2JDObn1hGbCaMS+iVM9/hmdR6YzdqffxcV0gA22gBreZoeMLMPNp5j8nwXrvs2vUTXuex3/ UgMVEhEzqm40bK18eijZJAxOOzZU4ER9u7gzPFXwMCw5TTaJfeNhnmwodiSY5wc2x+b3sZST3Ku QQLkn2eaI77NVQYWRog03YyZ3o3R/PPgnSb+692I17dgmt7mWs467J4nEyKQGGGVegUW3F997BY G7jSJ8o2oxgqR25uMgoXRQXA== X-Google-Smtp-Source: AGHT+IFu6cy9He+lLQZJ5Pa1M7Yv2fPYPsXHCqBqdYNgAfDgvPT859ppX8w6SN0ZkECS6zDf5Fb3/A== X-Received: by 2002:a17:907:7fa9:b0:b73:21db:64aa with SMTP id a640c23a62f3a-b7367983f2cmr1527425266b.38.1763425642660; Mon, 17 Nov 2025 16:27:22 -0800 (PST) Received: from eray-kasa.. ([2a02:4e0:2d08:f72:eb64:1d0d:5855:afe7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fda8a86sm1172606466b.52.2025.11.17.16.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 16:27:22 -0800 (PST) From: Ahmet Eray Karadag To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, Ahmet Eray Karadag Subject: [PATCH 0/2] ocfs2: Refactor read-only checks to use ocfs2_emergency_state Date: Tue, 18 Nov 2025 03:26:42 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, Following the fix for the `make_bad_inode` validation failure (syzbot ID: b93b65ee321c97861072), this separate series introduces a new helper function, `ocfs2_emergency_state()`, to improve and centralize read-only and error state checking. This is modeled after the `ext4_emergency_state()` pattern, providing a single, unified location for checking all filesystem-level emergency conditions. This makes the code cleaner and ensures that any future checks (e.g., for fatal error states) can be added in one place. This series is structured as follows: 1. The first patch introduces the `ocfs2_emergency_state()` helper (currently checking for -EROFS) and applies it to `ocfs2_setattr` to provide a "fail-fast" mechanism, as suggested by Albin Babu Varghese. 2. The second patch completes the refactoring by converting all remaining read-only checks throughout OCFS2 to use this new helper. Ahmet Eray Karadag (2): ocfs2: Add ocfs2_emergency_state helper and apply to setattr ocfs2: Convert remaining read-only checks to ocfs2_emergency_state fs/ocfs2/buffer_head_io.c | 4 ++-- fs/ocfs2/file.c | 23 ++++++++++++++++------- fs/ocfs2/inode.c | 3 +-- fs/ocfs2/move_extents.c | 5 +++-- fs/ocfs2/ocfs2.h | 8 ++++++++ fs/ocfs2/resize.c | 8 +++++--- fs/ocfs2/super.c | 2 +- 7 files changed, 36 insertions(+), 17 deletions(-) -- 2.43.0