From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F3921322F for ; Tue, 2 Dec 2025 02:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764644108; cv=none; b=kdTwbLQZG5n2wwhKd5MlUEmrr7qXRGO4Z0NfgsSN0MkJnYfpDZbPT3IhRMBRMKkK5LGqQReyG3zU1INGxtFA8EhUcAKwKlM/4T1K4Yx0C/5FIngMnMUuHdFUxBEbUZebFDHPiwCD/jZOGUxBVI55tE0QgfbFx661VCnOA8txbEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764644108; c=relaxed/simple; bh=k6DLSLxt2mS92AW9THnTfyPCYL+zu3tAMKUQnsjBdO4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CrUJdYQkcLoRUPEjeTN/UeLpEWG1XlxsRjtcTTp1aKTS3By8YqL9j3/RVioxhmfDqdzwShuxY8BnaMqgdbH76cgLYqg3YE8M61UHYXG8oVYddaADfgE+pLlJd5V1R12NH1+sqGKz4CBvYjvvEyKY1mlEkYpSh5VfdieKaPoZc/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FOBYedwO; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FOBYedwO" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-640ca678745so8534848a12.2 for ; Mon, 01 Dec 2025 18:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764644105; x=1765248905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ihzWcZQrPg9oGqI6ksnq5pPm895AlT5PWrtOUGngFrA=; b=FOBYedwOjTVhkHx0oqTYxesRYJji6scAzSWVUr6KMamGqG5uvls+xP4mhmbp5KuKG9 zzkIKuss/TtG5HQZ9/M6cJvCBF6NwhLJrvWO9v348g+WkpejRDAOkmWT5prygWIIW2Cv eDPjbU5NjeFUiYmqTt6C/hFB3h2ojMj26S4w1fjBim1AelUK5tRxdQvePckqyOfRc3f4 sdIp3dgQ9Y3WgK9WaFM4ZejWRmeX2oPcBqAIL8PmYgc2NfsPSGo5RwCbrmPMCYh2EYPd ILrUwllp84C8LKPdHJHdYQ/g8fg9l0nt0wD0XQMfb+Xz520jlybvC8Oi6CQ5lJz/GH+T cD4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764644105; x=1765248905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ihzWcZQrPg9oGqI6ksnq5pPm895AlT5PWrtOUGngFrA=; b=hM5nNHe6Lj8ZYRjwgTikZ8pPQzAswmq2Hg8IWI2h0wJ5SUi3l5iBRqvfWnpL5GjLv8 hFzOGAgZG0MA3WflWgn/Vgo60rjRmiQPhSpg8KcgguP+ZNS92TxaqIe/ENeNhIrfhWuB C6sO9o0XflJp5zdz/LqL+r8K6kEaPYpuiR/Md1oFcXjn93gFjBPcimrmHHdzkxlZl2k9 dAvSl/dMGlOWYGTdUSQCJI9tniHYi/eHvIC7hTuiEEGqijvOnvFPBrwdLnbZOoiZ9l1l 18YBi4rfFlAQmJ5BQy0bD/hUAVttALQVAI6Uaxfkd00meCapGGIp7qtYOcENR+CWCy1p 4meA== X-Forwarded-Encrypted: i=1; AJvYcCWdfmmr57ZUbvy8xrq7hWEhOFRvESMO74i3TobEUgM5hgkrjuxlED7Im7hQCW/bf03NJ2S7JgW6vAYzjSs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5M0h2Cc/w0VPYaFfOEBYNWZV0U9C7ZSVxBNmN/5Iv76izZ3MV y29LGF0ZmQA4AGpZO/h7MvrcjbWd9YskbM3wPerEl3KwcIE2H8BKaQ8Y X-Gm-Gg: ASbGnctiutrUvcP97OczFMxMN0sS4qqdc0QA4mz5samwnAxEIn4gmSeFDJmuCJ+gia4 1dp4Hhth8GXMEBJjr83ttIltGh5aPkAuTmxHJvTLk+9A4RUkM+0xhrW1eWdvvfEK7b4vMEzWSto 4UVit4/Qx58hXBRMsNtf9NcKEMAxt6M17PXzRV6gwUXoBVBJzCxqdpIjT6Dr33dYzw/PUAu86Eg 1K+YDob47WW0bSX8fA1CJmry4iWzQ1aDarij6uZFqo8mz4tCHLtzI9DRd4qIxuu+zwb0uawLeP/ JOihRGHHxvLXZnco97xjTnFDudDoiOgz15g3krwH6icF5tGik+ECcnpENI8yCz/W6KtjgS8x8d3 qIKdwWiIrpd07N4hkpfOtJz8YrCaE0o6sX29UAPOJyQPpIIK6BhgusxvgRkp2WpsST62flCgMAP UoWUAepA+NNcM= X-Google-Smtp-Source: AGHT+IHACKfZCb2Ae70WzhfT7RSHRzi/eUS7PAx9okIuPRvvx7+2XuYOSdwDoPe4xb+V0Jsucrla/A== X-Received: by 2002:a05:6402:518a:b0:641:8d6b:88cb with SMTP id 4fb4d7f45d1cf-64555cf06b5mr39537888a12.28.1764644104956; Mon, 01 Dec 2025 18:55:04 -0800 (PST) Received: from eray-kasa.. ([2a02:4e0:2d14:1a1:8eee:b306:2d20:a328]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751062261sm15753978a12.33.2025.12.01.18.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Dec 2025 18:55:03 -0800 (PST) From: Ahmet Eray Karadag To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, Ahmet Eray Karadag Subject: [PATCH v3 0/2] ocfs2: Refactor read-only checks to use ocfs2_emergency_state Date: Tue, 2 Dec 2025 05:54:56 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, Following the fix for the `make_bad_inode` validation failure (syzbot ID: b93b65ee321c97861072), this separate series introduces a new helper function, `ocfs2_emergency_state()`, to improve and centralize read-only and error state checking. This is modeled after the `ext4_emergency_state()` pattern, providing a single, unified location for checking all filesystem-level emergency conditions. This makes the code cleaner and ensures that any future checks (e.g., for fatal error states) can be added in one place. This series is structured as follows: 1. The first patch introduces the `ocfs2_emergency_state()` helper (currently checking for -EROFS) and applies it to `ocfs2_setattr` to provide a "fail-fast" mechanism, as suggested by Albin Babu Varghese. 2. The second patch completes the refactoring by converting all remaining read-only checks throughout OCFS2 to use this new helper. Previous-link: https://lore.kernel.org/all/cover.1763337347.git.eraykrdg1@gmail.com/ Ahmet Eray Karadag (2): ocfs2: Add ocfs2_emergency_state helper and apply to setattr ocfs2: Convert remaining read-only checks to ocfs2_emergency_state fs/ocfs2/buffer_head_io.c | 4 ++-- fs/ocfs2/file.c | 23 ++++++++++++++++------- fs/ocfs2/inode.c | 3 +-- fs/ocfs2/move_extents.c | 5 +++-- fs/ocfs2/ocfs2.h | 18 ++++++++++++++++++ fs/ocfs2/resize.c | 8 +++++--- fs/ocfs2/super.c | 2 +- 7 files changed, 46 insertions(+), 17 deletions(-) -- 2.43.0