From: Josh Poimboeuf <jpoimboe@kernel.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH v2 0/4] objtool: Improve code generation for annotation macros
Date: Tue, 2 Dec 2025 09:59:35 -0800 [thread overview]
Message-ID: <cover.1764694625.git.jpoimboe@kernel.org> (raw)
For tip/objtool/urgent (fixing a "regression" in code generation).
Changes since v1 (https://lore.kernel.org/cover.1764137163.git.jpoimboe@kernel.org):
- rebase on Linus's tree (bug.h conflicts)
As much as possible, undo the code generation damage introduced by
ANNOTATE_DATA_SPECIAL:
- Remove its usage in favor of SHF_MERGE + sh_entsize, where possible
- Print the annotation on a single line:
912: .pushsection ".discard.annotate_data", "M", @progbits, 8; .long 912b - .; .long 1; .popsection
- Remove the trailing newline/tab; let the invoking code decide on the
appropriate separator for the given context
Josh Poimboeuf (4):
x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage
x86/asm: Remove ANNOTATE_DATA_SPECIAL usage
objtool: Consolidate annotation macros
objtool: Remove newlines and tabs from annotation macros
arch/um/include/asm/Kbuild | 1 -
arch/um/include/shared/common-offsets.h | 3 ++
arch/x86/include/asm/alternative.h | 9 +++---
arch/x86/include/asm/asm.h | 25 ++++++++-------
arch/x86/include/asm/bug.h | 2 +-
arch/x86/include/asm/cpufeature.h | 2 +-
arch/x86/include/asm/irq_stack.h | 2 +-
arch/x86/include/asm/jump_label.h | 2 +-
arch/x86/include/asm/nospec-branch.h | 4 +--
arch/x86/include/asm/paravirt_types.h | 2 +-
arch/x86/include/asm/smap.h | 8 ++---
arch/x86/include/asm/static_call.h | 2 +-
arch/x86/kernel/alternative.c | 4 +--
arch/x86/kernel/asm-offsets.c | 3 ++
arch/x86/kernel/rethook.c | 2 +-
arch/x86/kernel/static_call.c | 4 +--
arch/x86/lib/error-inject.c | 2 +-
arch/x86/um/shared/sysdep/kernel-offsets.h | 2 ++
include/linux/annotate.h | 36 +++++++++-------------
include/linux/objtool.h | 2 +-
kernel/bounds.c | 1 +
scripts/mod/devicetable-offsets.c | 1 +
22 files changed, 62 insertions(+), 57 deletions(-)
--
2.51.1
next reply other threads:[~2025-12-02 18:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 17:59 Josh Poimboeuf [this message]
2025-12-02 17:59 ` [PATCH v2 1/4] x86/alternative: Remove ANNOTATE_DATA_SPECIAL usage Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 2/4] x86/asm: " Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 3/4] objtool: Consolidate annotation macros Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-03 16:49 ` Linus Torvalds
2025-12-03 16:57 ` Ingo Molnar
2025-12-03 17:20 ` Josh Poimboeuf
2025-12-03 17:21 ` Linus Torvalds
2025-12-03 17:44 ` Linus Torvalds
2025-12-03 17:51 ` Josh Poimboeuf
2025-12-03 18:07 ` [PATCH] objtool: More annotation code generation tweaks Josh Poimboeuf
2025-12-03 18:48 ` [tip: objtool/urgent] objtool: Simplify .annotate_insn code generation output some more tip-bot2 for Josh Poimboeuf
2025-12-03 17:46 ` [tip: objtool/urgent] objtool: Consolidate annotation macros Josh Poimboeuf
2025-12-03 18:41 ` Linus Torvalds
2025-12-03 19:17 ` Josh Poimboeuf
2025-12-03 19:24 ` Linus Torvalds
2025-12-03 18:48 ` Ingo Molnar
2025-12-03 18:48 ` tip-bot2 for Josh Poimboeuf
2025-12-02 17:59 ` [PATCH v2 4/4] objtool: Remove newlines and tabs from " Josh Poimboeuf
2025-12-03 16:40 ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-12-03 18:48 ` tip-bot2 for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1764694625.git.jpoimboe@kernel.org \
--to=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox