From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36612265CDD for ; Wed, 3 Dec 2025 03:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764732880; cv=none; b=VkNXvNpE1vx9j/YyuBnoZi9EtfTY3jyujs/4YJ7KjPwyiDyxMIw5REAmkxi8WuxfoAPyxWFHYhbQBFNE12/feIcxFP08QR+AbHDAakY0c+2Ucbkql6XnDtYQGUaa7agTzEcGaf8Jbdcj60S0A03mtGk5uqmh1oLE3WTWkq3nbnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764732880; c=relaxed/simple; bh=qi15Ah+F44dT8AYjjw3VS3f4C3cM6+jo/K75bZqo14Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TsLbLne7gu/SdPaWuSUyluUmcojTe9VpXxvYnH+u+4JtlJYF61JVLdln6neRYFgX9C74GQdV8+f3VOlnjkK02gTbFXjcsjWWl1h8xhBMzhA1g2fmnmsLJ/RnTNXLQNoKPxau1Z7XT8fXkg7YezbyzEbIBwnFqAzuEUAnsrFFa/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lETOJW8g; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lETOJW8g" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-64175dfc338so11391980a12.0 for ; Tue, 02 Dec 2025 19:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764732877; x=1765337677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vz4Mn3OPrYWct1u156iuOzaLmXhDBuZgyPBJTaSamrw=; b=lETOJW8gV6LLn6q9WgpGmaP5colDbmfK4ws9UF6ENFSmVIR7xadB+qFZ3BVOCQcAkm HHEJEMwenBulRUg9Ye9cHE4LOCHt407VQc98spe6T5kX+GKZgWd0etE3S1akZvmF+0BY t2eKguA9kNTdwgzL9nMekSbC2RmurQtu+yz8bfJ7QJedp+YIYbcF2LDXE84cjR9vekqU v78x7BKBZOgF112OOtPP2X3KugIguCIZTR6rXWWUqVKpgsh0kfPfwxdEJnBXCFA+e7aX l+PY3r77pWbE1YqkttEXQbpb3cizgTL1A9jORpqwAzibsCfmlme5fyO23emVuzuLwEBc INlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764732877; x=1765337677; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vz4Mn3OPrYWct1u156iuOzaLmXhDBuZgyPBJTaSamrw=; b=cbgaI6lYO9isD2t8nZ5c4XNk5QBcN9WZHSMKIfS3u8YTRi2qS38Wwa0EN5PDwnHowm YIPHDgufa19mJTRgeakp71+9sG070ZfE7wu1uZtUnj3XkjXKbGNqKMZoYM2XrL/rqnN2 FbHLNVf/ywHPo4HANe06wTCz3XZksgC+VBfovsQ0/8IYbTJUyLMJuhrFf2EeZbkZMvgr m7raZBRe+SWlVY/k/17ez7wCk27TzogzrUxXHfVER5KvdMQ+Bc7vycNf2Y5n09qxocBp 4qZCzZ0M5cJG6QPoWIhDE+h+fGlCgtO9dVn+JgqAzOS8tEf/fVpmw3AEjVaKN5gphdjo bq6g== X-Forwarded-Encrypted: i=1; AJvYcCXbbKMTpuZn8D6ih7iK4ptq542ios/JKwYdvS3ByAdpzCk7kpeEnmrK34wX3n5hMwXsK+QkoSzNutDKHfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwlnYOigcyeM9CzL5YisAIo8LhvBCkyk2JDPL76G/W4/209D4Ay 3WdCsdyfsRALnZZ4VYM9buVrxFd8WWJ4GEMqWMisFXmwhV6QR8sUTjLP X-Gm-Gg: ASbGnctEIimXqm4g83U412SKb350To9Qd6flYPSkmrA2kluITGpKHuYU4fFU/VGK6y3 nOCB0aMSRArWQaaiyXjaP/FKugb02PG/6SSiBFEMpaQNCAmc6GfnelfDwdI6P+GmiWpYwM8i1si KAnxRxMxuoZoukCwEE3c0fMzRYNtFC8i5OnPPoJqpwM8BIFg4YliEGCj3MXw4N1EjzIEfHuoFP5 Z4Aj0mJIDyvfhc1ZAwjUO+SS/gvXofJTDxsvKpuLkSBIUnTT+ZUhKV0hs9Y4A7Thko9nRreHqFM j7yBubO7oPNhyxYR1bMinMHxC6Foo8vSA63S/ZYpcrXLmzD2rsj6RYnFudOctz3/tGC284d8jQD qPURPaOXVQhoEui2Z1Rh6ZwPhfBE2dMB71F+MVB3XFNP0B/QzSBkI+6uReMB4HGrz8J8kA8T/GF uVW4caXSRVfvFsdoF9QBaheA== X-Google-Smtp-Source: AGHT+IESJrLjVkBR5Rlyo0nu1FgBhpxujkaiZ6n1Lfs3udDV9FjV2q4mHIa2sG+Ioci6DUleCCOmAQ== X-Received: by 2002:a17:906:c10c:b0:b73:5958:7e6c with SMTP id a640c23a62f3a-b79dbe48f97mr68628766b.3.1764732877356; Tue, 02 Dec 2025 19:34:37 -0800 (PST) Received: from eray-kasa.. ([2a02:4e0:2d14:1a1:acf7:8de5:59bc:44c3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b757sm1658570066b.66.2025.12.02.19.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 19:34:37 -0800 (PST) From: Ahmet Eray Karadag To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, Ahmet Eray Karadag Subject: [PATCH v4 0/2] ocfs2: Refactor read-only checks to use ocfs2_emergency_state Date: Wed, 3 Dec 2025 06:34:24 +0300 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, Following the fix for the `make_bad_inode` validation failure (syzbot ID: b93b65ee321c97861072), this separate series introduces a new helper function, `ocfs2_emergency_state()`, to improve and centralize read-only and error state checking. This is modeled after the `ext4_emergency_state()` pattern, providing a single, unified location for checking all filesystem-level emergency conditions. This makes the code cleaner and ensures that any future checks (e.g., for fatal error states) can be added in one place. This series is structured as follows: 1. The first patch introduces the `ocfs2_emergency_state()` helper (currently checking for -EROFS) and applies it to `ocfs2_setattr` to provide a "fail-fast" mechanism, as suggested by Albin Babu Varghese. 2. The second patch completes the refactoring by converting all remaining read-only checks throughout OCFS2 to use this new helper. Previous-link: https://lore.kernel.org/all/cover.1764643790.git.eraykrdg1@gmail.com/ Ahmet Eray Karadag (2): ocfs2: Add ocfs2_emergency_state helper and apply to setattr ocfs2: Convert remaining read-only checks to ocfs2_emergency_state fs/ocfs2/buffer_head_io.c | 2 +- fs/ocfs2/file.c | 14 ++++++++++---- fs/ocfs2/inode.c | 3 +-- fs/ocfs2/move_extents.c | 2 +- fs/ocfs2/ocfs2.h | 18 ++++++++++++++++++ fs/ocfs2/resize.c | 4 ++-- fs/ocfs2/super.c | 2 +- 7 files changed, 34 insertions(+), 11 deletions(-) -- 2.43.0