From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D502765E2 for ; Thu, 18 Dec 2025 19:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766084804; cv=none; b=oKqB+K9fFMpaHpKnmOBNg+BR7ro6MlR9w37GP3lZjDxyiFwD/Xav6Vk3EIikQFOkvnJV3krJFMVbLO0nuxUnRJTq2gvb2LmDr4r2aHhUk2rUJvrs2XBxflh+Y517FTETt2IG9IlHM6hNhoXfD+OdtqlT+XR083Dh1210VB/2eWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766084804; c=relaxed/simple; bh=WEloQA/XIFfWLUJFGSkNRutlWTf+KyY3iz9RK9E79CE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=nD8SF+NRirk5AsljSUYmhpeXSVLCS1vITytbhkovQDucDUXig/vO7HTytMeODQcwJBBObVDZSnfRUgBlN1XnKmDqkUu7CO39IPSlnXu++KqhaSJhYqSmt27CtDy0VJbodpF1n94uFYArPzdGfsJRvv7qkFoZCHYvapn9TkNvDaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=bYiAIQjc; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="bYiAIQjc" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-64b8123c333so782034a12.3 for ; Thu, 18 Dec 2025 11:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1766084799; x=1766689599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=KZxHqu3SzujmiotRlzxJm3UYnzflG11IekQhIfmml9I=; b=bYiAIQjcpQ1P7CpNuSphu34YonpaInJhvMH4zNG/Ju2wfcsWOq1om3ZEGsIQsRppd5 0ef40PPMwlk+gYxR3Hnb2SwHG2hOi3TN6J2JbgtK82RXTuG+ABLidN/jSJSMuWX+LSG+ xoPkxaPqve+RfiQ0DSfwSGK0Nfz8Ie85I90kUGM3YByfeF/ldylbnybhsoqDF+8u973v YKm8+8g0TTLhnOdtvaYQPaMUoHwnwZrUlqU59yZE2L2wmvjfhcp/k5z2rODjQeL7anOe +gjzgC4HAsUJuHT46aDvTjAfirDLmOcmjK/kZVQbG61YBTtVJgDpQpTGaIGED4vo0wRG hB7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766084799; x=1766689599; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KZxHqu3SzujmiotRlzxJm3UYnzflG11IekQhIfmml9I=; b=SSyHyJjS/NNstfynk5FZxAdoU2nQ1IDzYNeWp+D7L98xcKxYhT8DEOOyOdPpRqwK8a su0jv7fXIdasjp9s6jvUtrz5QXpdwIBlQD4PG6IMeD3LKQCM7QfZQpMrJ1DYv6rQLGWg 2siEbYmCL3iO+FVM9SO+ls6atm540zrApzSq+y9hKypKGcR2Oiw5UXhKa4m5EDHBH5Jt 6dvQVWXSZAl8//duvWNWXZeG0loMJ+tDglELV4qF5+VCOg98s9ePkGr3dm8g0Z9hSGdc vR10zksJlHwwkDbgb1243ZUFUuEWDb32fRX84FiWD7iBFbctxD98SO/5iHPaghV8AHOM 4JMw== X-Forwarded-Encrypted: i=1; AJvYcCUwEu4HUPEIZ/dOxxnrK8DVP9xFcMY+m5eClWflB65iJHgLYj1u/kPAnefK5vlSPH2flpnkrqOfYiregqM=@vger.kernel.org X-Gm-Message-State: AOJu0YzZzAfzpXGjO3MuulcAEyU3ItBW4OOxTjRzYYR9YDwuTw9W330b WNz1j/Mc9yMPcLPY/Sk/wSMBttJv6xQOKOgmsFRWtjCdMiLCVmxR24hzB9dC6xI+DuI= X-Gm-Gg: AY/fxX4blavq6yP/EEEe4T2dRJD64Fvtw8ospS3MvFbX0SM4LiMpNw88VMS+HMwhMJM +1BCxOazVQsjhTM3LMdjhiQJAZS56ca9ipjm/XmmRn78kiMWw1pxhk2Lz8sE4o8Tglnzl2Hod0+ 5pr5koKehGMMpwp80roAyBykner0eIoeDQ0Eo01pmGt1c0TjYD1tSuLoaqLFLCy5nnu6bWCoqL6 gN9EzDqm/QTVMJTp1eRUE6ZUMEeO3qabp5ooxAfMAdEoI3eVmGWXWDEbcWEmufj/mIvGWWFMpk9 VClTn0wg01iQV0ItHJFBEQJRQJ1b2g0Hy8xzDobM1UjOZIKneUYD8OZBUtfC2JRu9Vb5p3JRjZC RVAWCsVVD2qt6dz2F7jZ55Lbi5NRw1M14P9UHrtdQ+NXUkANLsvM3IavoW1VTIDh1UNWnqlzRjE N568XEl4yoJee6Qw6Uuvc08frIYWpGjd5aLFk8I7NnGjGX7+iXZ+Eo6g== X-Google-Smtp-Source: AGHT+IHWG4LHoKaiiruOEBctdxAHnsbItZY+jg4X40WE9oC/dX/aDtGLSsf4UY9Cm0B4WQZVSPvMPw== X-Received: by 2002:a05:6402:40c9:b0:649:8be7:eda with SMTP id 4fb4d7f45d1cf-64b8e94d0demr435503a12.8.1766084799432; Thu, 18 Dec 2025 11:06:39 -0800 (PST) Received: from localhost (host-79-37-15-246.retail.telecomitalia.it. [79.37.15.246]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b91056731sm173599a12.8.2025.12.18.11.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 11:06:38 -0800 (PST) From: Andrea della Porta To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Andrea della Porta , Bjorn Helgaas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, iivanov@suse.de, svarbanov@suse.de, mbrugger@suse.com, Phil Elwell Subject: [PATCH 0/4] Fix RP1 DeviceTree hierarchy and drop overlay support Date: Thu, 18 Dec 2025 20:09:05 +0100 Message-ID: X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current RP1 implementation is plagued by several issues, as follows: - the node name for RP1 is too specific and should be generic instead (see [1]). - the fully defined DTS has its PCI hierarchy wrongly described. There should be a PCI root port between the root complex and the endpoint (see [1]). - since CONFIG_PCI_DYNAMIC_OF_NODES can be dropped in the future becoming an automatically enabled feature, it would be wise to not depend on it (see [2]). - overlay support has led to a lot of confusion. It's not really usable right now and users are not even used to it (see [3]). This patch aims at solving the aforementioned problems by amending the PCI topology as follows: ... pcie@1000120000 { ... pci@0,0 { device_type = "pci"; reg = <0x00 0x00 0x00 0x00 0x00>; ... dev@0,0 { compatible = "pci1de4,1"; reg = <0x10000 0x00 0x00 0x00 0x00>; ... pci-ep-bus@1 { compatible = "simple-bus"; ... /* peripherals child nodes */ }; }; }; }; The reg property is important since it permits the binding the OF device_node structure to the pci_dev, encoding the BDF in the upper portion of the address. This patch also drops the overlay support in favor of the fully described DT while streamlining it as a result. Links: [1] - https://lore.kernel.org/all/aTvz_OeVnciiqATz@apocalypse/ [2] - https://lore.kernel.org/all/CAL_JsqJUzB71QdMcxJtNZ7raoPcK+SfTh7EVzGmk=syo8xLKQw@mail.gmail.com/ [3] - https://lore.kernel.org/all/CAL_JsqJUzB71QdMcxJtNZ7raoPcK+SfTh7EVzGmk=syo8xLKQw@mail.gmail.com/ Andrea della Porta (4): dt-bindings: misc: pci1de4,1: add required reg property for endpoint misc: rp1: drop overlay support arm64: dts: broadcom: bcm2712: fix RP1 endpoint PCI topology arm64: dts: broadcom: rp1: drop RP1 overlay .../devicetree/bindings/misc/pci1de4,1.yaml | 8 +++- arch/arm64/boot/dts/broadcom/Makefile | 4 +- ...-ovl-rp1.dts => bcm2712-rpi-5-b-base.dtsi} | 0 .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 39 ++++++++++++------- arch/arm64/boot/dts/broadcom/rp1-nexus.dtsi | 14 ------- arch/arm64/boot/dts/broadcom/rp1.dtso | 11 ------ drivers/misc/rp1/Kconfig | 6 +-- drivers/misc/rp1/Makefile | 3 +- drivers/misc/rp1/rp1-pci.dtso | 25 ------------ drivers/misc/rp1/rp1_pci.c | 37 ++---------------- drivers/pci/quirks.c | 1 - 11 files changed, 40 insertions(+), 108 deletions(-) rename arch/arm64/boot/dts/broadcom/{bcm2712-rpi-5-b-ovl-rp1.dts => bcm2712-rpi-5-b-base.dtsi} (100%) delete mode 100644 arch/arm64/boot/dts/broadcom/rp1-nexus.dtsi delete mode 100644 arch/arm64/boot/dts/broadcom/rp1.dtso delete mode 100644 drivers/misc/rp1/rp1-pci.dtso -- 2.35.3