From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BC4A39448B for ; Fri, 27 Feb 2026 05:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170548; cv=none; b=JAL4TT7vPmy5qYKmj6ocM5i3Kes+eMVLV5Zu/1HHg+4GFVmhS7nSJMiKJYfmI+E1Jvh9oiMv56zOiDyuK/Aj2oVafdhfbg9Ac9cGAqnyCDzbXkhZ4hcK2sGpw8GpULv9GtEP5hQZDrP1KKP7IV2hBIO+fA2U4weZbpsIYLL/9R0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772170548; c=relaxed/simple; bh=6F3W35vU/J16kpZ9vXP91agnuRRh6iZ2Kw1OizQw1Y4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DNBT2cw0zI7JEvguZ/cpnY+2NKG/GFhmPlS53GDi93qURfb1EE9nspUPHAQ0PdVXyF0QGWtWk+KcmTrMBf4pqva0gpF6CXMD4of0w8K3CJtZAxq+QnhARdk+FfKzNSgFwZnv9UBtzpdJ/ZuTnIA21cwQssYkHXfqp8AabQloi8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nZb8nZy+; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nZb8nZy+" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-56a8584e3a2so1680915e0c.1 for ; Thu, 26 Feb 2026 21:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772170546; x=1772775346; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=cPTGvYA/GKdj9wqcQAjT8fmJEQ+pcQdfunMA1ORun7I=; b=nZb8nZy+F8l7JbmK5Dpw74DARUe4euk5pm+grODvGomFQH08ZU+4zCmjqtdyigwogZ zv/3RFJY/ACr3uykkHqBDpy4XZvDD81ZDLNmbIICP0W0vpnJ5wjy+OIW+/1iJ2x/6Qpv j4joMZHrW+Z7SI0svcUR+nbZa9Iu9auqXmlx2d+GbzzeY7rtaCuwS8Nq1AbohAYhisX+ AM5KrNYBP+9L8Z4kP8+HnQ+Rk1tTkaSEQP9j4ZxmU9cPtgpWQx8pKbDJEOF/cnNRFmg5 yXEGwAm6TiSKbwLx4xT4KVHJrX0YMkZQZP4u3ZrSl/knsq6wnK/tIM1rYisl1PMcGPyU kikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772170546; x=1772775346; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cPTGvYA/GKdj9wqcQAjT8fmJEQ+pcQdfunMA1ORun7I=; b=jl00IkgK6YQr6Bc5aHxZLwGlc6k41H5B/xDswxxgyHzCfHSeW0TjnKev+2Q5K1COSp h8lm0rTEogruV92ah71AnK9VduxAgaKs6xwnXVeykCgqCfe5kG/lpI0h25NVVNg70MfG PjhvtIrYfOr9CJ2SUTJQF4VEhy3spMPFkIV2eU2JVJ5egSxuZinCVbaHI3vzaNyPubje LzPxzj/3ivo4OHHV3dgTaRbQE/+2+6dWtqRf6cqubTK/3JGtZEw3WHkZk+12ERivEBJj jyRmqOdguowNZcnSAgocSsWXEXOxU6F3TNyz1y/6UpoOO8+tYerT/iEe55XIwfpKP6fF Qt6w== X-Forwarded-Encrypted: i=1; AJvYcCWdOWO5xmspqDIz0Q3fo2oCsb1KrMG8XbSrvj9mdz3/hnMirPfypDU82M9TeXbumPWUWLkYqEFzmVdkUYk=@vger.kernel.org X-Gm-Message-State: AOJu0YwSiOJ5CE0xtVayUrTKWFwJMHcwMKkY9IjwVGjio6eDFlnptI95 dE3ZxvqdzqWgruYM4zc71qusSoKETLI5Kjt4/eX6iuJZAGSFpOC8yHU+ X-Gm-Gg: ATEYQzwuWAFZ+20AYPbCkIzdOe6PkGd0UEDcyaUUlAmTsmKI1D5eD+M4oW8oMels7vX oQQDkW/svQlq6biXqdG0WSyAqYTu8vSWnYkdpCFjDF8dN0OfMZNf/4Q5KCOQ7fmLGwpgHWT6ot9 YM7JAWoYwGeC5U2wssbg32YLPD3mISu0GZBOFeCJb10gxNzQrzXzJqonv7b8h3/RU/Kjh4DjR5P RYjj0155NCrVQV4g+hazC3JOWaIH1Xrg0l1lf7ybDJWYihNy+OVJaXaGNgCZW3oL3zVwrY/PZcS PXG6xj/NlwR1rM35ZqBBcSsv/cnDvPdeNqgZktCJsxxh4wC3saTArRs+c3DHuKqgtncm9lvEb1i B/Yk5lUiEGlRkxb1yMFmtSRenpT/YmC4ZLYQFQv8BHZkEf7P4FQp2XAvH3qmsje73V4W7gvjszA 9qgiVEBBdF6w== X-Received: by 2002:a05:6122:4219:b0:566:2fc9:6c89 with SMTP id 71dfb90a1353d-56aa0a890a1mr1063240e0c.10.1772170546147; Thu, 26 Feb 2026 21:35:46 -0800 (PST) Received: from geday ([2804:7f2:800b:feb1::dead:c001]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56a9204b91esm5028673e0c.11.2026.02.26.21.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 21:35:44 -0800 (PST) Date: Fri, 27 Feb 2026 02:35:31 -0300 From: Geraldo Nascimento To: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Geraldo Nascimento , Dragan Simic Cc: linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/4] PCI: rockchip: 5.0 GT/s speed discouraged by Rockchip Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Dragan Simic already had warned me of potential issues with 5.0 GT/s speed operation in Rockchip PCIe. However, in recent interactions with Shawn Lin from Rockchip it came to my attention there's grave danger in the unknown errata regarding 5.0 GT/s operational speed of their PCIe core. Drop all code related to 5.0 GT/s operational speed from this driver. Endpoint Mode driver was not tested. There's a bit of redundancy in the commit messages but it's the best I could do to ensure people will actually understand why perfectly working code is being dropped. --- Changes in v4: - Incorporate suggestion by Bjorn and refined by Dragan to drop the "catastrophic" code - Link to v3: https://lore.kernel.org/linux-rockchip/cover.1772057799.git.geraldogabriel@gmail.com/T/ Changes in v3: - Clarify warning message even though Rockchip won't disclose details - Drop DT changes as they were applied as subset by Heiko - Link to v2: https://lore.kernel.org/all/cover.1763415705.git.geraldogabriel@gmail.com/T/ Changes in v2: - hard limit to 2.5 GT/s, not just warn - add Reported-by: and Reviewed-by: Dragan Simic - remove redundant declaration of max-link-speed from helios64 dts - fix Link: of helios64 patch - simplify RC mode comment - Link to v1: https://lore.kernel.org/all/aRhR79u5BPtRRFw3@geday/T/ --- Geraldo Nascimento (4): PCI: rockchip: drop 2.5 GT/s defines PCI: rockchip: drive at 2.5 GT/s only and error out other speeds PCI: rockchip-host: do not attempt 5.0 GT/s retraining PCI: rockchip-ep: do not attempt 5.0 GT/s retraining drivers/pci/controller/pcie-rockchip-ep.c | 13 ------------- drivers/pci/controller/pcie-rockchip-host.c | 20 -------------------- drivers/pci/controller/pcie-rockchip.c | 13 +++++-------- drivers/pci/controller/pcie-rockchip.h | 3 --- 4 files changed, 5 insertions(+), 44 deletions(-) -- 2.52.0