From: Waqar Hameed <waqar.hameed@axis.com>
To: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <kernel@axis.com>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: [RFC PATCH 0/2] Add driver for TI BQ25630 charger
Date: Fri, 27 Feb 2026 16:35:32 +0100 [thread overview]
Message-ID: <cover.1772201049.git.waqar.hameed@axis.com> (raw)
This patch series contains a fully working driver for the basic
functionality for the new TI BQ25630 charger (see datasheet [1]).
However, some functionality has no straightforward implementation. The
following features have therefore been left out and hopefully we can
have some design discussions to reach a clear resolution for the next
patch version (hence the RFC tag):
1. The USB OTG functionality (i.e. power *out* from the device) would
probably need a minor refactorization to use the MFD sub-system to
also register a regulator driver. Looking at the bq257xx driver,
this should be the preferred design?
2. Other drivers add a custom `sysfs` attributes for BATFET control.
See for example rt9471 and bq24190. Is this the preferred approach?
Should we add a new power `sysfs` class ABI for this? (There is a
TODO left in the code for this.)
I reckon it is quite common to have BATFET control for chargers,
i.e. being able to set them in "ship mode", "stand-by mode",
"shutdown mode" or "idle mode" (example values taken from the
`BATFET_CTRL` register field from datasheet [1])?
3. This device has liquid detection and corrosion mitigation. I
couldn't find any existing device driver with this kind of
functionality. The datasheet [1] even mentions "patent pending",
although it refers to the USB type-C Specification 2.3... :)
When liquid is detected in the charging port, an interrupt is
fired. Likewise, an interrupt can be fired when the port is dry
enough (according to some configured threshold value). My initial
thought was that maybe we can add "liquid detected" to the `health`
`sysfs` ABI? However, the question still remains though how one
should enable/disable and set threshold values for this (new power
class `sysfs` ABI or a custom one only for this driver)?
[1] https://www.ti.com/lit/gpn/bq25630
Waqar Hameed (2):
dt-bindings: power: supply: Add TI BQ25630 charger
power: supply: Add driver for TI BQ25630 charger
.../bindings/power/supply/bq25630.yaml | 68 ++
drivers/power/supply/Kconfig | 7 +
drivers/power/supply/Makefile | 1 +
drivers/power/supply/bq25630_charger.c | 1074 +++++++++++++++++
4 files changed, 1150 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/supply/bq25630.yaml
create mode 100644 drivers/power/supply/bq25630_charger.c
base-commit: f4d0ec0aa20d49f09dc01d82894ce80d72de0560
--
2.39.5
next reply other threads:[~2026-02-27 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 15:35 Waqar Hameed [this message]
2026-02-27 15:35 ` [RFC PATCH 1/2] dt-bindings: power: supply: Add TI BQ25630 charger Waqar Hameed
2026-02-27 17:31 ` Conor Dooley
2026-03-02 13:44 ` Waqar Hameed
2026-03-02 17:47 ` Conor Dooley
2026-03-04 16:16 ` Waqar Hameed
2026-02-27 15:35 ` [RFC PATCH 2/2] power: supply: Add driver for " Waqar Hameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1772201049.git.waqar.hameed@axis.com \
--to=waqar.hameed@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox