From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C990248880 for ; Sat, 28 Feb 2026 00:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240096; cv=none; b=CUX9ohwrPOfTTko74lkl9c+NNaoNoXGPoerDNIqMOBh2PvXnviyh01tBQ0Tac2QkIxT8wlIFHWu2umAB11RPNpDoIE6fIQix55pUGNg+A2KxPft+u9BqdfH+YNNVDaEHIGATSJIM3CAls7XpsUwpCMEvGXVwuAuEx4aLgYDUJcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772240096; c=relaxed/simple; bh=Gtpu7HR52/o57ZNKtvnSGR12WjLMNyqvF0KB5W4PZIU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=rjZqb0J2h6kvCm8QyWuJXQLlOJQaw+GI+BA8tZrrjAJWAbG4SK+SfBP6xyhSvG+nVo7bX/XVRZlmL1B1yKZWldM3u2NLcxtgAFWpLPJ8RF23vhAp7eavIrwWF+ab3RldUybJWfSFN5jcJpVHiGMwApICelT4yvBhZ6NC8d1AHs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OHII+sgW; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHII+sgW" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-56739adfa1aso2160242e0c.0 for ; Fri, 27 Feb 2026 16:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772240094; x=1772844894; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=oqjVAkGN45WCvwyHpK51yVytA2m9U+cdr8FXQh1dqPs=; b=OHII+sgW1y4alK0AQqJ4R3qYj25Mgy/jW/erkHgPbPOaH/56LwOji+PDqIMLy+lfee 8/ucjP/7jwHu4e8eOV67ngrM56Vh3kXBrgTiff+KkCD58uParzv1gU+/HUQCeg2yCwlA eIXDPPMeLty8ocJzSO1m+/X30ph3Q3yf9nm7Zl6jaNmHgMlsL/dVTxDquoDuek+5i+6H OrjSZR9UtiJevsU9Oc0gXex4EKNeT5pnwNw0x6+bkNbDhn7RJ4ZUFAcud+Bb3PrnLW1D e5OmqpKnBxuMYytrmb+PMt0OfkEaPQRRFMMa2enwTeqImJfeRPqeSMGZsQB0jKHAUJlq cVLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772240094; x=1772844894; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oqjVAkGN45WCvwyHpK51yVytA2m9U+cdr8FXQh1dqPs=; b=tAXjq324XLyj3bit3x5XVzfV0H93vcrulT45Y+9DUw2/tgHH1h1yJUOifEqZS9bqS8 Rv8QHJHPBbEy7/Z32Zej/GyRjPLdBcvCjPFVESqFhuaCBxNTDvY4uKc1Awjk3g9IGq83 T1uuX+gro8Xa43OGT1mtZv3B2QDYWSl6svaFw+krsdl6rqOIwt5ikUqx539hXXVoj9wV va4VYY8W9Hx1l22LgLWoPIkS8r48jE+ImcY0cb/PJ0q+yCDVT/DrPJ08pzJqDv2ZnNU8 64K1WdXfJI4jYfWy3mTLNJktZm+ch1m3qr/tI8hCqgajXgl05J0sLBtEGV+AnkUnyPVg Ogag== X-Forwarded-Encrypted: i=1; AJvYcCXb0meicrK+99fRiSaGhI5jcqL43qIryObN/w3sbqDNKYiJpBXNmk6En5zL6DKo3lYNhGtnrVCE3Cnvj70=@vger.kernel.org X-Gm-Message-State: AOJu0YwsJeJXK16OgT/GmHoeGfJ0YRxPm+5IlH8Bp3v/62KuVw++vvK6 L0dFx8oVcpi2kK5jqaadHF6eNKM2b+iaDagGXhCzU8Fn9zc5bINJ+9A7 X-Gm-Gg: ATEYQzxYv7XGqOAZGqSOoJOfWHOIHf/iSeGwpHhQ6nFLZAwTswCsWpF1cqzpEhhiLwr buiG5LY4zqNqCCLGPHsjf8bP2XisH69KHe9M4a/GWSnS+kRC1vswjECPNmJxuULDzUx6rZxUXNz D3i625XMyy/e1i1Lw9LUSNJ1pczC3FDu1Kue86LhB09BSHv7M5mGMpw+h6oDOGVR+mmGuQ10Euc IyFHgcOrlnbXoYaHYKUwvPYo8MvpvogiFOY8S7rXqIVTO0sWtgxCExSuf5Cbr3EjnKxEVpTCpKY pxqKcqpzWPJtpi9YP9gvHoNPY2Kf0Z04QOUpECCaEbe63C38m14moKD4utS55tlG8+/9d5f/kz8 as47nKoyukk0jUhkbIioXgZnnnvTk3WOo7lsJZOFYHFynRwKUjnsI52pN9V9bpIis8ZSDmITOxD 2Ri9C4Rek+kQ== X-Received: by 2002:a05:6122:d04:b0:544:c8bf:6509 with SMTP id 71dfb90a1353d-56aa09ec812mr2879599e0c.4.1772240094275; Fri, 27 Feb 2026 16:54:54 -0800 (PST) Received: from geday ([2804:7f2:800b:feb1::dead:c001]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56a91bd2291sm8371795e0c.9.2026.02.27.16.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 16:54:53 -0800 (PST) Date: Fri, 27 Feb 2026 21:54:41 -0300 From: Geraldo Nascimento To: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Geraldo Nascimento , Dragan Simic Cc: linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/4] PCI: rockchip: 5.0 GT/s speed discouraged by Rockchip Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Dragan Simic already had warned me of potential issues with 5.0 GT/s speed operation in Rockchip PCIe. However, in recent interactions with Shawn Lin from Rockchip it came to my attention there's grave danger in the unknown errata regarding 5.0 GT/s operational speed of their PCIe core. Drop all code related to 5.0 GT/s operational speed from this driver. Endpoint Mode driver was not tested. --- Changes in v5: - Changed commit order to not break builds and adjusted copy pasted commit message. (thanks Charalampos!) - Reintroduced behavior to force 2.5 GT/s in case there's something non-default in the DT. (thanks Dragan!) - Link to v4: https://lore.kernel.org/linux-rockchip/cover.1772169998.git.geraldogabriel@gmail.com/T/ Changes in v4: - Incorporate suggestion by Bjorn and refined by Dragan to drop the "catastrophic" code - Link to v3: https://lore.kernel.org/linux-rockchip/cover.1772057799.git.geraldogabriel@gmail.com/T/ Changes in v3: - Clarify warning message even though Rockchip won't disclose details - Drop DT changes as they were applied as subset by Heiko - Link to v2: https://lore.kernel.org/all/cover.1763415705.git.geraldogabriel@gmail.com/T/ Changes in v2: - hard limit to 2.5 GT/s, not just warn - add Reported-by: and Reviewed-by: Dragan Simic - remove redundant declaration of max-link-speed from helios64 dts - fix Link: of helios64 patch - simplify RC mode comment - Link to v1: https://lore.kernel.org/all/aRhR79u5BPtRRFw3@geday/T/ --- Geraldo Nascimento (4): PCI: rockchip-ep: do not attempt 5.0 GT/s retraining PCI: rockchip-host: do not attempt 5.0 GT/s retraining PCI: rockchip: drive at 2.5 GT/s, error other speeds PCI: rockchip: drop 5.0 GT/s defines drivers/pci/controller/pcie-rockchip-ep.c | 13 ------------- drivers/pci/controller/pcie-rockchip-host.c | 20 -------------------- drivers/pci/controller/pcie-rockchip.c | 15 +++++++++------ drivers/pci/controller/pcie-rockchip.h | 3 --- 4 files changed, 9 insertions(+), 42 deletions(-) -- 2.52.0