From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706C323C4FF for ; Fri, 15 May 2026 14:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778857078; cv=none; b=dkc6eLrmlpe4w7NQHU0mFukbR7xdVp1GjVH1zIOHdZSgROcCDGqTUN96R/naJYtEfws8diAO9P/ejudfL5G1t+l+hJsjJDtutZit3IJljTFiSUMxcEylYUTwT2rxzcZGwh4HgIBvnUE1EmrN4EclaEstFvsmcFJmfdO6ls1jyEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778857078; c=relaxed/simple; bh=/BeQcwQJYNrXslN9NRGyRDMaaMndwm55+LKP2W2hU8w=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=NE7OTN2te97H5PF5gv7TveTO0E0TBfVRFOXeNHjRIld6jIxZSmToQ8F3yCpVFd9TL+pfPJs9M8Yi9AGjWMQ++9bXRf8equdtct+VdeqgOLCzlm55/DIFurwPV+VQuYjfejoWjhWW+uJIqr2tKPROevojbqiESPwXg8txNuYJ7ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=St9axJV4; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="St9axJV4" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48896199cbaso79994575e9.1 for ; Fri, 15 May 2026 07:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778857075; x=1779461875; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=22ZZ7DskZ3gtFB87QcSA0WEWxlxsZu8Cspyfcc0WJQQ=; b=St9axJV4X09GLlqu/ZqdWhhBkaRQNV2dG4Jl5sG8fF2OfIj9oPPB5ZPEfdbLvg48Qz I8NTHeVyqKm2VQIu75rjiDLwQTZ4+pO1uwhsYf2h0IMzspiOIsRxwXgQITW9CmpGlbLj X93b8SvSN5p79DX10rWsDG7pyOcx4TlVPjfnyFEQ6UP8rgh/vC5yhwrYUDtEFjavkPxb uzGn56r0APkCX2f7beQ1r9Unp76mBknCKYphv7B2sbttXVp+6uYBnPhLXxx1RjH5g/23 O43TOjL3O0kvPHfDsFfpct3WxGAU2qy52DGsivf0NpKQB2kiIxH+C7gVxibXpmWFSZPY qauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778857075; x=1779461875; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=22ZZ7DskZ3gtFB87QcSA0WEWxlxsZu8Cspyfcc0WJQQ=; b=LgfS/4A7acGPnmpWU7fD7phBG0aLZpite+f64M29Liqt+8JcBOEhYj4AJEtxzpn2Dd SwmQzXoFfXS/3hxDOlZU+5yFy9THEHHtUh76UsMUJB6W0Fou7+dZkTrW2EvkYmBhCkiF UrmAXo7hnXxHKXDDzMtlu+2TO86cvi6a08lFxC4Nr85KPJFz7uXZas82rxBNgDi994Cc NFSeIWoe71tvUydcWNrcbDxDxgNbP/JuKdP2LfzggaYEHlGnPDDO1hOxSkGZJMZfLP8B 0kt5mNRb/uhHg4MagvIJG4n+nOe1FSgIUa3+uIJULVGYm1kVgCJ5LTltTjONZZmkIy/K RtPg== X-Forwarded-Encrypted: i=1; AFNElJ8Py5sB+hemAXRxRX2zBLzr21qpXO6sG6pN1J3b7TsOLZ0npthaHgVmKhMU/46MaDyQJQq3+rAWXgTbiZs=@vger.kernel.org X-Gm-Message-State: AOJu0YzLfJPFfo6YEl6fFazNU8KIuTCY+UzXthmAvLx4kil54jvirc+R KHMxIVzg0zghYnUdpMobXYAeYylc/jnkJkz5WoZZmfhdC1srWc5af+Py X-Gm-Gg: Acq92OEtopZ0Khzr6JSJiaMYE+s34KCztchMAY8elh5ee6fq51wsqgPZufbMbX7M/zU VMoTMylhd7gZuNowLXFu53SsmftWTPqfilo1FnNeLICHKFWQrwjbkW7Nt+RNHLGrWT08vBap/Td cR85DLaOtaGYROWdw5bzl40rAG9MeSbqahz9VWW5kvbfOgbWcbg6zztZekqlw2RR5pZUxmP2FUO wnNE1PFop5OLYxfyE+dE76u98YSvN447ZoR6TXGKbUaoeQn9jM1DaRaxdf9KJQxhFiRSu8mLBPk x4ahI3xNwEKSy7aZ1BVvKhFUdWUUCXb9B4NCKtz9ajJsCWpG80Uqoj2Wnvm9/HqVvR9vbffk8rB Yzrk9WnOBGjdRXglyzRlr2Gx/ZkgcnZqJMU6vSd1HIj+iymHaVOWxFEfcL9SI8E8jINEAklpPz8 pb/c3nayGq5WTuoH2jhMss9ljL+aqbiRdbwHY71O1T8/j+l3bGhGfAbFpbc+mUPYVUsV1qTr82I rwzc3Sq21/Pj3+30bMmSFSxfNjFfBSPV8HD71OIUpKxup0uhsDDkckVPTAtjfgbIDwTBQ== X-Received: by 2002:a05:600c:c087:b0:488:d6eb:e63c with SMTP id 5b1f17b1804b1-48fe61f2768mr47576105e9.15.1778857074555; Fri, 15 May 2026 07:57:54 -0700 (PDT) Received: from my-vps.. (ip212-227-39-93.pbiaas.com. [212.227.39.93]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe5ab527asm76096135e9.11.2026.05.15.07.57.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 07:57:54 -0700 (PDT) From: Louis Clinckx To: "Derek J . Clark" , Mark Pearson , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] HID: lenovo-go: clean up USB assumption Date: Fri, 15 May 2026 14:57:38 +0000 Message-Id: X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These drivers' id_tables only match HID_USB_DEVICE() entries and the code freely assumes a USB transport (to_usb_interface() on hdev->dev.parent, endpoint access in raw_event). Make the assumption explicit at probe and drop a NULL check that the compiler-level definition of to_usb_interface() makes unreachable. No functional change for the supported (USB) devices. Louis Clinckx (2): HID: lenovo-go: reject non-USB transports in probe HID: lenovo-go: drop dead NULL check on to_usb_interface() drivers/hid/hid-lenovo-go-s.c | 11 ++++++----- drivers/hid/hid-lenovo-go.c | 6 +++--- 2 files changed, 9 insertions(+), 8 deletions(-) --- Changes since v1: - Resubmitted on linux-input as a quality fix per Benjamin's review of v1 (sent to security@kernel.org; the HID_USB_DEVICE() id_table already filters BUS_USB, so no exploitable path). - Added patch 2 to remove the dead NULL check, at Derek's suggestion. base-commit: 50897c955902c93ae71c38698abb910525ebdc89 -- 2.39.5