From: Nicolin Chen <nicolinc@nvidia.com>
To: <jgg@nvidia.com>, <kevin.tian@intel.com>
Cc: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>
Subject: [PATCH rc v2 0/4] iommufd: Fix veventq_depth boundary
Date: Thu, 21 May 2026 17:36:31 -0700 [thread overview]
Message-ID: <cover.1779408671.git.nicolinc@nvidia.com> (raw)
The upper bound of veventq_depth has been missing for veventq allocation,
leaving a vulnerability where userspace could exhaust atomic memory pool.
Fix it properly:
- Allocate outside the spinlock to avoid GFP_ATOMIC
- Cap the veventq_depth upper bound
- Fix event_data byte-count
- Add selftest coverage
Note that QEMU's SMMU has been already allocating veventq using a "HW"
EVTQ entry number. So, picking 19 as the known use case, for a minimal
level of ABI consistency.
This is on github:
https://github.com/nicolinc/iommufd/commits/fix_veventq_depth-v2
Changelog:
v2
* Add Reviewed-by from Jason
* Rebase on Jason's for-rc tree
* Update commit message for clarification
* Move "data_len byte-count" to the first
* Drop optimistic read in the allocation path
v1
https://lore.kernel.org/all/cover.1779070992.git.nicolinc@nvidia.com/
Nicolin Chen (4):
iommufd: Fix data_len byte-count vs element-count mismatch
iommufd: Move vevent memory allocation outside spinlock
iommufd: Set veventq_depth upper bound
iommufd/selftest: Add boundary tests for veventq_depth
drivers/iommu/iommufd/iommufd_private.h | 2 +-
tools/testing/selftests/iommu/iommufd_utils.h | 17 +++++++++--------
drivers/iommu/iommufd/driver.c | 13 ++++++++-----
drivers/iommu/iommufd/eventq.c | 5 ++++-
tools/testing/selftests/iommu/iommufd.c | 19 +++++++++++++++++--
.../selftests/iommu/iommufd_fail_nth.c | 2 +-
6 files changed, 40 insertions(+), 18 deletions(-)
base-commit: be93d186ae88a92e7aa77e122d4e661fa57b1e39
--
2.43.0
next reply other threads:[~2026-05-22 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 0:36 Nicolin Chen [this message]
2026-05-22 0:36 ` [PATCH rc v2 1/4] iommufd: Fix data_len byte-count vs element-count mismatch Nicolin Chen
2026-05-22 0:36 ` [PATCH rc v2 2/4] iommufd: Move vevent memory allocation outside spinlock Nicolin Chen
2026-05-22 0:36 ` [PATCH rc v2 3/4] iommufd: Set veventq_depth upper bound Nicolin Chen
2026-05-22 0:36 ` [PATCH rc v2 4/4] iommufd/selftest: Add boundary tests for veventq_depth Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1779408671.git.nicolinc@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox