From: Sean Rhodes <sean@starlabs.systems>
To: platform-driver-x86@vger.kernel.org
Cc: "Tzung-Bi Shih" <tzungbi@kernel.org>,
"Brian Norris" <briannorris@chromium.org>,
"Julius Werner" <jwerner@chromium.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sean Rhodes" <sean@starlabs.systems>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev
Subject: [PATCH v2 0/1] coreboot CFR firmware attributes
Date: Thu, 9 Jul 2026 13:50:16 +0100 [thread overview]
Message-ID: <cover.1783601414.git.sean@starlabs.systems> (raw)
Hi,
This adds a firmware-attributes driver for coreboot CFR tables.
Changes since v1:
- Add explicit includes for the helper APIs used by the driver.
- Use __free(kfree) and no_free_ptr() for EFI name allocation.
- Use isascii() for EFI variable name validation.
- Convert the EFI write path mutex to scoped_guard().
- Rename the label/current-value parser to avoid default-value ambiguity.
- Use devm_kzalloc() and devm_mutex_init() for the driver state.
- Clarify that -EOPNOTSUPP after a successful EFI write is the
reboot-required path.
Tested on Star Labs Lite GLKR, firmware 26.07, Linux 6.17.0-35-generic:
loaded coreboot_table and coreboot-cfr as test modules, verified
firmware-attributes sysfs exposure, fwupd BIOS settings enumeration, and
the reboot-required write path with debug_level.
Thanks,
Sean
Sean Rhodes (1):
platform/x86: Add coreboot CFR firmware attributes
MAINTAINERS | 6 +
drivers/firmware/google/coreboot_table.h | 45 --
drivers/platform/x86/Kconfig | 13 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/coreboot-cfr.c | 986 +++++++++++++++++++++++
include/linux/coreboot.h | 147 ++++
6 files changed, 1153 insertions(+), 45 deletions(-)
create mode 100644 drivers/platform/x86/coreboot-cfr.c
next reply other threads:[~2026-07-09 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:50 Sean Rhodes [this message]
2026-07-09 12:50 ` [PATCH v2 1/1] platform/x86: Add coreboot CFR firmware attributes Sean Rhodes
2026-07-09 21:45 ` Julius Werner
2026-07-10 7:39 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1783601414.git.sean@starlabs.systems \
--to=sean@starlabs.systems \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox