The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Vishwaroop A <va@nvidia.com>
To: <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<jonathanh@nvidia.com>, <thierry.reding@gmail.com>,
	<linux-tegra@vger.kernel.org>, Vishwaroop A <va@nvidia.com>
Subject: [PATCH v6 0/2] spi: add new_device/delete_device sysfs interface
Date: Tue, 14 Jul 2026 10:09:42 +0000	[thread overview]
Message-ID: <cover.1784000000.git.va@nvidia.com> (raw)
In-Reply-To: <20260517201602.498135-1-va@nvidia.com>

Add I2C-style new_device/delete_device sysfs attributes to SPI host
controllers, allowing userspace to instantiate and remove SPI devices
at runtime without device-tree changes.

Patch 1 adds the new_device/delete_device attributes and the supporting
infrastructure (userspace_clients list, locking, dead flag).
Patch 2 adds the ABI and user-facing documentation.

Changes since v5:
  - Rebased on next-20260707 (v7.2-rc2); applies cleanly.
  - Added missing kernel-doc entries for the new struct fields
    (@userspace_node, @userspace_clients, @userspace_clients_lock,
    @dead).
  - new_device_store(): reject chip_select > U8_MAX to avoid silent
    truncation in spi_set_chipselect(); parse with %u instead of %hu.
  - new_device_store(): reject mode bits outside SPI_MODE_USER_MASK
    (mirrors spidev's SPI_IOC_WR_MODE32 filter).
  - new_device_store(): drop the unused 'n' / '%n' from sscanf().
  - Minor comment cleanup.

Changes since v4:
  - Removed spi_unregister_device() call from new_device_store()'s
    ctlr->dead teardown path; it raced with
    device_for_each_child(__unregister) in spi_unregister_controller().

Changes since v3:
  - Replaced holding add_lock across __spi_add_device() + list
    insertion (which caused an ABBA deadlock with kernfs) by a
    ctlr->dead flag checked under add_lock / userspace_clients_lock.
  - Used a compile-time #if IS_ENABLED() guard for the ctlr->dead
    check in __spi_add_device(), since the dead field is conditional.

Changes since v2:
  - Gated sysfs attributes and locking on CONFIG_SPI_DYNAMIC.

Changes since v1:
  - Added locking to prevent races between new_device_store() and
    concurrent spi_unregister_controller().

Link: https://lore.kernel.org/linux-spi/20260517201602.498135-1-va@nvidia.com/  # v5
Link: https://lore.kernel.org/linux-tegra/909f0c92-d110-4253-903e-5c81e21e12c9@nvidia.com/

Vishwaroop A (2):
  spi: add new_device/delete_device sysfs interface
  docs: spi: add documentation for userspace device instantiation

 .../ABI/testing/sysfs-class-spi-master        |  34 +++
 Documentation/spi/index.rst                   |   1 +
 Documentation/spi/instantiating-devices.rst   |  88 +++++++
 drivers/spi/spi.c                             | 238 +++++++++++++++++-
 include/linux/spi/spi.h                       |  21 ++
 5 files changed, 376 insertions(+), 6 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-spi-master
 create mode 100644 Documentation/spi/instantiating-devices.rst


base-commit: be5c93fa674f0fc3c8f359c2143abce6bbb422e6
-- 
2.17.1


       reply	other threads:[~2026-07-14 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260517201602.498135-1-va@nvidia.com>
2026-07-14 10:09 ` Vishwaroop A [this message]
2026-07-14 10:09   ` [PATCH v6 1/2] spi: add new_device/delete_device sysfs interface Vishwaroop A
2026-07-14 10:09   ` [PATCH v6 2/2] docs: spi: add documentation for userspace device instantiation Vishwaroop A
2026-07-14 11:53   ` [PATCH v6 0/2] spi: add new_device/delete_device sysfs interface Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1784000000.git.va@nvidia.com \
    --to=va@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox