From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97BC4457D4 for ; Tue, 4 Aug 2026 10:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785838398; cv=none; b=ea4SHRkqjnB8fd/XkLumvfb01E+d4rH2iKni+pEAdPACpCW23Yg4nFQbDhU/RCaC8qIedKIygnq+ffod/V28E7R46RAlduzltYoUZi2euNq96xH1wIhYR9NcxwYULYezf8a++B0hXPrDy9LGiqXU+LTXrjcd/UnrZXa6ey8cbsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785838398; c=relaxed/simple; bh=R4Rz3A3B0FYdVpxM4b2yW1U8TxbOL4wP+xDMOwkMtSE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eywixT3yhh0KHya4/7G2lFOLMN5RHix/WkatQR2hyNxa8GS4e6j5oSlrtk5P4zVMc4AsD8nnIH6VZAkHHHLz5MCeUqbceQQnc89mKxtctFqk90YXClsV5cOJtQe2yjEsAuqTK4vadX5e2ZGdnL/YaK8IB0p3+FVPSh1ucXAQgCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b=HDO8yhLe; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20251104.gappssmtp.com header.i=@starlabs-systems.20251104.gappssmtp.com header.b="HDO8yhLe" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4954d29264cso15727605e9.2 for ; Tue, 04 Aug 2026 03:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20251104.gappssmtp.com; s=20251104; t=1785838394; x=1786443194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JTO+yub/oHkWnNxE/PR+YPqKbJIe1H0uu4C2i4wSPEY=; b=HDO8yhLeRimprYkMnxvwfRiReP4WCCTyN6Gk8LUtG3fAVBYjNlAl4q3gPnq+qRKlsi EMzHGRsSXHc5KVNhMmEG1Oizxc6D7FiYGMbvlgk9ZkbginkQIi32SjE0otx7DdS/w5Up IRj5MwEpZoop/K88N0W9JqVVsUDnVgqZ4+etnaLON0xHqwrIkJn3i23f+sKIFnRv5xVB oq3+Fkq8moSZSLFteJpXotslzINInrvj5gEWVpDaadq8Mg3kA+VDaTk4JO2yywrLKmti vFBhR/RaaSv8EYCOmPYWFC+IsJNaDbsSyezGICLfQklZPksiFNRo/q6Ola0JHeOD495S 575g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785838394; x=1786443194; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JTO+yub/oHkWnNxE/PR+YPqKbJIe1H0uu4C2i4wSPEY=; b=jyyDpNv1J6SzM3bU1UTW0DFuMDAbXbCac7szBJ0hOkkP58/2n/j3BZqALP4N+db/MF Dy/upFCbA573N1FqavYny8NGlDOUFoJU69ThNnjNEjIVcDA0kWwjmk3wAURMqIR2H1d7 6Y18aPyVDpMeu7wQAiJWIiajWu5qzGZWiNFBPi53Eq0AUgHuCotuRUss6fGYxam72Wsm neiqB9pWjcN9kq82jVfgwr457RJX54/CGVt+9IDD9JoLZAxIi5X/Ic8eobTe5vybKV5E bQ8GD0z4XCw5SHn7z8RLJMRdFaNPAwtzlNguwx1Uh2VpTpYFavHZzjE8A7Odx3vV6Jik hWGA== X-Forwarded-Encrypted: i=1; AHgh+Rr3C5Qftb5/kdfVXzFODVAxmPMJRi7QDkh6ouA0il6mJmbU8VqPpQ9bHmiKCeBNdUvROWgMURjcZrFNeH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7cehR5m8f7JUyzrCi8B+P9hUfUGAC6Ajztk2v4/UR7AF+D4kv SqnUIlCYyyQ1cILaEXyAxxg6+JRsKLQSpJfpp72m/jHTPw16DG3gG8H+fr2CB4Uh7w== X-Gm-Gg: AR+sD11cFzTDgcEFfju94k8Gey8XVlg7rr79BuCrKFpZqi1nFbnI1WuLQKVVTDguBN+ 5f2VfzfeL/tWiHd72feM/eWd8TTKbJ0rJc4jqp1VtynNJfzM7AdDuI7OWaY7oNuMX87gGzdjsjS qG+MYmaFE+A9t10v7wx+nRgOZ7Ix3cjE/fE5mGySdO+b2nWSrJdREwiGHpHKDspoVeFRFcEteSA fzVwZr5iKy+xDpxzBEFIseunuAM5Se/AdDCxMd4kcCO6sgppZcL6zBRJVCmbh1D8Y8WbgVJabHO k7cQEg/NPRP4qoQymdNYciSwX+chmcgAfUOBogkOj0BrlqKfdqaxcuMee011nKZcnKoCy1spu7U /ON5OR8RRaYfMXMoN0jKE3STske2gFaFnI8ThvJfQo5E+2PtcKMD6+VBrPyBc6ufuXy0yuZzSOt KBR3dzzt6FphwKIBRvoeJPi6d3FIrqi/3sr9UztJpifiTZAMsPTdeS6fvdDLmW21/5TPxOuQWWV ExkF2DrGQwVG4KyLWuKU2Cm3uj7uRha X-Received: by 2002:a05:600d:6451:20b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-4980c66d950mr239212685e9.7.1785838393168; Tue, 04 Aug 2026 03:13:13 -0700 (PDT) Received: from horizon.localdomain ([216.128.28.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fcb0c5sm67300275e9.4.2026.08.04.03.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 03:13:12 -0700 (PDT) From: Sean Rhodes To: chrome-platform@lists.linux.dev Cc: Corentin Chary , "Luke D. Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com, Sean Rhodes , Florian Fainelli , Huacai Chen , "Michael S. Tsirkin" , Chen-Yu Tsai , Tzung-Bi Shih , Brian Norris , Julius Werner , Thomas Zimmermann , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Krzysztof Kozlowski , Bjorn Andersson , Geert Uytterhoeven , Dmitry Baryshkov , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Bjorn Helgaas , Danilo Krummrich , Takashi Sakamoto , Titouan Ameline de Cadeville , Kees Cook , dri-devel@lists.freedesktop.org, Oliver Lin Subject: [PATCH v11 0/4] coreboot CFR firmware attributes Date: Tue, 4 Aug 2026 11:13:05 +0100 Message-ID: X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the firmware attributes class helper out of platform/x86, rename the coreboot-table firmware driver directory from google to coreboot, and add a coreboot CFR firmware attributes driver. Changes in v11: - Keep the scoped cleanup in the CFR driver, but use explicit goto cleanup for the nested sysfs group registration path. Changes in v10: - Address the nested cleanup-path review on CFR attribute registration. Changes in v9: - Add the missing kstrtox.h include used by kstrtou32(). - Use a single kobject rollback path when setting registration fails. - Split a few helper locals for readability, including the pending reboot device lookup and enum-value population. - Avoid an intermediate void pointer cast while parsing numeric CFR options. - Check the possible-values buffer length before computing each label length. Tested on a Star Labs Byte with firmware 26.07: runtime APM_CNT apply was verified with power_led, and reboot-needed behavior was verified with debug_level. Sean Rhodes (4): platform/x86: Sort firmware attributes class includes firmware: Move firmware attributes class helper firmware: Rename google firmware directory to coreboot firmware: coreboot: Add CFR firmware attributes driver MAINTAINERS | 18 +- arch/arm64/configs/defconfig | 6 +- drivers/firmware/Kconfig | 5 +- drivers/firmware/Makefile | 3 +- drivers/firmware/{google => coreboot}/Kconfig | 88 +- drivers/firmware/coreboot/Makefile | 15 + drivers/firmware/{google => coreboot}/cbmem.c | 0 drivers/firmware/coreboot/coreboot-cfr.c | 1205 +++++++++++++++++ .../{google => coreboot}/coreboot_table.c | 0 .../{google => coreboot}/coreboot_table.h | 0 .../framebuffer-coreboot.c | 0 drivers/firmware/{google => coreboot}/gsmi.c | 0 .../memconsole-coreboot.c | 0 .../memconsole-x86-legacy.c | 0 .../{google => coreboot}/memconsole.c | 0 .../{google => coreboot}/memconsole.h | 6 +- drivers/firmware/{google => coreboot}/vpd.c | 0 .../{google => coreboot}/vpd_decode.c | 0 .../{google => coreboot}/vpd_decode.h | 0 .../firmware_attributes_class.c | 2 +- drivers/firmware/google/Makefile | 14 - drivers/gpu/drm/sysfb/Kconfig | 2 +- drivers/platform/x86/Kconfig | 3 - drivers/platform/x86/Makefile | 2 - drivers/platform/x86/asus-armoury.c | 2 +- .../x86/dell/dell-wmi-sysman/sysman.c | 9 +- drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 9 +- drivers/platform/x86/lenovo/think-lmi.c | 5 +- drivers/platform/x86/lenovo/wmi-other.c | 2 +- drivers/platform/x86/samsung-galaxybook.c | 3 +- .../linux/firmware_attributes.h | 6 +- 31 files changed, 1340 insertions(+), 65 deletions(-) rename drivers/firmware/{google => coreboot}/Kconfig (57%) create mode 100644 drivers/firmware/coreboot/Makefile rename drivers/firmware/{google => coreboot}/cbmem.c (100%) create mode 100644 drivers/firmware/coreboot/coreboot-cfr.c rename drivers/firmware/{google => coreboot}/coreboot_table.c (100%) rename drivers/firmware/{google => coreboot}/coreboot_table.h (100%) rename drivers/firmware/{google => coreboot}/framebuffer-coreboot.c (100%) rename drivers/firmware/{google => coreboot}/gsmi.c (100%) rename drivers/firmware/{google => coreboot}/memconsole-coreboot.c (100%) rename drivers/firmware/{google => coreboot}/memconsole-x86-legacy.c (100%) rename drivers/firmware/{google => coreboot}/memconsole.c (100%) rename drivers/firmware/{google => coreboot}/memconsole.h (82%) rename drivers/firmware/{google => coreboot}/vpd.c (100%) rename drivers/firmware/{google => coreboot}/vpd_decode.c (100%) rename drivers/firmware/{google => coreboot}/vpd_decode.h (100%) rename drivers/{platform/x86 => firmware}/firmware_attributes_class.c (94%) delete mode 100644 drivers/firmware/google/Makefile rename drivers/platform/x86/firmware_attributes_class.h => include/linux/firmware_attributes.h (60%)