From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 803FC38D404 for ; Wed, 5 Aug 2026 14:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940951; cv=none; b=MOq/5snOj0a+nfkA2KdXCvGVyzsxCGEvpOJoguGN0TkY+f6qtmCva0qXhKnbiAtKHriTnMNLtcHNnBEtsjpf0mhdydfeUHkRrHEmpAQ01uYJfDqA5BwXwqitvp2yJ4pE1yFMbC+/qFv/0zojAuLQ8yiA3djlfv9Y9ll2MoOvptE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785940951; c=relaxed/simple; bh=uTnRIkTX3ph3+tnWZyRlHWEpP/2E2kucujZ0zjms930=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MW1HHbtTNlpZJE2MLE7fvNuVJDaLDq45sSsB306s4k7810xmmOAuTZaQN3PgiVfZGvIUKaqyL7Fz8ewBDo7IWcNDJq64PCrFIcQlbemFVQUku0xNLcr1ZCXpY5DGr8Hxy5ceN1zeZIhe2mA3TDcRfZH7ybmQOrKdRKcKaScSRq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B8V7L/Yl; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B8V7L/Yl" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47de008b020so661854f8f.1 for ; Wed, 05 Aug 2026 07:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785940945; x=1786545745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=mCrelJAti2S/Rp6s22ZLk20Nrw4yj8Y/bW/BPR3eDNM=; b=B8V7L/Yl7Te85T5zblttJDhhogCOAEzRXHc+JaSk1gUnmxC/yFlut1Mph00/PQtRoB Dnhyu4Z05tps/mektTSOOTu+6TqPgxR+LRDJP+EYvomKHi04RhMb4iFOnB/qXmjEfmAT /Tu0mQ2wT3j7aFMQQp114iFcXMnEF8waKPPoZ60e6Ee9XJ7KS50s951HFIZFy9U3Fkky zl5q99ePnd7Kw2H6bMjkRnDujGJc3UNraW6ATkF28e+D2K6AAB0uliHL/iHH7GZg/Rpv 1YS90hkKw+mev4xFY5h6L+pA+18/fv2a3+USIxEbMxGNitDoLTkQquJa4K6hSV/bmSmd GVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785940945; x=1786545745; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mCrelJAti2S/Rp6s22ZLk20Nrw4yj8Y/bW/BPR3eDNM=; b=XE25akqI9MEAt3Mp5aYgNAAW96toEEAFL4IZCRUOtELjH1uzwFA+KxPCvUE8b1w9kl sx4y+NHzzHedT6tD55c/imh9CYeraiiVt8iOub9B5sT6kl0hhHKvIiX9++fXpt06lWub wqxl6IgzF4IoaGO4K0C800kYMvIqyCXsTbc+Xkf2QuX1iB1Bu3ye6BoD/dwD36e1D1Lv lRp+GYiy0kcUMYtHO8nkP6LTkLcPa/1iRxiNWmRD+YxZcVkZmB+1ETuFkJ/4qPar85fZ OSDSUpZkmnsilSLsO4BHfA1I0rudQycuvOV2X1qj/FFQldRNT3SM1pC3lNQK3Yi8ido0 M3wA== X-Forwarded-Encrypted: i=1; AHgh+RoqXIrNOwb9GuZLxZJCdFeb7RYVVcLLZd7VfcPsMBkjpniuUtwYx8/j1/c1x3eJqBBgXJ2wNrVsDCRFbMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzzm2LDFZ99QyqjE+yNBT8Jzc7b/g1EDOnmqLtvNYSWn7HD6STw po7kjSDIhMF5v9O2+jv5INeTdp7aQwN51AE7sTfaBfWHHhjVGYq9wIYJ X-Gm-Gg: AR+sD118umaGmyUuUcHoC2m1B9rbQ962JrmfBQa/8ZqPaEfIAJadSpGwEsP+Osfr/mV rJeIG+HnP1d+Gpdp4YChpdAPCjUuKU6Cn6sj3cHAP5ZqmN/0aTYLX5piknSKyiB/c+ZXjnqocN2 +bbxBYP7tMIWFnHnIuZK7+Ey+eW8ZAZ1twrTBnPL9cODX9Dsmnm5VM0CTFaqQ/afx1fZgeuz5EF XpwnVqv3N4MVxWYuYE3Nv3M2ak7Ook7N22TDBCdvOiyiHrP4CvIkQHN5qCKHYmZUeSPAKoDmcHI r+EgjJYyT8wN6lUdOZIUndLD65fyQS9xLkF8ncqf6AoYIvW8bIpCRKrW80koQfe1GRrCTZ2F8S6 u0QHZf0EQZ0QrIsOPIjVU339S65W39odFMeMJmYu5twI1VthNLBwGryTc712PWuRuCsQn9R8Z9x Xr6EJ4q2WfM/o60BZzui7BLLS7o8g0P8jcqxU94uuEV4KGByj8qFmflgEnwgpJa1hIdgRabxQMW HZ49e3KtLRIfVsILp1MG74= X-Received: by 2002:a05:6000:4a06:b0:47f:8603:a879 with SMTP id ffacd0b85a97d-47fec51a8f5mr12905406f8f.11.1785940945311; Wed, 05 Aug 2026 07:42:25 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:6df7:ffe8:d01:255d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec232333sm10094289f8f.18.2026.08.05.07.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 07:42:24 -0700 (PDT) From: Avi Weiss To: Andrew Morton Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Soheil Hassas Yeganeh , Arjun Roy , Eric Dumazet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH v2 0/3] mm: improve insert_pages() error handling Date: Wed, 5 Aug 2026 17:42:16 +0300 Message-ID: X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Improve insert_pages() error handling following review of the minor cleanup in v1. Rename the helper that populates the upper page-table levels, set error codes at their points of failure, and return -ENOMEM when that population fails. Thanks for the review. I'm new to Linux; most of my previous upstream work has been on NASA cFS and RTEMS. I agree that initializing the return value to zero and assigning each relevant error code at its failure site is clearer and more idiomatic. The second (middle) patch implements that cleanup. The pte_alloc() macro returns a boolean, so patch 2 tests it and assigns -ENOMEM explicitly rather than using its return value as an error code. Changes in v2: * rename walk_to_pmd() to populate_to_pmd() * set error codes at their points of failure and rename ret to err * split the cleanup and return-code change into separate patches * drop the Fixes tag because this is a general cleanup Avi Weiss (3): mm/memory.c: rename walk_to_pmd() to populate_to_pmd() mm/memory.c: simplify error handling in insert_pages() mm: return -ENOMEM for page-table allocation failure in insert_pages() mm/memory.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) base-commit: 848acc8ffe1b7cd5f1bf427b93069becfebc2c9d -- 2.43.0