From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E63619C553 for ; Wed, 20 Nov 2024 11:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732103253; cv=none; b=M+w9dg0AtShD5Kzy5AmockD6CMDU/kxusoQBUjbJdWlcFFpDTn8KmOLOw9eWQ2vY7d+xrIvjQWH6suabtZiaPjCE8igIzbdE+oozmKGDIXvjlk5RP/UdEJtALsFaYWprI8FGNwLbGo1lnE6agCwq29PkXT0lfmpvFH43ftDNZ/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732103253; c=relaxed/simple; bh=yEUSM/5dR847K6yqcp8QTo/S+d4ASsLJSI3yC9FydoU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e1qD/U0E0VOJJz3ouYDu+PfH1yYUKnPuHdHKJn3568uahlVtfng5B92r2yvrsoOId9eltorpwvNtkZlro9YnmiKmYJYJ7pqTZDqF5xnFjozPOQWVJ5aIscF+B5c//eOl0bMBr3S5GksDyCfGC5NoI1Rbk8Y7ZTRn5FU0cPafdyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E6wxRlwy; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E6wxRlwy" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-539e63c8678so4783178e87.0 for ; Wed, 20 Nov 2024 03:47:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732103249; x=1732708049; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dJFtAqhp3X0R4lOdvZ2r3USdMH+eAPxUwptYBdqe3Pw=; b=E6wxRlwyYuIuLmx3yZQFwG4d7Qtfz4e1UiwsFhPEvIis8jI/Z745HtbUxFD8mPr6kY d7YsPsje1dONmJMpmHfnuUSLCuZi8vIbTSJ90/CLiILO+0BKhCEXPnbt9Likk72I5+zb I7B2Z8AgvA8t13eouU3+V1Tts/g4IY82vLzpo6+FmzCK7jkoJunW3IXde/xO0JYAfP9C zobgCGHNo7wEPafxMhNW00IqIz/uBnEsYgcYI8QEnVhbBmi4xvS9/1jnx0Vr+n1Wq6fP H2TSFn+q2dtaATH9RrEKmW3Xxjcs+5Lq0+uLM3AS4qZzTcmFZkoIyIiZEjoQVCr0836A cj3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732103249; x=1732708049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dJFtAqhp3X0R4lOdvZ2r3USdMH+eAPxUwptYBdqe3Pw=; b=Hw5DC4Rezst6k3Zma8KmRZhqSDuqr7/7m8SNOFm9TO3O2RfidLVCKSah/R1lqu8AxB 1MiEvdtWR8KOD68yxvYlp/My8Md5XvlQmc8LofwnXsphap98a16Pg5Ld2kCeVp+33JOG yR4XEFjjHLR/pZSa6R8gg763Uc4GsO6Vh/sYKn4E676z+QP4593IHw86hqZ1yZdQ2bct qASeCOVe585TDK83qcgm41STpiEBcvSiQjWOWUduw8WFXNcalhDqDp0fWyifJJa1iBFK ywWqG2hbIWvsdRSGTNsY6RTLO9JHkJTGjM+vogW2jk5I3bJ11srQZ1g0HY/rkMEKDVd9 XSjA== X-Forwarded-Encrypted: i=1; AJvYcCWBuIxS6nR/R4UodBMAuz3zp9o0m/qVydL/1XkC8kE9UBlM0gUPwxKvFSIB9u7bpf9nCYlC738lK09wQKM=@vger.kernel.org X-Gm-Message-State: AOJu0YwesvV8oPBx5UaTNkZwVIt9x0hxhMvQEPuWT/6qlqVz+BXFymXD 7B0QQ2fz0B90rrQQTebHbtIkIoxO95erlYtFDUSq+qKitq+B4i/IiH3HLHgPSsw= X-Google-Smtp-Source: AGHT+IFgN81BwuakhVNlUrbTmfV59y85qdNvK5q+7qHNHoJCOed60HrFzITC+EJaIinpJ1WPb3899A== X-Received: by 2002:a05:6512:238b:b0:53d:a882:c2b1 with SMTP id 2adb3069b0e04-53dc1343077mr1010869e87.26.1732103248736; Wed, 20 Nov 2024 03:47:28 -0800 (PST) Received: from eriador.lumag.spb.ru (2001-14ba-a0c3-3a00--b8c.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::b8c]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dbd3fccd3sm612181e87.105.2024.11.20.03.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 03:47:27 -0800 (PST) Date: Wed, 20 Nov 2024 13:47:25 +0200 From: Dmitry Baryshkov To: Neil Armstrong Cc: Akhil P Oommen , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Connor Abbott , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 10/11] arm64: qcom: dts: sm8550: add interconnect and opp-peak-kBps for GPU Message-ID: References: <20241119-topic-sm8x50-gpu-bw-vote-v2-0-4deb87be2498@linaro.org> <20241119-topic-sm8x50-gpu-bw-vote-v2-10-4deb87be2498@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241119-topic-sm8x50-gpu-bw-vote-v2-10-4deb87be2498@linaro.org> On Tue, Nov 19, 2024 at 06:56:45PM +0100, Neil Armstrong wrote: > Each GPU OPP requires a specific peak DDR bandwidth, let's add > those to each OPP and also the related interconnect path. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi > index 9dc0ee3eb98f8711e01934e47331b99e3bb73682..808dce3a624197d38222f53fffa280e63088c1c1 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi > @@ -2113,6 +2113,9 @@ gpu: gpu@3d00000 { > qcom,gmu = <&gmu>; > #cooling-cells = <2>; > > + interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>; QCOM_ICC_TAG_ALWAYS > + interconnect-names = "gfx-mem"; > + > status = "disabled"; > > zap-shader { > @@ -2126,41 +2129,49 @@ gpu_opp_table: opp-table { > opp-680000000 { > opp-hz = /bits/ 64 <680000000>; > opp-level = ; > + opp-peak-kBps = <16500000>; > }; > > opp-615000000 { > opp-hz = /bits/ 64 <615000000>; > opp-level = ; > + opp-peak-kBps = <16500000>; > }; > > opp-550000000 { > opp-hz = /bits/ 64 <550000000>; > opp-level = ; > + opp-peak-kBps = <12449218>; > }; > > opp-475000000 { > opp-hz = /bits/ 64 <475000000>; > opp-level = ; > + opp-peak-kBps = <8171875>; > }; > > opp-401000000 { > opp-hz = /bits/ 64 <401000000>; > opp-level = ; > + opp-peak-kBps = <6671875>; > }; > > opp-348000000 { > opp-hz = /bits/ 64 <348000000>; > opp-level = ; > + opp-peak-kBps = <6074218>; > }; > > opp-295000000 { > opp-hz = /bits/ 64 <295000000>; > opp-level = ; > + opp-peak-kBps = <6074218>; > }; > > opp-220000000 { > opp-hz = /bits/ 64 <220000000>; > opp-level = ; > + opp-peak-kBps = <6074218>; > }; > }; > }; > > -- > 2.34.1 > -- With best wishes Dmitry