Re: [PATCH] BSD Secure Levels: nits, 2.6.11-rc2-mm1 (6/8)

Chris Wright
2005-02-08T23:44:19Z

* Michael Halcrow (mhalcrow@us.ibm.com) wrote:
> This is the sixth in a series of eight patches to the BSD Secure
> Levels LSM. It makes several trivial changes to make the code
> consistent.

These are inconsistent with CodingStyle. I'd drop this, and go the
other way (patch is smaller) ala Lindent.

> struct seclvl_obj {
> - char *name;
> + char * name;

This is opposite of typical style.

> -seclvl_attr_store(struct kobject *kobj,
> - struct attribute *attr, const char *buf, size_t len)
> +seclvl_attr_store(struct kobject * kobj,
> + struct attribute * attr, const char * buf, size_t len)

same here...etc.

Lindent nearly undoes all these changes. If we're going to reformat
code, I'd prefer to see it done via Lindent.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net