From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BD6C433E5 for ; Mon, 29 Mar 2021 18:31:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3568D61989 for ; Mon, 29 Mar 2021 18:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbhC2Sb0 (ORCPT ); Mon, 29 Mar 2021 14:31:26 -0400 Received: from forward2-smtp.messagingengine.com ([66.111.4.226]:50627 "EHLO forward2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231750AbhC2SbI (ORCPT ); Mon, 29 Mar 2021 14:31:08 -0400 X-Greylist: delayed 448 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Mar 2021 14:31:08 EDT Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id 69AC21940D29; Mon, 29 Mar 2021 14:23:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 29 Mar 2021 14:23:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+jhRBl mzSn44QvKDx4qZJ6h57R67+gDRjs5ayVeerd8=; b=ZxgPDIIiXEncekbQMrrRFr PGtJDQFOmevpqcLFnVIDzgBmnGwvsEtjd8z09H2HZPe4feklM/lp1a9u+MpzA6VE SfNIVu1d7RWnq1+wqnv21zzciyOy3t99z9L0CmQMHfoNY5Pox/9thzPOLX/oWrdW gC3BoJ+sxsDVcOIbFxqckeWrj7Ejl7AjTh6nAURtILHYOslY0epRX55TkUol6t4c jix8Vb47IbA9vD+GJ0b2rG499fcrfz1LPmYvgpSO8CzAaZfXruHrz8w+2a8x9Zg5 pTct2N8vfwBakXVJeNEq93hcc4koScjM17y14dQ41y8MRK2wBahlGTLZ1aaEisrg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehkedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefvufgjfhfhfffkgggtsehttdertddttddtnecuhfhrohhmpeffrghvihgu ucfgughmohhnughsohhnuceouggrvhhiugdrvggumhhonhgushhonhesohhrrggtlhgvrd gtohhmqeenucggtffrrghtthgvrhhnpeehleeffeduiedugedulefgteegteekleevueei teduleehjeekieelkeevueektdenucfkphepkedurddukeejrddviedrvdefkeenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurghvihgurdgv ughmohhnughsohhnsehorhgrtghlvgdrtghomh X-ME-Proxy: Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net [81.187.26.238]) by mail.messagingengine.com (Postfix) with ESMTPA id 8AC001080057; Mon, 29 Mar 2021 14:23:36 -0400 (EDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id b3066ee5; Mon, 29 Mar 2021 18:23:35 +0000 (UTC) To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Joerg Roedel , "H. Peter Anvin" , Paolo Bonzini , kvm@vger.kernel.org, Wanpeng Li , x86@kernel.org, Borislav Petkov , Thomas Gleixner , Sean Christopherson , Jim Mattson , Vitaly Kuznetsov Subject: Re: [PATCH v5 0/5] KVM: x86: dump_vmcs: don't assume GUEST_IA32_EFER, show MSR autoloads/autosaves In-Reply-To: <20210318120841.133123-1-david.edmondson@oracle.com> References: <20210318120841.133123-1-david.edmondson@oracle.com> X-HGTTG: zarquon From: David Edmondson Date: Mon, 29 Mar 2021 19:23:35 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, 2021-03-18 at 12:08:36 GMT, David Edmondson wrote: > v2: > - Don't use vcpu->arch.efer when GUEST_IA32_EFER is not available (Paolo). > - Dump the MSR autoload/autosave lists (Paolo). > > v3: > - Rebase to master. > - Check only the load controls (Sean). > - Always show the PTPRs from the VMCS if they exist (Jim/Sean). > - Dig EFER out of the MSR autoload list if it's there (Paulo). > - Calculate and show the effective EFER if it is not coming from > either the VMCS or the MSR autoload list (Sean). > > v4: > - Ensure that each changeset builds with just the previous set. > > v5: > - Rebase. > - Remove some cruft from changeset comments. > - Add S-by as appropriate. Any further comments or suggestions? Thanks. > David Edmondson (5): > KVM: x86: dump_vmcs should not assume GUEST_IA32_EFER is valid > KVM: x86: dump_vmcs should not conflate EFER and PAT presence in VMCS > KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT > KVM: x86: dump_vmcs should show the effective EFER > KVM: x86: dump_vmcs should include the autoload/autostore MSR lists > > arch/x86/kvm/vmx/vmx.c | 58 +++++++++++++++++++++++++++++------------- > arch/x86/kvm/vmx/vmx.h | 2 +- > 2 files changed, 42 insertions(+), 18 deletions(-) > > -- > 2.30.2 dme. -- Everybody's got something to hide, 'cept me and my monkey.