From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02AA4386C0C for ; Thu, 9 Jul 2026 06:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579938; cv=none; b=kQlmSiEpwrTHv0be816ulSxNwAZPYfJ2TUOS6FAufEMf1qVi9vcOTnVt5LFjCJJI6TXyd4WgbaqnFjUEEx9koVbKPOordjmXTyHTtXMhj/lpJJxnzVx8m7/q2UuWa3y6rSI1rsFUUfdXXF3MckTlRXbWtoPrFXGiPP4e73bS5II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579938; c=relaxed/simple; bh=HALlWa3w52t8+bjBxUmWJNrZ8rBqsI7iQvG0zYBKx8U=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=iJxFUVui0iEzoMaNdPMxCtihVywa4sDnnilabvUE/2Q/AfmLiNgCPOCvC7MIBNnnHQR6JsU7sUGKnYNYu+Buu3R0DsKPWYRtW97vhZXwcyyTetW8e+a2nv7UCbGf57eF+oOoXhPlyb/+RtypQhyDad9DEZg3cfAlRALew8Fl6XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K0Y5EZGj; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K0Y5EZGj" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-384c94c9414so1347018a91.3 for ; Wed, 08 Jul 2026 23:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783579936; x=1784184736; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=kMyL2ueuaueC8L+l/ZwysBuIYsr03c+v5Ak7LkqH33M=; b=K0Y5EZGj2iT5aZP+JSiftBroary6FQ3ndziq6g2WWimdZg+vKO/cvyE6jcjneca8i6 iEmgsxORo7CYoN4nVd++PERRD/MpA+ilUXTVIJXvO7lKjOATpHZVxeoh9Pj6JUKBjdS6 1eY4QMUgi3+SJNeoCiw5b771EjIonYhv9m+lonj6irOAC98DHvRpWPCkL7pQTkFQvN99 38hVyeqwBPJ1YFwIP5WHjl5xAdEGoMf4pgk8zTGlZ4sJnScZmiJG7R8RQvI/u6cb0nlO frTJS8y4eUSt3qk0vAND37ts4E8SqmdeRqsh7iRJ+QXrnqkyAziZjJDMj3+jWWQLRyDV U1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783579936; x=1784184736; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kMyL2ueuaueC8L+l/ZwysBuIYsr03c+v5Ak7LkqH33M=; b=rDJCPPNv4oomR48XDTlsVHS8G+ZtR3xEOTTEN3bogRqadUWA7EssTEhKThPLeWjHYA swf5MPWGiIJ0lUQlTaMispI4pcs3veuHgh1WaBxgc54L2nE/rlQdOYEXJz0JL2MGNPQE grzatRA2JXsGpxqFl6yT6tcOdqs2Gd5742VthS8Z2QneIVa9cslPeVVNws2Sm/A9Asos 3AnGcZxfEUo/6bHfbyiR71KTWtrAXf75nP8nlxsN25XhLCUYK2uC8tjfjkbFjfjoZY9W IEpVs9HmG8biwD7ht/6QslimJiR7qjFdNyn2MsKnwvirUMUhiFKdHryjnLGwAXHRz4sc RJcw== X-Forwarded-Encrypted: i=1; AHgh+RpvQkBGn0qnupsqz0QPgmZGTKg8yQtfdWF5UEGL9z4OX1F+IBvExt9MVV+F8eE6/pLvVnbUBsIR+R2FGCA=@vger.kernel.org X-Gm-Message-State: AOJu0YxDAYwjJR6lfc55DIPjnvDYWh0fG09xKoZAc1E4Ncxwu9lTiae/ eroq5LzdtSp9CpsZgOZS1yVJmZk9o+qU1BaSN5DtVr3yyXMcHzpaq6Wf X-Gm-Gg: AfdE7ckreA0E9uiUINeS44HcDej3YAPFBcyquZ8q9LQ9BSflBWGTcvqEjnfO6PsOfFc MTgQTpQJoSuluYq6Su0yJprRBjRLonss9fCXKpl7Ro8RbrbFFS7lQV5LUdiF4vmi90DSFjunGC7 DnC3Nq+i7UhjX/3UDixZYt+4pRE/FWwS1lJNmTnRdEhNkR3ZhCgsJmAPgx6dNpjjLlcokQvMalY YHZLBDZXs3to74Zxe7V5hmPE+pp1sP2pnHDEbamJ6HOmFsHE+45Cxp/kc/ZbQhl5EYRNHymPUtM 11wa/Kaf4KMtGr2HoBPv5vHso65eEol/eMp5hxBK72R0mBWfd7vRDmj22P+Z2RgAy6raMDx5laD SLd4cY5Um8xlluXWKwoNYwmOyWVd81bDJHtMxeKnmfO6XwOC59S5UzaZ4bK0erqPAv2YNMn8wj3 ANhcRO2RrCxiw= X-Received: by 2002:a05:6a21:3992:b0:3bf:bde7:d679 with SMTP id adf61e73a8af0-3c0bcb7d873mr7374407637.40.1783579936226; Wed, 08 Jul 2026 23:52:16 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b65960d88sm23661245c88.6.2026.07.08.23.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:52:15 -0700 (PDT) From: Ritesh Harjani (IBM) To: Thorsten Blum , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Josh Boyer , Grant Likely , Tony Breeds , Alistair Popple , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: Re: [PATCH 1/3] powerpc/boot: Fix simpleboot CPU node lookup check In-Reply-To: <20260702211554.56923-4-thorsten.blum@linux.dev> Date: Thu, 09 Jul 2026 11:56:30 +0530 Message-ID: References: <20260702211554.56923-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thorsten Blum writes: > fdt_node_offset_by_prop_value() returns a negative error code on > failure - fix the check accordingly. > > Fixes: d2477b5cc8ca ("[POWERPC] bootwrapper: Add a firmware-independent simpleboot target.") > Signed-off-by: Thorsten Blum yup, if it cannot find the node, then it should return a negative error code, since cpu node is never the root node. The same thing was anyway properly done for memory device node in the same function few lines before... /* Find the memory range */ node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type", "memory", sizeof("memory")); if (node < 0) fatal("Cannot find memory node\n"); ...but for cpu node, it uses a wrong comparison check. Looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) > --- > arch/powerpc/boot/simpleboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/simpleboot.c b/arch/powerpc/boot/simpleboot.c > index c80691d83880..27591df41e9e 100644 > --- a/arch/powerpc/boot/simpleboot.c > +++ b/arch/powerpc/boot/simpleboot.c > @@ -68,7 +68,7 @@ void platform_init(unsigned long r3, unsigned long r4, unsigned long r5, > /* finally, setup the timebase */ > node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type", > "cpu", sizeof("cpu")); > - if (!node) > + if (node < 0) > fatal("Cannot find cpu node\n"); > timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size); > if (timebase && (size == 4))