From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7CE03563E1 for ; Sat, 21 Mar 2026 05:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774071108; cv=none; b=eIwN0OmR5xuDtVQ1gFkT3hNH0chldCqJRd6+u/acY/f+xbfCRHH6oFMGoYLSEG7kqgAJ+7XUc5JvFbgE3j/n8yoqvw64DREpGazUNF2V8DZa4v35Dcf7zB1OI27iBON54fVOJGAs1foL/2gYZkMSsbUnmkvpzTjT1wLHp8xR2DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774071108; c=relaxed/simple; bh=abKMir+lamm2r9MN/XOMbOWIQ8gV1sV9mmmdzJ37hII=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=ug3jIqC/KH5McLCd0fxyXI/F8o87GdsBhDw7Mfe1HMAi/H+IKAiJDM+b/gcR4T+cBUVv05AnaiQpkveifqPnQcsGqjCEQEatNxmYRiCz1XjBXUExUCYDX8GyL07+XbI2fKiSJ4RYi5Rl7wbZpD1oUlPrKZLbMTbjDff27Klrp8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XGH8zaZQ; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XGH8zaZQ" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a871daa98fso10377205ad.1 for ; Fri, 20 Mar 2026 22:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774071107; x=1774675907; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=TSrGnm4uwHURRo/Dbgx7AVRGahiZ5mij0ljFmYODkAo=; b=XGH8zaZQrkG8CxSUC0S/lM89XV+r6xihax+TPodNKQ4/H8OknJNAK4sZeZ4rEELerS nYbTdeslhHS4hfpwzbNeSVNpfumWm1ArfIgqt2w45xgbCuqLzpZAVEdHnHp8dbZRj432 rlc2pkSmjTMLdcZ3IO+B5ENhMzDs5KkjML5DZ5KIJxdmcdm/GzK6mnYS5EM0hKzPoSC8 nsrNANIY+exs/Pq5NgIcNq8M1awh8YlsMVjnA2/VCm0UzHWcnXStKbkOyzZUaRKkVdKU Y1KLL6B7OznEnrfK7cfOQoKRSROOycEfWY20NQQiqBsMuNBNGKZD7xKNXHw3pz/HfWBf mAlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774071107; x=1774675907; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TSrGnm4uwHURRo/Dbgx7AVRGahiZ5mij0ljFmYODkAo=; b=XIxMMJh93Dx5x47oP1D8CeTDdNdxI1Y3zabCSXggM90Gs5Xpd8R5q7Tmpc7+L5IDs9 G6kc0OWBEOF5rZEcFmaDIan1PkD88jFvP3TWKwDxKHy1ca3vn7QkV0zm8iLP3eallYMN KOnjznairVTLWb5ybr7Z6Yet9Rsb84n1afHqlk79ls0mfd5aKJNFapr9Tr/aqMY2C6a6 YoRlecz6DQcIrQnF1rxuA1s2VvXCHVFNXrFwohkNbZ+BN11WiR0rGrylbh2CtNz8OXsO cqaiBP2GCErPZJQMiQrI0HDzX5xzMzdtt4GCanxh/on3MEr8q6C057FExBzrfhZL45t0 Wv4Q== X-Forwarded-Encrypted: i=1; AJvYcCX8/zO1esTNpJJ39c+JdwPgLwRy/gXqGnOBkDfeRc4IoAdBSvbRtGN7jrMFlsUxyLIPXRmEC5j0uH2KcYM=@vger.kernel.org X-Gm-Message-State: AOJu0YxuGu58P2LdRct38FO80I4aenFOmLsJ1FNSQXVBQAvxdKKiItAf RGqYxvZT9k4npevLkuh8hlgzJZr9W2k3tSd+q9sRO8EYq6pI8GoQZ/tiWm2MvFUv X-Gm-Gg: ATEYQzytXZMehLyxKfaBfo2Y2f30huY78Eg3zEblQKJg6ExWEfhD9Sg5OcadIx3WS8Z xD0NzZ+DjxLedoOW3fjK/Qq0Syt6gEB9j8cM4ijKj5U8WTViP7wOoQl9nS33dMZIdabDeFkY9vs 1K+mZHYp5Su6rSizcCtae1wNeVJHQcCRQvUSQ0NGUdhWjt69MAHoW1aKA7BY4WJsYvzhzhyT0Dp dOqkGosIdUw0dQg20tU5jihyT64SK03XrkedGy7YSSAzkF6Dxi2pUyhZyJRk9AY6YwYWHYugDRr V64YIuEdN3hMI0J7VyIPjlI42CJOTCS+yJCefoaSzC415Ak8VYFomwiUMfkUbn5oybYQSA1v78n VsYBIGivvenIH9DQeipCc/wUJ4/Sq1q8LNQR9qp4EkTKq9kssupiNZwUQH+1TnU3l7Gef4R3U4F 6wkeDAWNwdA/UuA8dMujA8wg== X-Received: by 2002:a17:903:191:b0:2ae:8272:deb0 with SMTP id d9443c01a7336-2b0826feb3dmr54931105ad.15.1774071106610; Fri, 20 Mar 2026 22:31:46 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083516aa6sm55638395ad.9.2026.03.20.22.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2026 22:31:45 -0700 (PDT) From: Ritesh Harjani (IBM) To: Baolin Wang , akpm@linux-foundation.org, david@kernel.org Cc: ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, baolin.wang@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, open , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] mm: change to return bool for pudp_test_and_clear_young() In-Reply-To: <2711ec4bf6c30182004e34027fb31a2e8e24749e.1773890510.git.baolin.wang@linux.alibaba.com> Date: Sat, 21 Mar 2026 11:00:45 +0530 Message-ID: References: <2711ec4bf6c30182004e34027fb31a2e8e24749e.1773890510.git.baolin.wang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Baolin Wang writes: > The pudp_test_and_clear_young() is used to clear the young flag, > returning whether the young flag was set for this PUD entry. Change > the return type to bool to make the intention clearer. > > Signed-off-by: Baolin Wang > --- > arch/powerpc/include/asm/book3s/64/pgtable.h | 10 +++++----- > arch/powerpc/mm/book3s64/pgtable.c | 4 ++-- > arch/riscv/include/asm/pgtable.h | 4 ++-- > arch/x86/include/asm/pgtable.h | 4 ++-- > arch/x86/mm/pgtable.c | 6 +++--- > 5 files changed, 14 insertions(+), 14 deletions(-) > LGTM. Please feel free to add: (assuming you will anyway kill the unwanted externs) Reviewed-by: Ritesh Harjani (IBM)