From: Xi Ruoyao <xry111@xry111.site>
To: George Guo <dongtai.guo@linux.dev>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
hengqi.chen@gmail.com
Cc: r@hev.cc, loongarch@lists.linux.dev,
linux-kernel@vger.kernel.org, George Guo <guodongtai@kylinos.cn>,
Yangyang Lian <lianyangyang@kylinos.cn>
Subject: Re: [PATCH v5 1/4] LoongArch: Add SCQ support detection
Date: Fri, 12 Dec 2025 12:12:41 +0800 [thread overview]
Message-ID: <d00b641b2b85d5ca8dfd5c52d2a82d456b8a03fe.camel@xry111.site> (raw)
In-Reply-To: <20251212-2-v5-1-704b3af55f7d@linux.dev>
On Fri, 2025-12-12 at 11:55 +0800, George Guo wrote:
> diff --git a/arch/loongarch/kernel/cpu-probe.c b/arch/loongarch/kernel/cpu-probe.c
> index a2060a24b39fd78fa255816fa5518e0ee99b8a8e..47815a55b7b48bbffd4954a9b8bdf7021d7e234d 100644
> --- a/arch/loongarch/kernel/cpu-probe.c
> +++ b/arch/loongarch/kernel/cpu-probe.c
> @@ -201,6 +201,10 @@ static void cpu_probe_common(struct cpuinfo_loongarch *c)
> c->options |= LOONGARCH_CPU_PTW;
> elf_hwcap |= HWCAP_LOONGARCH_PTW;
> }
> + if (config & CPUCFG2_SCQ)
> + c->options |= LOONGARCH_CPU_SCQ;
> + else
> + pr_warn_once("CPU does NOT support SCQ\n");
IMO this should be a pr_info_once. CPU lacks SCQ is not anything wrong
thus this shouldn't be a warning.
> if (config & CPUCFG2_LSPW) {
> c->options |= LOONGARCH_CPU_LSPW;
> elf_hwcap |= HWCAP_LOONGARCH_LSPW;
--
Xi Ruoyao <xry111@xry111.site>
next prev parent reply other threads:[~2025-12-12 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 3:55 [PATCH v5 0/4] LoongArch: Add 128-bit atomic cmpxchg support (v5) George Guo
2025-12-12 3:55 ` [PATCH v5 1/4] LoongArch: Add SCQ support detection George Guo
2025-12-12 4:12 ` Xi Ruoyao [this message]
2025-12-12 4:47 ` Huacai Chen
2025-12-12 3:55 ` [PATCH v5 2/4] LoongArch: Add 128-bit atomic cmpxchg support George Guo
2025-12-12 3:55 ` [PATCH v5 3/4] LoongArch: Use spinlock to emulate 128-bit cmpxchg George Guo
2025-12-12 3:55 ` [PATCH v5 4/4] LoongArch: Enable 128-bit atomics cmpxchg support George Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00b641b2b85d5ca8dfd5c52d2a82d456b8a03fe.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenhuacai@kernel.org \
--cc=dongtai.guo@linux.dev \
--cc=guodongtai@kylinos.cn \
--cc=hengqi.chen@gmail.com \
--cc=kernel@xen0n.name \
--cc=lianyangyang@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=r@hev.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox