From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C39F13D601 for ; Fri, 12 Jul 2024 07:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720770006; cv=none; b=GnIY+GEFcBGifhgsFcHfUDBAYgtfArrVMOJq1+iLUbmkBLyvB3T2EPRSEUDXDX4J6Gfzt+FR4YgfAEWdg2442OacZCo6SmwCwvnSkEDH++VgGNVpmcplcYITKgRFjvNdGVmU4e24aHeDqrooFRNf8YJT5vKrhMoDgcZxLJN+/WI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720770006; c=relaxed/simple; bh=GtGQloxfK5LgILQY13R+z3F8Sj57kv7kh5oCjohfRzw=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=bwCUJ2tdqFGNwyl94PD44HlgrH1zEwvAfMQJ6iqlmtypTUN4EvcNK3r0icTdYxaQ2jfzBiBtZ3EWQQ/mw3pDd99xET+cOqGJIjWi/BRCxmlGBU5AS/yCSKECt1YiweLixRxVCq46pJ+hKbSgirwehBhX8AiW1yTec6BPbgU23fI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TQEqG4xG; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TQEqG4xG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720770004; x=1752306004; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=GtGQloxfK5LgILQY13R+z3F8Sj57kv7kh5oCjohfRzw=; b=TQEqG4xG8O6WTiNTZI5JR+TRXerIGbpL/ypIy+1BaziuJwgbshQMh/J0 /SxVN7eZCZctZM1Pn3JXMDWUb73PtcaVPxAWGsACeOZjF+i2KH5mHbkPa ZH77yXovxWCY78anl6DSTJBMWyMrOeMV4WtBrJ8QwkNXJ/Qxhwgc32Xiy 8q9CpOO/EeftqyOG+qath9JfZCEqY0TAy8324ZRZPE51Hd2i+gNt9oapa 8X2co2r9l566v+THmjcau6xTuAxCnw9oEskWKP+x12QZfWBcKsjWy8j1D PCgIMbt0wrec7mV1lcZMt3KKELyQQJ2M9b7aCmP7POPF5gMA8kbf29N9T w==; X-CSE-ConnectionGUID: 6Hct1tWKQGWEGxxcVg319Q== X-CSE-MsgGUID: M19y6XpWRXiQuPXPHed8HQ== X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="22069019" X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="22069019" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 00:40:04 -0700 X-CSE-ConnectionGUID: Mu7QuJ7UT7a74nw0opFkJA== X-CSE-MsgGUID: aPR4Fm0LRNK17V46R3LpBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="48746370" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.125.248.220]) ([10.125.248.220]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 00:40:00 -0700 Message-ID: Date: Fri, 12 Jul 2024 15:39:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, David Woodhouse , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , "H. Peter Anvin" , Tejun Heo , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Sudheer Dantuluri , Gary Zibrat Subject: Re: [PATCH] iommu/vt-d: Fix identity map bounds in si_domain_init() To: Jon Pan-Doh References: <20240709234913.2749386-1-pandoh@google.com> Content-Language: en-US From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/7/12 15:05, Jon Pan-Doh wrote: > On Tue, Jul 9, 2024 at 7:45 PM Baolu Lu wrote: >> Do you mind telling me on which platform did you test this fix? My >> understanding is that modern VT-d hardware supports hardware pass >> through mode, hence this piece of code won't be executed anymore. > We tested it in a VM using an emulated vIOMMU setup. Hope that helps. Okay, that's fine then. If you send a new version, you can take my Reviewed-by: Lu Baolu Thanks, baolu