From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932461AbdBISQF (ORCPT ); Thu, 9 Feb 2017 13:16:05 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:36103 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbdBISPE (ORCPT ); Thu, 9 Feb 2017 13:15:04 -0500 Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency To: Andrew Lunn , Arnd Bergmann References: <20170209150834.1158193-1-arnd@arndb.de> <20170209155751.GB29882@lunn.ch> <1967873.WpTcGj2Cy4@wuerfel> <20170209172024.GE29882@lunn.ch> Cc: linux-arm-kernel@lists.infradead.org, "David S . Miller" , netdev@vger.kernel.org, Jason Cooper , Sebastian Hesselbarth , Gregory Clement , Russell King , linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: Date: Thu, 9 Feb 2017 10:14:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170209172024.GE29882@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2017 09:20 AM, Andrew Lunn wrote: >> Adding a 'select' statement to something as broad as NETDEVICES sounds >> really bad, it has a significant risk of introducing dependency loops >> and may be confusing if you want to build a multiplatform config without >> networking support (note that NETDEVICES in turn depends on NET, which >> can also be disabled). > > O.K, so overall it is not simple. So lets drop my idea. > >> One possibility would be to have a special Kconfig symbol that controls >> mdiobus_register_board_info() being present and have that symbol >> force PHYLIB to never be "=m". Then we can either have no networking >> support and no phylib, turning mdiobus_register_board_info() into a >> stub, or we have the function built-in and reachable from the board >> code. > > FYI: Florian is working on splitting MDIO out of PHYLIB. There will be > two separate symbols, so it will be possible to have MDIO without > PHYLIB. When this happens, i expect mdiobus_register_board_info() will > be in the MDIO part, not PHYLIB. Yes that would be the plan. -- Florian