From: Andrea Collamati <andrea.collamati@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml
Date: Fri, 21 Jul 2023 13:58:38 +0200 [thread overview]
Message-ID: <d010f085-ea0e-5086-260e-c5a9be94ebfb@gmail.com> (raw)
In-Reply-To: <4898bc33-5245-8fb2-e5e6-8ea1a8f32e1e@linaro.org>
Hi Krzysztof,
On 7/21/23 10:21, Krzysztof Kozlowski wrote:
>> Add documentation for MCP4728
>>
>> Signed-off-by: Andrea Collamati <andrea.collamati@gmail.com>
>> ---
>> .../bindings/iio/dac/microchip,mcp4728.yaml | 48 +++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>> new file mode 100644
>> index 000000000000..6fd9be076245
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip MCP4728 DAC
>> +
>> +description:
>> + MCP4728 is a quad channel, 12-bit voltage output
>> + Digital-to-Analog Converter with non-volatile
>> + memory and I2C compatible Serial Interface.
>> + https://www.microchip.com/en-us/product/mcp4728
>> +
>> +maintainers:
>> + - Andrea Collamati <andrea.collamati@gmail.com>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - microchip,mcp4728
> This is a friendly reminder during the review process.
Sorry but I didn't understand all your requests:
- I changed in the title mcp4728 with MCP4728
- I added description
but I don't know which blank line or whitespaces should be removed.
Can you tell me please?
next prev parent reply other threads:[~2023-07-21 11:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:40 [PATCH v3 0/2] add MCP4728 I2C DAC driver Andrea Collamati
2023-07-20 15:40 ` [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml Andrea Collamati
2023-07-20 17:01 ` Conor Dooley
2023-07-23 4:59 ` Andrea Collamati
2023-07-21 8:21 ` Krzysztof Kozlowski
2023-07-21 8:22 ` Krzysztof Kozlowski
2023-07-21 12:02 ` Andrea Collamati
2023-07-21 11:58 ` Andrea Collamati [this message]
2023-07-21 12:07 ` Krzysztof Kozlowski
2023-07-20 15:40 ` [PATCH v3 2/2] iio: add MCP4728 I2C DAC driver Andrea Collamati
2023-07-20 19:13 ` Jonathan Cameron
2023-07-21 19:47 ` Andrea Collamati
2023-07-23 11:34 ` Jonathan Cameron
2023-07-23 5:09 ` Andrea Collamati
2023-07-23 11:41 ` Jonathan Cameron
2023-07-23 12:15 ` Andrea Collamati
2023-07-23 12:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d010f085-ea0e-5086-260e-c5a9be94ebfb@gmail.com \
--to=andrea.collamati@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox