From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEB5923645D for ; Wed, 26 Aug 2026 10:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787739214; cv=none; b=cNCJbgR00vuLlmRW+dZGOvgs0S3Obac0mNSuqCVzuc9tviCZGrLQRQXCBJU9ggQourDE6F+ZgVkcBvfEPHzHkxv+mtqmm8stqxu6CbpTxOuXwtFJkRfjRRHmqrEM84re6Wd2WTv8hFTlynnju60BOPV19H4iYUEX0RBMySN3OYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787739214; c=relaxed/simple; bh=KIZQegHnKMBMCN5KurBHB75g+b3yGfCCWsKSLBYpYY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bD7k/X9lgW+Ub+Pgps9GQHgjyacHxYF0uwdkwiabFoD4Wyz5Hlu7abTMU8jTpL3+IVw+EnsWmspbgFCs692CDQzS8Yz1+5VDA9MtutvV2neJdRphJVMWTcd9uxmsDzMuk9o23HmH58nrI3nFUxv2YRzhEfAv0BIxXkcTEJ1mrOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oFoMEfi8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aO18oYAK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oFoMEfi8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aO18oYAK" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67Q9CfVl500906 for ; Wed, 26 Aug 2026 10:13:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=oFoMEfi8ydvPgb/Q ioRIl9UCE2Svdffnd0Tg0p/gufbbq0xgocIs0qK5aWaAyAIJUwscOKjw/i3F74bo CBz9bnjwHQKBKlXkxSKm3woKgReR/zTiza/vdfEx0b7ir6pR9Ttqx49Zho5GsOIY 7TE/ArlrjxA3RbKx6WipaMnWzmRY2hICdkJT+SYnn2sSUh56Os+78JOLjCCiFslm C8zqWEJAGIZgztDcoERIqFbIKCZeNXqWgqnCWGJJB58KaEORqU153u0M/UUpc+Nk tKql6CPhu/5NWPRCTlcOSpxKG12c+34dELEm+Qb3IeP9MuAk0+Rp20sA6RUtn1UI yhzH/g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9g4mu55m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 10:13:31 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52d9cef8d15so14985461cf.0 for ; Wed, 26 Aug 2026 03:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787739211; x=1788344011; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=aO18oYAKyG/LL4/TEFo7NMjPR3OZ8kQPQf6SHq6ASJM2HX++sWul2jpfZUv9vY5Ycp 3VHZWIdQ+CZvVOUMraWxOPUeL7xnOHxlTolRde75YlKKpDFTL9sChSZGVk36MOKvDR1f 2lcEv4nb+A2XjCTl70M2XANRO5eZjNqIboYgphm1xgZJM+4oJ9p/PLwHdmN2WjFuF/Hv +N7jOC1pNyH+dvDlcxDHo/b1y8LPDhlDXSRSaqCeiAXpnTVgCbcQopwhgcfFEQoCtR2i DTuAOswNdXuc5pEqHSFgzPn3UoQcAGGaWr3EFpREakJK6TC8Yf0VhKpjjwFTz9vbu+f8 EDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787739211; x=1788344011; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MpszJFaxfFemeV0/SZwFeF4b5jqGx1fNaw5whlTiIlQ=; b=nYujOKsFhf5gLrJJNhhivNsXBT0a3fUvmsgOSsIYER0AF4qZXlXWTLI7/IoYMDnCwo tRZH/OyB0Al1KD5lIWffA84bhAVcGPVR5NFgIaOF9iAQL/OMdLwXKjLmv6qkz4awtESi YlxuEoXWPb4ni29BqPma/dgwA6zz1W61N+KCTYYZGI5pJbtB3AXgNHBqOFQge7cXM5MR uXQAXXGDWPJyZFeNLYDkhMDYsunXMPIGfoXMdU9n2tvoEQqAwubZGNE7Ej35X+qZb8hT wwXFNmnKINAndjTbN8IHx+mmo/6WXJKpqyQO9vqDE9gELp6Pc/ZEBzGiXeCj6PKaYs6u vYdQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8ODIExsrHwE6jKMW4yXmyxJfIqlrCdIUkh7Ks62uxKWKveqYDrgEfaOM3PF86mZ5cJgmeguTiV9DNdQM=@vger.kernel.org X-Gm-Message-State: AFuF++nEvLOqVHjjc8TA4j4MzHGXaFUIQpBQA6y14dGpcrUoi+zzzbWh HZ/n7sjZ3ngY6yGB26ssXV9Nux1VzOkkCiKRR4BbYi56qlWki38nr48veikRFkQlE7Bx/p+g2iY WLlQIDdhCyPt91vVvJjjJKwVTnauWuZbYvjLV64rSIlf2JOh1jvZQF746weQnGd0Phfg= X-Gm-Gg: AR+sD13eStjXCBkeXcv5UNutwj9zttfvQJlyK18dvJKWMFL6i2o5Vi4twMy5aGdely3 mM6zVRXZc7ozYe1AqsbVVi/TvZHInN9LMeQOJZDJQ6LESXLFqNtWQp6kHjh1f+BTHICvf4hsuEG Qf+d0asjqNfu9WAIpNzP1rTKpRsyHnkDXsxOrTmKkqQfNA67z6PR89Tx5TRV5ObvUIkFuVlAYpY 2cgps3LEBKi5V+oorJYyFLUoZYosW9XGFwHmo20shNn6lnJ1RDvM+eVWTJg7Dct32QX6ld9smYM 3ohj0H+Na5SH7pOzgUxmStxqCRK157FqU6fT/Rz92OtqMwQ0FZHyjAA1WmiySS2PuIxB0lADXpN Rf1xIrxAlF7cU6WHEtY7KcsH5APQ= X-Received: by 2002:a05:622a:8c8:b0:51c:1c73:5945 with SMTP id d75a77b69052e-52e42320622mr58939951cf.24.1787739211114; Wed, 26 Aug 2026 03:13:31 -0700 (PDT) X-Received: by 2002:a05:622a:8c8:b0:51c:1c73:5945 with SMTP id d75a77b69052e-52e42320622mr58934941cf.24.1787739205944; Wed, 26 Aug 2026 03:13:25 -0700 (PDT) Received: from [192.168.68.107] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-482e28dc13fsm2201496f8f.24.2026.08.26.03.13.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 03:13:25 -0700 (PDT) Message-ID: Date: Wed, 26 Aug 2026 11:13:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/9] ASoC: qcom: Add Shikra QAIF support To: Harendra Gautam , Mohammad Rafi Shaik Cc: Srinivas Kandagatla , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prasad Kumpatla , Krzysztof Kozlowski , Sarath Ganapathiraju , Kumar Anurag Singh References: <20260824063627.3595610-1-harendra.gautam@oss.qualcomm.com> <20260824063627.3595610-9-harendra.gautam@oss.qualcomm.com> <9c1dddb8-5f1b-4b7c-b810-64cbd6f7ccac@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA4NCBTYWx0ZWRfX69mGDKARyES7 j+4we6WtMJ9nGvJ2IF09cEmWkQaYDdqkR/2j7bNOaepp0g25atRz4ucU7AjKk4h8ng6J6P/SunQ TS4NF6GDJO0Tvx484IZ2PrTKUZ4bk3I= X-Proofpoint-ORIG-GUID: PTWrRVmdo-ejEk6d__NKaHgzJ1_Od8VX X-Authority-Analysis: v=2.4 cv=eYgNubEH c=1 sm=1 tr=0 ts=6a8ebc4b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=DqJvd4i33UI3nbR7U2UA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA4NCBTYWx0ZWRfX0Dva+FA36Xh/ hBL4h6PNm4WzPA7AFkNbf9okyt7EzprcuqZSMhEHFd4Q7XLNGTABCGvucPX3z5erubB0Gmte3sa 7KutKhNJMAELJhi/TV04aFk56l7gmvOjDg1rfVdfZaCVdeaYO+YbRa1BJSLzSZIvizxY1x9mbT7 thHlpI7ns/waicAxUpQ7lcdmb2aZLSAxmK59KDWuZbdX58WV46FEXVEPFlMsiYFShX0y4ClB8AC stf+sS56LXGhN8dQcZkvxs4/g6KwcPpV5VKlDCE1wdSRr0LHCDZ32hk6oHiU83UIitMKS26E49d w28SDm/RVMvPj//WRbbF2xynJeND+F88F6WtxnPSauDWE9MrhAcL5m+sspwspvY2kgZCUAP3K0s T6cD4uRh/PkKDI4P43QsWjv98G/k8qT4oBYiG60q6CEW9Kl/UN6LRblg3h67uHT6zumQzVj5xMp J8CXWmiwVQBUPwi3YIA== X-Proofpoint-GUID: PTWrRVmdo-ejEk6d__NKaHgzJ1_Od8VX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_02,2026-08-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260084 On 8/26/26 9:58 AM, Harendra Gautam wrote: >>> + .id = QAIF_CDC_DMA_RX0, >>> + .name = "CDC DMA RX0", >>> + .playback = { >>> + .stream_name = "WCD Playback0", >>> + .formats = SNDRV_PCM_FMTBIT_S16, >>> + .rates = SNDRV_PCM_RATE_48000, >>> + .rate_min = 48000, >>> + .rate_max = 48000, >>> + .channels_min = 1, >>> + .channels_max = 2, >>> + }, >>> + .ops = &asoc_qcom_qaif_cif_dai_ops, >>> + }, { >>> + .id = QAIF_CDC_DMA_RX1, >>> + .name = "CDC DMA RX1", >>> + .playback = { >>> + .stream_name = "WCD Playback1", >> No dai for WCD capture (or) it's missing in this patch. >> >> >> Best Regards, >> Rafi. >> > On Shikra, capture is always through the VA Macro, irrespective of > whether the source is WCD AMIC or MSM DMIC and the stream_name is only > a descriptive identifier. WCD naming is totally incorrect w.r.t this driver, WCD is external codec, which can be connected to any dai. QAIF just exposes FE dais It should not have any codec level information either as names or any other. Pl remove and use the correct naming which reflect the dai name w.r.t to QAIF. --srini > -Harendra