Re: [PATCH v7 00/10] Add support for RK3588 DisplayPort Controller

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 28.08.25 um 00:24 schrieb Dmitry Baryshkov:
> On Fri, Aug 22, 2025 at 02:39:44PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>>
>> There are two DW DPTX based DisplayPort Controller on rk3588 which
>> are compliant with the DisplayPort Specification Version 1.4 with
>> the following features:
>>
>> * DisplayPort 1.4a
>> * Main Link: 1/2/4 lanes
>> * Main Link Support 1.62Gbps, 2.7Gbps, 5.4Gbps and 8.1Gbps
>> * AUX channel 1Mbps
>> * Single Stream Transport(SST)
>> * Multistream Transport (MST)
>> * Type-C support (alternate mode)
>> * HDCP 2.2, HDCP 1.3
>> * Supports up to 8/10 bits per color component
>> * Supports RBG, YCbCr4:4:4, YCbCr4:2:2, YCbCr4:2:0
>> * Pixel clock up to 594MHz
>> * I2S, SPDIF audio interface
>>
>> The current version of this patch series only supports basic display outputs.
>> I conducted tests with DP0 in 1080p and 4K@60 YCbCr4:2:0 modes; the ALT/Type-C
>> mode was tested on Rock 5B, DP1 was tested on Rock 5 ITX by Stephen and Piotr.
>> HDCP and audio features remain unimplemented.
>> For RK3588, it's only support SST, while in the upcoming RK3576, it can support
>> MST output.
>>
> [skipped changelog]
>
>> Andy Yan (10):
>>    dt-bindings: display: rockchip: Add schema for RK3588 DPTX Controller
>>    drm/bridge: synopsys: Add DW DPTX Controller support library
>>    drm/rockchip: Add RK3588 DPTX output support
>>    MAINTAINERS: Add entry for DW DPTX Controller bridge
> I tried pushing patches 1-4, but got the following error:
>
> dim: ERROR: 5a68dcf5837a ("MAINTAINERS: Add entry for DW DPTX Controller bridge"): Mandatory Maintainer Acked-by missing., aborting
>
> I'm not sure how to handle MAINTAINERS changes (or whether it's fine for
> me or not), so I will probably push patches 1-3 in a few days, if nobody
> beats me (or unless somebody points out a correct process for
> MAINTAINERS changes).

That warning has been added recently to make sure that patches do not 
get in without sufficient review. It's overly pedantic, though. If 
you're confident that you have R-bs from enough relevant people, push 
the patches with 'dim -f' to ignore the warning.

Best regards
Thomas

>
>>    dt-bindings: display: simple-bridge: Add ra620 compatible
>>    drm/bridge: simple-bridge: Add support for radxa ra620
>>    arm64: dts: rockchip: Add DP0 for rk3588
>>    arm64: dts: rockchip: Add DP1 for rk3588
>>    arm64: dts: rockchip: Enable DisplayPort for rk3588s Cool Pi 4B
>>    arm64: dts: rockchip: Enable DP2HDMI for ROCK 5 ITX
>>
>>   .../display/bridge/simple-bridge.yaml         |    1 +
>>   .../display/rockchip/rockchip,dw-dp.yaml      |  150 ++
>>   MAINTAINERS                                   |    8 +
>>   arch/arm64/boot/dts/rockchip/rk3588-base.dtsi |   30 +
>>   .../arm64/boot/dts/rockchip/rk3588-extra.dtsi |   30 +
>>   .../boot/dts/rockchip/rk3588-rock-5-itx.dts   |   59 +
>>   .../boot/dts/rockchip/rk3588s-coolpi-4b.dts   |   37 +
>>   drivers/gpu/drm/bridge/simple-bridge.c        |    5 +
>>   drivers/gpu/drm/bridge/synopsys/Kconfig       |    7 +
>>   drivers/gpu/drm/bridge/synopsys/Makefile      |    1 +
>>   drivers/gpu/drm/bridge/synopsys/dw-dp.c       | 2095 +++++++++++++++++
>>   drivers/gpu/drm/rockchip/Kconfig              |    9 +
>>   drivers/gpu/drm/rockchip/Makefile             |    1 +
>>   drivers/gpu/drm/rockchip/dw_dp-rockchip.c     |  150 ++
>>   drivers/gpu/drm/rockchip/rockchip_drm_drv.c   |    1 +
>>   drivers/gpu/drm/rockchip/rockchip_drm_drv.h   |    1 +
>>   include/drm/bridge/dw_dp.h                    |   20 +
>>   17 files changed, 2605 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
>>   create mode 100644 drivers/gpu/drm/bridge/synopsys/dw-dp.c
>>   create mode 100644 drivers/gpu/drm/rockchip/dw_dp-rockchip.c
>>   create mode 100644 include/drm/bridge/dw_dp.h
>>
>> -- 
>> 2.43.0
>>
>> base-commit: 18b8261b84ad5462d7261617fbfa49d85d396fd9
>> branch: rk3588-dp-upstream-v7
>>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)