* [PATCH] pinctrl: zynq: add CONFIG_OF dependency
@ 2025-06-20 13:07 Arnd Bergmann
2025-06-20 13:36 ` Bartosz Golaszewski
2025-06-24 19:23 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2025-06-20 13:07 UTC (permalink / raw)
To: Linus Walleij, Krzysztof Kozlowski
Cc: Sai Krishna Potthuri, Arnd Bergmann, Geert Uytterhoeven,
Bartosz Golaszewski, Pratap Nirujogi, linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The zynq driver can be enabled for compile-testing on builds without
CONFIG_OF, leading to a link error:
ld.lld-21: error: undefined symbol: pinconf_generic_dt_node_to_map
referenced by pinconf-generic.h:231 (/home/arnd/arm-soc/include/linux/pinctrl/pinconf-generic.h:231)
drivers/pinctrl/pinctrl-zynq.o:(pinconf_generic_dt_node_to_map_all) in archive vmlinux.a
Prevent this with the proper compile time dependency.
Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 753692e9ecf5..ddd11668457c 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -603,6 +603,7 @@ config PINCTRL_TH1520
config PINCTRL_ZYNQ
bool "Pinctrl driver for Xilinx Zynq"
depends on ARCH_ZYNQ || COMPILE_TEST
+ depends on OF
select PINMUX
select GENERIC_PINCONF
help
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency
2025-06-20 13:07 [PATCH] pinctrl: zynq: add CONFIG_OF dependency Arnd Bergmann
@ 2025-06-20 13:36 ` Bartosz Golaszewski
2025-06-20 13:45 ` Arnd Bergmann
2025-06-24 19:23 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2025-06-20 13:36 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Krzysztof Kozlowski, Sai Krishna Potthuri,
Arnd Bergmann, Geert Uytterhoeven, Bartosz Golaszewski,
Pratap Nirujogi, linux-gpio, linux-kernel
On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The zynq driver can be enabled for compile-testing on builds without
> CONFIG_OF, leading to a link error:
>
> ld.lld-21: error: undefined symbol: pinconf_generic_dt_node_to_map
> referenced by pinconf-generic.h:231 (/home/arnd/arm-soc/include/linux/pinctrl/pinconf-generic.h:231)
> drivers/pinctrl/pinctrl-zynq.o:(pinconf_generic_dt_node_to_map_all) in archive vmlinux.a
>
> Prevent this with the proper compile time dependency.
>
> Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 753692e9ecf5..ddd11668457c 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
> config PINCTRL_ZYNQ
> bool "Pinctrl driver for Xilinx Zynq"
> depends on ARCH_ZYNQ || COMPILE_TEST
> + depends on OF
> select PINMUX
> select GENERIC_PINCONF
> help
> --
> 2.39.5
>
>
I don't think this is the actual problem. I can build (and link)
pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
entire offending .config somewhere?
Bartosz
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency
2025-06-20 13:36 ` Bartosz Golaszewski
@ 2025-06-20 13:45 ` Arnd Bergmann
2025-06-20 14:38 ` Bartosz Golaszewski
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2025-06-20 13:45 UTC (permalink / raw)
To: Bartosz Golaszewski, Arnd Bergmann
Cc: Linus Walleij, Krzysztof Kozlowski, Sai Krishna Potthuri,
Geert Uytterhoeven, Bartosz Golaszewski, Pratap Nirujogi,
open list:GPIO SUBSYSTEM, linux-kernel
On Fri, Jun 20, 2025, at 15:36, Bartosz Golaszewski wrote:
> On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@kernel.org> wrote:
>> --- a/drivers/pinctrl/Kconfig
>> +++ b/drivers/pinctrl/Kconfig
>> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
>> config PINCTRL_ZYNQ
>> bool "Pinctrl driver for Xilinx Zynq"
>> depends on ARCH_ZYNQ || COMPILE_TEST
>> + depends on OF
>> select PINMUX
>
> I don't think this is the actual problem. I can build (and link)
> pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
> entire offending .config somewhere?
This is from a randconfig build: https://pastebin.com/ism57RPe
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency
2025-06-20 13:45 ` Arnd Bergmann
@ 2025-06-20 14:38 ` Bartosz Golaszewski
0 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2025-06-20 14:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Arnd Bergmann, Linus Walleij, Krzysztof Kozlowski,
Sai Krishna Potthuri, Geert Uytterhoeven, Bartosz Golaszewski,
Pratap Nirujogi, open list:GPIO SUBSYSTEM, linux-kernel
On Fri, Jun 20, 2025 at 3:46 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Fri, Jun 20, 2025, at 15:36, Bartosz Golaszewski wrote:
> > On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> >> --- a/drivers/pinctrl/Kconfig
> >> +++ b/drivers/pinctrl/Kconfig
> >> @@ -603,6 +603,7 @@ config PINCTRL_TH1520
> >> config PINCTRL_ZYNQ
> >> bool "Pinctrl driver for Xilinx Zynq"
> >> depends on ARCH_ZYNQ || COMPILE_TEST
> >> + depends on OF
> >> select PINMUX
>
> >
> > I don't think this is the actual problem. I can build (and link)
> > pinctrl-zynq with COMPILE_OF disabled alright. Can you paste the
> > entire offending .config somewhere?
>
> This is from a randconfig build: https://pastebin.com/ism57RPe
>
> Arnd
Right. I don't have the time to look into untangling it but in general
all OF interfaces have relevant stubs so `depends on OF` should not be
needed. But it's more complex here in pinctrl so I'm fine with this
for now.
Bartosz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: zynq: add CONFIG_OF dependency
2025-06-20 13:07 [PATCH] pinctrl: zynq: add CONFIG_OF dependency Arnd Bergmann
2025-06-20 13:36 ` Bartosz Golaszewski
@ 2025-06-24 19:23 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2025-06-24 19:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Krzysztof Kozlowski, Sai Krishna Potthuri, Arnd Bergmann,
Geert Uytterhoeven, Bartosz Golaszewski, Pratap Nirujogi,
linux-gpio, linux-kernel
On Fri, Jun 20, 2025 at 3:08 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The zynq driver can be enabled for compile-testing on builds without
> CONFIG_OF, leading to a link error:
>
> ld.lld-21: error: undefined symbol: pinconf_generic_dt_node_to_map
> referenced by pinconf-generic.h:231 (/home/arnd/arm-soc/include/linux/pinctrl/pinconf-generic.h:231)
> drivers/pinctrl/pinctrl-zynq.o:(pinconf_generic_dt_node_to_map_all) in archive vmlinux.a
>
> Prevent this with the proper compile time dependency.
>
> Fixes: 1982621decaf ("pinctrl: Allow compile testing for K210, TB10X and ZYNQ")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-24 19:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-20 13:07 [PATCH] pinctrl: zynq: add CONFIG_OF dependency Arnd Bergmann
2025-06-20 13:36 ` Bartosz Golaszewski
2025-06-20 13:45 ` Arnd Bergmann
2025-06-20 14:38 ` Bartosz Golaszewski
2025-06-24 19:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).