The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	linux-kernel@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Kees Cook" <kees@kernel.org>,
	"Stepan Ionichev" <sozdayvek@gmail.com>,
	"Xin Zhao" <jackzxcui1989@163.com>,
	"Osama Abdelkader" <osama.abdelkader@gmail.com>,
	"Fushuai Wang" <wangfushuai@baidu.com>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	linux-serial@vger.kernel.org,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH tty v11 1/2] serial: 8250: Switch to nbcon console, take 2
Date: Tue, 25 Aug 2026 16:35:15 +0100	[thread overview]
Message-ID: <d058012e-2be7-4e70-9c10-5e4c00a23b05@nvidia.com> (raw)
In-Reply-To: <877ble714e.fsf@jogness.linutronix.de>

Hi John,

On 25/08/2026 14:58, John Ogness wrote:
> Hi Jon,
> 
> On 2026-08-24, Jon Hunter <jonathanh@nvidia.com> wrote:
>> With this I see a little more output on the console, but it still
>> appears to hang later and never fully boots.
>>
>> Boot log here: https://pastebin.com/Xe1vmeUj
> 
> Thanks, this information is helpful. Below is another hack, to be used
> on the unmodified linux-next. For whatever reason, I think the queuing
> of irqwork is causing problems. Perhaps the irqwork is actually firing
> even though interrupts are supposed to be disabled here.
> 
> The following hack will disable the queuing during the cpuidle. Please
> give this a try:
> 
> ===== BEGIN CPUIDLE HACK =====
> diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
> index aca907a62bb5d..1dca9d6defbff 100644
> --- a/drivers/cpuidle/cpuidle-tegra.c
> +++ b/drivers/cpuidle/cpuidle-tegra.c
> @@ -226,6 +226,7 @@ static int tegra_cpuidle_adjust_state_index(int index, unsigned int cpu)
>   	return index;
>   }
>   
> +extern bool console_irqwork_blocked;
>   static __cpuidle int tegra_cpuidle_enter(struct cpuidle_device *dev,
>   					 struct cpuidle_driver *drv,
>   					 int index)
> @@ -238,6 +239,8 @@ static __cpuidle int tegra_cpuidle_enter(struct cpuidle_device *dev,
>   	if (dev->states_usage[index].disable)
>   		return -1;
>   
> +	console_irqwork_blocked = true;
> +
>   	if (index == TEGRA_C1) {
>   		if (do_rcu)
>   			ct_cpuidle_enter();
> @@ -256,6 +259,8 @@ static __cpuidle int tegra_cpuidle_enter(struct cpuidle_device *dev,
>   		index = ret;
>   	}
>   
> +	console_irqwork_blocked = false;
> +
>   	return index;
>   }
> ===== END CPUIDLE HACK =====
Yes that does boot. Let me know if there are any further tests I can run.

Thanks!
Jon

-- 
nvpublic


  reply	other threads:[~2026-08-25 15:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 12:04 [PATCH tty v11 0/2] Convert 8250 to NBCON, take 2 John Ogness
2026-07-29 12:04 ` [PATCH tty v11 1/2] serial: 8250: Switch to nbcon console, " John Ogness
2026-07-29 12:44   ` John Ogness
2026-07-30 14:24   ` Petr Mladek
2026-07-31  7:48     ` John Ogness
2026-07-31 14:04       ` Petr Mladek
2026-08-18  6:25   ` Jon Hunter
2026-08-18  7:01     ` Sebastian Andrzej Siewior
2026-08-18  7:51     ` Petr Mladek
2026-08-18 12:19       ` Jon Hunter
2026-08-18 15:53         ` Petr Mladek
2026-08-20  9:15           ` Jon Hunter
2026-08-20 12:40             ` John Ogness
2026-08-20 23:37               ` Jon Hunter
2026-08-22  0:32                 ` John Ogness
2026-08-24 21:26                   ` Jon Hunter
2026-08-25 13:58                     ` John Ogness
2026-08-25 15:35                       ` Jon Hunter [this message]
2026-08-20 11:20           ` John Ogness
2026-07-29 12:04 ` [PATCH tty v11 2/2] Revert "serial: 8250: drop lockdep annotation from serial8250_clear_IER()" John Ogness
2026-07-30 14:48 ` [PATCH tty v11 0/2] Convert 8250 to NBCON, take 2 Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d058012e-2be7-4e70-9c10-5e4c00a23b05@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jackzxcui1989@163.com \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=osama.abdelkader@gmail.com \
    --cc=pmladek@suse.com \
    --cc=sozdayvek@gmail.com \
    --cc=wangfushuai@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox