* [PATCH] staging: media: atomisp: fix coding style
@ 2025-05-03 20:00 Pablo
2025-05-19 13:25 ` Andy Shevchenko
2025-07-04 9:42 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Pablo @ 2025-05-03 20:00 UTC (permalink / raw)
To: linux-media, linux-kernel, linux-staging, hdegoede, mchehab,
sakari.ailus, andy, gregkh
Cc: ~lkcamp/patches, koike, pablolucas890, Pablo
Fix a coding style:
"ERROR: that open brace { should be on the previous line"
issue reported in ia_css_vf.host.c:94.
Signed-off-by: Pablo <pablo@pablo.ct.ws>
---
Hey, this is my first patch, I apreciate any feedback, thanks!
.../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
index ece5e3da3..0ce75d9bd 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
@@ -91,8 +91,7 @@ configure_kernel(
unsigned int vf_log_ds = 0;
/* First compute value */
- if (vf_info)
- {
+ if (vf_info) {
err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
if (err)
return err;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: atomisp: fix coding style
2025-05-03 20:00 [PATCH] staging: media: atomisp: fix coding style Pablo
@ 2025-05-19 13:25 ` Andy Shevchenko
2025-07-04 9:42 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2025-05-19 13:25 UTC (permalink / raw)
To: Pablo
Cc: linux-media, linux-kernel, linux-staging, hdegoede, mchehab,
sakari.ailus, gregkh, ~lkcamp/patches, koike, pablolucas890
On Sat, May 03, 2025 at 05:00:30PM -0300, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.
Hans, have you taken this change? (I miss it in Linux Next)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: media: atomisp: fix coding style
2025-05-03 20:00 [PATCH] staging: media: atomisp: fix coding style Pablo
2025-05-19 13:25 ` Andy Shevchenko
@ 2025-07-04 9:42 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2025-07-04 9:42 UTC (permalink / raw)
To: Pablo, linux-media, linux-kernel, linux-staging, hdegoede,
mchehab, sakari.ailus, andy, gregkh
Cc: ~lkcamp/patches, koike, pablolucas890
On 3-May-25 10:00 PM, Pablo wrote:
> Fix a coding style:
> "ERROR: that open brace { should be on the previous line"
> issue reported in ia_css_vf.host.c:94.
>
> Signed-off-by: Pablo <pablo@pablo.ct.ws>
Thank you for your patch.
I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> Hey, this is my first patch, I apreciate any feedback, thanks!
> .../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> index ece5e3da3..0ce75d9bd 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
> @@ -91,8 +91,7 @@ configure_kernel(
> unsigned int vf_log_ds = 0;
>
> /* First compute value */
> - if (vf_info)
> - {
> + if (vf_info) {
> err = sh_css_vf_downscale_log2(out_info, vf_info, &vf_log_ds);
> if (err)
> return err;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-04 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-03 20:00 [PATCH] staging: media: atomisp: fix coding style Pablo
2025-05-19 13:25 ` Andy Shevchenko
2025-07-04 9:42 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).