From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D71EC2D0E4 for ; Tue, 17 Nov 2020 17:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FAB4238E6 for ; Tue, 17 Nov 2020 17:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="b0RPhq3F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbgKQRRp (ORCPT ); Tue, 17 Nov 2020 12:17:45 -0500 Received: from z5.mailgun.us ([104.130.96.5]:36089 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727245AbgKQRRo (ORCPT ); Tue, 17 Nov 2020 12:17:44 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1605633464; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=asJBzxf626itj7z5VEyrbr5Efzoc3mFG5fbDkfP/Rgk=; b=b0RPhq3FRmMVZ839lZQe0HsSJkr4+JA+uj5IYPptDJHXO+70MwjuGNp0FwnFlCe7RMfHxk1W RMIohu5o2aTuboHi6UMq6nXceycJDUJ3ocQIdipptEt8XZpKv4uMuuUL1D0yCB5BPCh8IVb/ 9SPUJV8zUDJd14V13IHEGClBLa0= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5fb405a6135ce186e96f5f70 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 17 Nov 2020 17:17:26 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 92FF6C43462; Tue, 17 Nov 2020 17:17:25 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id E689EC433C6; Tue, 17 Nov 2020 17:17:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Nov 2020 09:17:24 -0800 From: Bhaumik Bhatt To: Kalle Valo Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, kvalo=codeaurora.org@codeaurora.org Subject: Re: [PATCH] ath11k: use MHI provided APIs to allocate and free MHI controller Organization: Qualcomm Innovation Center, Inc. Reply-To: bbhatt@codeaurora.org Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <87tutozc7h.fsf@codeaurora.org> References: <1605571300-4438-1-git-send-email-bbhatt@codeaurora.org> <87tutozc7h.fsf@codeaurora.org> Message-ID: X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-16 11:14 PM, Kalle Valo wrote: > Bhaumik Bhatt writes: > >> Use MHI provided APIs to allocate and free MHI controller to >> improve MHI host driver handling. > > How does it improve the handling? > Main reason is we want to ensure the MHI controller is zero-initialized and we want to mandate it as it is better to have it under our control in case we also want to allocate and track peripheral data/memory related to the MHI controller. >> This also fixes a memory leak as the MHI controller was allocated but >> never freed. >> >> Signed-off-by: Bhaumik Bhatt >> --- >> drivers/net/wireless/ath/ath11k/mhi.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) > > For ath11k patches please CC ath11k and linux-wireless lists so that > patchwork sees it. So you need to resend this. > > Is this a new API? I need to understand if there are any dependencies > between mhi and ath trees, or if I can apply this directly to my > ath.git > tree. This one should be dependent on the patch [1] which exists on mainline and should already part of your tree if you're on any 5.10 RC. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/bus/mhi?h=v5.10-rc4&id=f42dfbe8f712127031e7b9bc938a1c33cec2ff57 Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project