From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760763AbdEWQXz (ORCPT ); Tue, 23 May 2017 12:23:55 -0400 Received: from mout.web.de ([212.227.15.14]:59726 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758912AbdEWQXx (ORCPT ); Tue, 23 May 2017 12:23:53 -0400 Subject: Re: tipc: Delete error messages for failed memory allocations in three functions To: Joe Perches , tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org Cc: "David S. Miller" , Jon Maloy , Ying Xue , LKML , kernel-janitors@vger.kernel.org References: <7ac9d513-6f9f-a096-e68f-81a722c2723c@users.sourceforge.net> <1495548133.2093.58.camel@perches.com> From: SF Markus Elfring Message-ID: Date: Tue, 23 May 2017 18:23:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495548133.2093.58.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Zh8O3t07PffXKCZI0Kbyr2wwiV7a63UbkLCx5K4i1FWD0IRoEX1 P/xkD2i1eQF+cjUIrFehZW6pImgqESjOPifuvfSjucIkBFX6pGXsYEcKcqLTgC8xTjocW/d W1XjBtNILTEX/2Gs9blSXJfOUMcKjfrkVKiP5sLK+myPwf2EFm/HAJNuwiBrZpbpdAo0CNG /XgCU2GLrURGtYvlpa38Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:JIDFngEXScs=:cL7yUiMflrah3iPfWcjLZn g3aBWvZX0gTfQwd7NG3soPLMRSkpGcoNBe/ZLVIFEU2/pTay2sNVEtATcbFQ7Bu7yjsZ1+qvs 2q2Qrg7OGkkPa/R9nlrGEyXq8MJdxrHGp1FSButXvuGAlIVDrdxr5gC1P/CqEY5TcAeAc8RaL kVyx+0n9wrKc+S/O1xztlUUmKjD4rTAxAp+92S30BvS24i8MHX6VMdSl51b0ah8G296X8umqu x+XPWgjYxBWuPL0iaSJLTJGM8kSGj5qDt9mDBSvDtxZ/GxCQ8gDBDPegQKw46Kp2evqz2AeoN kwFyB+2lbsugW+rfGGN/FI3hTDBkHcDCdx4m7DOX4pAyg5hgrU1v8Sm2jJHdZ4yEXoSlfaVMh rKGPNfEzXf5ar95QRbTQS5r4i+t21YQdpOyXDZsaoYq2aFHM505iwyqduvLnBX+Tgbin19LQl iXT5zKC+htrbQ6kCSMDGx8o5VvT4q53hs8PmObiqvZAeW0+iDC4BbZtVqPuaMn+pt6PxhgEOo kMHtI38Elx4qMs2nI/rP+BAVHsJB7Bm7uhNpa2US3Dq+qeWaIz/B/UnYqe4sd2JwHhpckD60h GJy/ZfhMJdSyJh+DoC69FogTaa0cr6LG+cBQ0I7VOFU9uHhWOwAaSqE/KMN2WjFX0JPniU6Jy z201nj4AAKwsuWkD4PhtHJiB6pKbamz81XRElK5AVOzgWTpJmd+BpRY82I+W+KGTlnUsY+/WB lw+gvIylIOOewq+oOWdxvetsbk6aK/RXo249Okel2OIA2UiEf+iNYNdU3TQI0DzMIfGI7nDRe YJpywiq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > tipc_subseq_alloc does a kcalloc (memset to 0), > half of which is immediately overwritten. > > In other words, don't just blindly remove stuff, > understand what it does and improve it. Do you suggest another specific source code transformation pattern here? Regards, Markus