From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501Ab1ITQY2 (ORCPT ); Tue, 20 Sep 2011 12:24:28 -0400 Received: from mga03.intel.com ([143.182.124.21]:3354 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772Ab1ITQY1 (ORCPT ); Tue, 20 Sep 2011 12:24:27 -0400 Message-Id: X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,412,1312182000"; d="scan'208";a="50958358" From: Chris Wilson Subject: Re: [PATCH] drm/i915: Enable digital port hotplug on PCH systems To: Keith Packard , Dave Airlie Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <1316533641-13478-1-git-send-email-keithp@keithp.com> References: <1316533641-13478-1-git-send-email-keithp@keithp.com> Date: Tue, 20 Sep 2011 17:24:21 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Sep 2011 08:47:21 -0700, Keith Packard wrote: > We were relying on the BIOS to set these bits, which doesn't always > happen. Do we need to clear IRQ bits on uninstall, for example to prevent "Interrupt 19: no one cared!" or is that due to a different cause? More of a general question really. The patch itself looks good and matches against the spec afaics. -Chris -- Chris Wilson, Intel Open Source Technology Centre