From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Kurtz <djkurtz@chromium.org>,
Keith Packard <keithp@keithp.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Benson Leung <bleung@chromium.org>,
Yufeng Shen <miletus@chromium.org>,
Sameer Nanda <snanda@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH 3/9] drm/i915/intel_i2c: refactor using intel_gmbus_get_bus
Date: Wed, 07 Mar 2012 12:02:20 +0000 [thread overview]
Message-ID: <d08817$3eem0c@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1331121050-17857-4-git-send-email-djkurtz@chromium.org>
On Wed, 7 Mar 2012 19:50:44 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote:
> +struct i2c_adapter *intel_gmbus_get_bus(struct drm_i915_private *dev_priv,
> + int pin)
> +{
BUG_ON(pin >= GMBUS_NUM_PORTS);
> + return (pin < GMBUS_NUM_PORTS) ? &dev_priv->gmbus[pin].adapter : NULL;
You just turned a programming error into a nearly undecipherable OOPS.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-07 12:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 11:50 [PATCH 0/9] drm/i915/intel_i2c: fix gmbus writes and related issues Daniel Kurtz
2012-03-07 11:50 ` [PATCH 1/9] drm/i915/intel_i2c: cleanup Daniel Kurtz
2012-03-07 11:58 ` Chris Wilson
2012-03-07 11:50 ` [PATCH 2/9] drm/i915/intel_i2c: assign HDMI port D to pin pair 6 Daniel Kurtz
2012-03-07 13:23 ` Chris Wilson
2012-03-07 18:03 ` Daniel Kurtz
[not found] ` <CAGS+omDvcmfVAh_Tx64SdC0Ys8FOgZXjbYmPO8SrgQW_1aPOJg@mail.gmail.com>
2012-03-07 18:07 ` Chris Wilson
2012-03-07 11:50 ` [PATCH 3/9] drm/i915/intel_i2c: refactor using intel_gmbus_get_bus Daniel Kurtz
2012-03-07 12:02 ` Chris Wilson [this message]
2012-03-07 12:15 ` Chris Wilson
2012-03-07 11:50 ` [PATCH 4/9] drm/i915/intel_i2c: cleanup gmbus/gpio pin assignments Daniel Kurtz
2012-03-07 12:17 ` Chris Wilson
2012-03-07 12:44 ` Daniel Kurtz
2012-03-07 11:50 ` [PATCH 5/9] drm/i915/intel_i2c: add locking around i2c algorithm accesses Daniel Kurtz
2012-03-18 18:19 ` Daniel Vetter
2012-03-07 11:50 ` [PATCH 6/9] drm/i915/intel_i2c: return -ENXIO for device NAK Daniel Kurtz
2012-03-07 12:12 ` Chris Wilson
2012-03-07 12:41 ` Daniel Kurtz
2012-03-07 12:53 ` Chris Wilson
2012-03-07 11:50 ` [PATCH 7/9] drm/i915/intel_i2c: use WAIT cycle, not STOP Daniel Kurtz
2012-03-07 11:50 ` [PATCH 8/9] drm/i915/intel_i2c: use INDEX cycles for i2c read transactions Daniel Kurtz
2012-03-07 11:50 ` [PATCH 9/9] drm/i915/intel_i2c: reuse GMBUS2 value from polling loop Daniel Kurtz
2012-03-07 12:09 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$3eem0c@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=snanda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox