From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009EE16D9BF for ; Fri, 25 Oct 2024 17:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878909; cv=none; b=IMLlNJDQMY+FX1bRGXVmX05/somuN0uF5bFbES00J9fmlfHBlJ40IuqD6ISIVP83R+GQ+I0HV6x3EiN6nZG46Bp+/7DzoELKoEUDAtz3Z+PYiRrbNodtQ17+JWDJMpIYhAHXVXEzyBOBHgwk8rkS8ToKmKKBjleOq8BkoxorpqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729878909; c=relaxed/simple; bh=H64cwn/YI+xahZM5R2yS0Dl/XbXQeq2fR8JVMbZATBE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ay+pcrEQ9yemhpZCWMbaBcMsbda8YjJ2v+3PzzLVaco+b0n16zCPL0hxX8++CJZvdekHy8LzqGDBZFqimlrkf37Brio07C9ctr2Dos2KggmuNtYvmqaZgiVq2EAvHVljBnuBQ/7ok4B0kk+CPOq0ZB53M9RIvN/wriNxPgIncNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T2MWjDkz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T2MWjDkz" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49PBj6vn027468 for ; Fri, 25 Oct 2024 17:55:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PDDJozuZu4zaPv6m9oMVj0bpssXrcVhycEDLywhRjgc=; b=T2MWjDkzJ1e6mJrH EqYCq2WxCPILCmPQRaSBcaVYp/z37Y0ZuuQrJAUJ7r+aNcJY0U7lpwNjCFOYcHT7 Q1AFfcD++B7qbajIO1MgeB0VGJcxGIuPsnQWAKzy8/0PM7Vno+CKhkzaTQnYZKd6 QiZTeXNgTkTBZdOe4pryA2w1qd9i6JrOpqF+8omI0JYroANjoV2fEpXkW5PNHPaD tPpTgacPK6fCVcmSEEUcZTL7fCWLaxhbbw4II1x+2JncznrxxLPeZC8IyxRt5GcY 14+UhzJ7i9K1uZH6Ib98S73xgVE+xTV8r2C5Su8wxhIaD3VxrBx532V/d6lSdRNt QoHyvw== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42em3wt1yy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Oct 2024 17:55:05 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6cbe5e8658fso4595306d6.0 for ; Fri, 25 Oct 2024 10:55:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729878905; x=1730483705; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PDDJozuZu4zaPv6m9oMVj0bpssXrcVhycEDLywhRjgc=; b=W5SYHJFht/3Z//Q+LQ5/FaXhmOGIDkdBSwY1yzebnoQXjhrG9Yho/5wenXRnhGQ9Qa 7k8AI42UgNOgof7bgzZWUclcJWIgATGpJTRbq4aXsAaVOy7qEtz4mPbuQdiyvcIMJffA x8f7D92wkfAv95lYw1prsGOjq88KoGu/RyoIkCSxeZrRnXwMW7fTgdz7Axu6mGbIPOnZ FR96zrgg0EC/2QZzy68vUlvMnu5/3FqqNOUUrvuKoVNB90oE+taYBQB3EAnQiOPWbALT ijN+uVBadx46XzDjvfofsLYglrCX8CaSBsjoLRe03gzHTZQrzlNMvHIxDTIbP5d26fjN dg4g== X-Forwarded-Encrypted: i=1; AJvYcCVhNBQU/G7nFPcTCUdlaYt0DkUpOELkAn9aKMuH3SmuQLiCh1ubRYRzSpy0+HCGnTiW2osEd06+RH5Lc8E=@vger.kernel.org X-Gm-Message-State: AOJu0YynhtqEDGj1Hy7Jgsrgkslj62x5VeyNfrScIe3FnpSK+3p1vssm OCQr0mXUWIju7S3n2vJa01UzWIzGvBWwE8AsNRseUgDkYFtTSj2YguMfsO119JDapWgCE15yqL6 QD0Tkw1bvzTNCL/lzpjOYgsc9mysJ3Pi1inRg2wmMBX6uFcuxdZg5KVrt38zwXl0= X-Received: by 2002:a05:6214:246a:b0:6cb:bc57:d840 with SMTP id 6a1803df08f44-6d1856b5615mr1922506d6.3.1729878905186; Fri, 25 Oct 2024 10:55:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtUtIC+fHNLiU+/kDeF55Vgxs+NaItUmbI4LMdDeHbRHKwKsO/SElBGpjQ2p6QUOy8POh7KQ== X-Received: by 2002:a05:6214:246a:b0:6cb:bc57:d840 with SMTP id 6a1803df08f44-6d1856b5615mr1922306d6.3.1729878904852; Fri, 25 Oct 2024 10:55:04 -0700 (PDT) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9b331b0d44sm92945966b.187.2024.10.25.10.55.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Oct 2024 10:55:04 -0700 (PDT) Message-ID: Date: Fri, 25 Oct 2024 19:55:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi To: YijieYang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com References: <20241017102728.2844274-1-quic_yijiyang@quicinc.com> <20241017102728.2844274-5-quic_yijiyang@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20241017102728.2844274-5-quic_yijiyang@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: L7_DvLTGOsTYQzHP_eTo17vFPUKx9C0y X-Proofpoint-ORIG-GUID: L7_DvLTGOsTYQzHP_eTo17vFPUKx9C0y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410250136 On 17.10.2024 12:27 PM, YijieYang wrote: > From: Yijie Yang > > In order to support multiple revisions of the qcs8300-ride board, create > a .dtsi containing the common parts and split out the ethernet bits into > the actual board file as they will change in revision 2. > > Signed-off-by: Yijie Yang > --- [...] > chosen { > - stdout-path = "serial0:115200n8"; > + stdout-path = "serial0: 115200n8"; > }; This looks unintended The rest looks good, except I think you forgot to drop /dts-v1/ from the dtsi Konrad