From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933145AbcHJSMG (ORCPT ); Wed, 10 Aug 2016 14:12:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50120 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933063AbcHJSLm (ORCPT ); Wed, 10 Aug 2016 14:11:42 -0400 Subject: Re: [PATCH] dmaengine: qcom_hidma: release the descriptor before the callback To: Vinod Koul References: <1468465076-27324-1-git-send-email-okaya@codeaurora.org> <20160724062425.GW9681@localhost> <971733d9-fd18-2a1b-07c0-349b47747d49@codeaurora.org> <20160804125525.GF9681@localhost> <71a15611-645f-7523-1c26-14b420aff667@codeaurora.org> <20160804144003.GV1041@n2100.armlinux.org.uk> <20160808090203.GY9681@localhost> <21475c6e-a5f8-5125-3998-f3995ce67c4d@codeaurora.org> <20160810172805.GH9681@localhost> Cc: Russell King - ARM Linux , linux-arm-msm@vger.kernel.org, timur@codeaurora.org, linux-kernel@vger.kernel.org, Christopher Covington , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Sinan Kaya Message-ID: Date: Wed, 10 Aug 2016 13:31:21 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160810172805.GH9681@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/2016 1:28 PM, Vinod Koul wrote: >> That's why, I preferred not to call the callback when I observe an error which I >> > think it makes more sense. > That doesnt make sense. A client set a callback, it expect you to call one. > The result quried maybe txn completed or error. Since you have means, please > report.. > If there is a good way to fix tx_status, I can certainly do so. I just need to make sure my implementation is robust and reliable. I saw your reply that we need to keep this information around until terminate_all is called. What is a good implementation strategy? Keep a size limited list with error cookies and flush them in terminate all? What should I do if code reaches to the size limit? Size the error cookie list double the size of available descriptors? >> Again, it will be a different patch than this one. I think v2 of this patch >> > needs to go in as it is. >> > >> > https://lkml.org/lkml/2016/7/31/64 > I havent looked at the patch. If it is not invoking callback set by user, > then I am not taking it. Sorry, we dont choose over client's wish. Ok. The problem you are referring to is something else and needs to be addressed separately. I can create a series with first implement a reliable tx_status based on your recommendation above. Then, change the current behavior so that client callback is always executed as you requested. After that this patch to fix the free order. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.