From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbdJWGI4 (ORCPT ); Mon, 23 Oct 2017 02:08:56 -0400 Received: from mout.web.de ([212.227.15.14]:64241 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbdJWGIz (ORCPT ); Mon, 23 Oct 2017 02:08:55 -0400 Subject: Re: extcon: max14577: Use common error handling code in max14577_muic_set_path() To: Chanwoo Choi , kernel-janitors@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , MyungJoo Ham , LKML References: <5cdefd84-066d-5379-43c8-76f5d3b8f7c4@users.sourceforge.net> <59ED3E72.7010401@samsung.com> <59ED83FA.5000701@samsung.com> <59ED8639.7020605@samsung.com> From: SF Markus Elfring Message-ID: Date: Mon, 23 Oct 2017 08:08:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <59ED8639.7020605@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eG6GFMATo2p6uRhknVAIGc5Lsz/NMiu+9YSwYqsIPBYvJNmP8vI 62MtNVNnPoMBrkaSQ0oA6aHJdcqbjTB4HOofVTv8hFfmO3jV/0+mA6C8E40zTz+mv1dQF1X jCBIdMF/LJKCr2mp2am09VZIgC97IuTzTq/dQ9GiBYUe6vzqTxEN2wLild8EpXJ/B0mLvOy iXtV2312jclDU/z131mhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZM+UBwwOGRQ=:mb0PJMyh2O63IjNV8kvM0I B8IvRa7EHfov+LjGfbFf3FwwAg9AXdN+DC10BznzDwAGRd1Vr1CTVdhJxqIYSuVie5XaPVooA 8G0qSonDvT7C2t/GTlivkPrYnoIIHeGcN1bKy2UmeDFoyAzEAP9A3aH+WPRnbT8G6bi/1CoVp m5aJv+zKZ6gwNWy/tauMG2X5W49boMY7LDi62QaRGFCnVAO+DMeekIlG4dCxC4npbwCUGEYSj LJoOJ7oSjKWWb42qJlzOqXpRecTfVLBhjBBgVTsNn3/fwucx/0dyzw83IMuSBoiB0WZPl5RKh NDCawsQELt8pw8Of+99Wo9rcY5dlWght9OMCmLDTd6mha1xLxmMjLsHV6b6JWCV2msHLGSAMf sn7nTYSGsC1NfZQ29uF1zCN/hPXaGH6c9MvIizsbKntZfJaorhK1x02jWN6XmJoM8c7OjqC6u w/AC31I8wEcbPKeLd9+i8IiCLoeWIkGP9KxEPoEW7oiSnF+EK9sHLcJunWhWn+Xv8aeOehvyi 9cUqj0oRw6DkGYS+i6OOdIdVP6JyMRvdeF1mQShxteOEHbu0tqvWoOL9/4UfQQX5ipGlHTnAY nTglGKsMImwLnSFBgvDmApn9JYW12mXcxoTRm4VZCr+vQKGsRu3YRgUm5Iyb+7SBNQH2ke5EA /v4ebMFwi4A9vhbeIwk+DEu1BGxL9/cnPhc90vNWiEflee1BvKp1TF/ii+VlyZHOi6KJsmlT/ LB6QVs79g/BB4ppXArbCa3UYN3oGG3U9dqWUcDc3NniCLMZS4UMWD5ppLAJOQTrZR9oxoVmdP snhXRxsK1u4BVUwtV85FlU45dvvT+fCwrdIo5fP7uBHeW3hdOU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> I think that there is any benefit of this patch. >>> Also, as I commented, it make the code more complicated. >> >> We have got different software development opinions about > > I agree absolutely. So, anyone can suggest the opinion and send patches. > But, all patches have to get the review from maintainer, reviewer > or the mailing-list developer. Can an other change acceptance evolve over time? > (Please don't remove the part of my comment when you reply.) > >> the shown change possibilities then. Do you find similar updates more useful for any other software modules? Regards, Markus