Re: [RFQ] Rules for accepting patches into the linux-releases tree

Paul Jackson
2005-03-07T08:04:30Z

Andres wrote:
> An obvious fix is an obvious fix.

Perhaps in theory. But in practice, any fix bears some risk.

They have nothing against "obvious" fixes. But unless additional
criteria are also met, such fixes are for someone else to apply.

> >> - It can not contain any "trivial" fixes in it (spelling changes,
> >> whitespace cleanups, etc.)
>
> This and the "it must fix a problem" are basically saying the same thing.

Not at all. Let me put it this way.

If a change that fixes a problem is included in a patch with another
change that makes trivial changes (typo fix, say), the patch will
be rejected.

The statement:

"It must fix a problem and it must _not_ contain anything else,
such as 'trivial' fixes."

is _obviously_ not the same as:

"It must fix a problem."

(Notice how quickly even the obvious becomes unobvious ...;).

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373, 1.925.600.0401