From: Florian Fainelli <f.fainelli@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Jonathan Corbet <corbet@lwn.net>,
Russell King <rmk+kernel@armlinux.org.uk>
Cc: Laura Abbott <labbott@redhat.com>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol
Date: Tue, 18 Jul 2017 09:49:17 -0700 [thread overview]
Message-ID: <d0d5568e-e70a-5576-fd0f-f01acfe8cfa2@gmail.com> (raw)
In-Reply-To: <1500298768-13262-1-git-send-email-geert+renesas@glider.be>
On 07/17/2017 06:39 AM, Geert Uytterhoeven wrote:
> All low-level PM/SMP code using virt_to_phys() should actually use
> __pa_symbol() against kernel symbols. Update the documentation to move
> away from virt_to_phys().
>
> Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of
> virt_to_phys with __pa_symbol")
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Sorry for not noticing earlier.
> ---
> Documentation/arm/firmware.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt
> index da6713adac8acffc..7f175dbb427e631a 100644
> --- a/Documentation/arm/firmware.txt
> +++ b/Documentation/arm/firmware.txt
> @@ -60,7 +60,7 @@ Example of using a firmware operation:
>
> /* some platform code, e.g. SMP initialization */
>
> - __raw_writel(virt_to_phys(exynos4_secondary_startup),
> + __raw_writel(__pa_symbol(exynos4_secondary_startup),
> CPU1_BOOT_REG);
>
> /* Call Exynos specific smc call */
>
--
Florian
prev parent reply other threads:[~2017-07-18 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 13:39 [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol Geert Uytterhoeven
2017-07-17 19:44 ` Jonathan Corbet
2017-07-17 21:20 ` Russell King - ARM Linux
2017-07-18 7:14 ` Geert Uytterhoeven
2017-07-18 16:49 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d5568e-e70a-5576-fd0f-f01acfe8cfa2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox