From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751455AbdGRQtX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 12:49:23 -0400
Received: from mail-qt0-f194.google.com ([209.85.216.194]:34282 "EHLO
        mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751353AbdGRQtV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 12:49:21 -0400
Subject: Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys
 with __pa_symbol
To: Geert Uytterhoeven <geert+renesas@glider.be>,
        Jonathan Corbet <corbet@lwn.net>,
        Russell King <rmk+kernel@armlinux.org.uk>
Cc: Laura Abbott <labbott@redhat.com>, linux-doc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1500298768-13262-1-git-send-email-geert+renesas@glider.be>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <d0d5568e-e70a-5576-fd0f-f01acfe8cfa2@gmail.com>
Date: Tue, 18 Jul 2017 09:49:17 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1500298768-13262-1-git-send-email-geert+renesas@glider.be>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/17/2017 06:39 AM, Geert Uytterhoeven wrote:
> All low-level PM/SMP code using virt_to_phys() should actually use
> __pa_symbol() against kernel symbols.  Update the documentation to move
> away from virt_to_phys().
> 
> Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of
> virt_to_phys with __pa_symbol")
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Sorry for not noticing earlier.

> ---
>  Documentation/arm/firmware.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt
> index da6713adac8acffc..7f175dbb427e631a 100644
> --- a/Documentation/arm/firmware.txt
> +++ b/Documentation/arm/firmware.txt
> @@ -60,7 +60,7 @@ Example of using a firmware operation:
>  
>  	/* some platform code, e.g. SMP initialization */
>  
> -	__raw_writel(virt_to_phys(exynos4_secondary_startup),
> +	__raw_writel(__pa_symbol(exynos4_secondary_startup),
>  		CPU1_BOOT_REG);
>  
>  	/* Call Exynos specific smc call */
> 


-- 
Florian