From: Pierre Gondois <pierre.gondois@arm.com>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched/idle: Prevent stopping the tick when there is no cpuidle driver
Date: Fri, 12 Jan 2024 14:39:46 +0100 [thread overview]
Message-ID: <d0f1617e-0088-4bd9-bea6-e89c63b0e2ae@arm.com> (raw)
In-Reply-To: <87a5pag6q7.fsf@somnus>
Hello Anna-Maria,
On 1/12/24 11:56, Anna-Maria Behnsen wrote:
> Pierre Gondois <pierre.gondois@arm.com> writes:
>
>> Hello Anna-Maria,
>>
>> On 1/9/24 17:24, Anna-Maria Behnsen wrote:
>>>
>>> When there is no cpuidle driver, there is no instance which could bring
>>> the CPU into a deeper C state. But at the moment the code does
>>> unconditionally try to stop the tick. So the aim of the patch is to
>>> remove this unconditional stop of the tick.
>>
>> I agree that the absence of cpuidle driver prevents from reaching deep
>> idle states. FWIU, there is however still benefits in stopping the tick
>> on such platform.
>
> What's the benefit?
I did the following test:
- on an arm64 Juno-r2 platform (2 big A-72 and 4 little A-53 CPUs)
- booting with 'cpuidle.off=1'
- using the energy counters of the platforms
(the counters measure energy for the whole cluster of big/little CPUs)
- letting the platform idling during 10s
Without patch:
| | big-CPUs | little-CPUs |
|:------|-------------:|------------:|
| count | 10 | 10 |
| mean | 0.353266 | 0.33399 |
| std | 0.000254574 | 0.00206803 |
| min | 0.352991 | 0.332145 |
| 25% | 0.353039 | 0.332506 |
| 50% | 0.353267 | 0.333089 |
| 75% | 0.353412 | 0.335231 |
| max | 0.353737 | 0.337964 |
With patch:
| | big-CPUs | little-CPUs |
|:------|-------------:|-------------:|
| count | 10 | 10 |
| mean | 0.375086 | 0.352451 |
| std | 0.000299919 | 0.000752727 |
| min | 0.374527 | 0.351743 |
| 25% | 0.374872 | 0.35181 |
| 50% | 0.37512 | 0.352063 |
| 75% | 0.375335 | 0.353256 |
| max | 0.375485 | 0.353461 |
So the energy consumption would be up:
- ~6% for the big CPUs
- ~10% for the litte CPUs
Regards,
Pierre
>
> Thanks,
>
> Anna-Maria
>
next prev parent reply other threads:[~2024-01-12 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 13:05 [PATCH] sched/idle: Prevent stopping the tick when there is no cpuidle driver Anna-Maria Behnsen
2023-12-21 15:22 ` Pierre Gondois
2024-01-09 16:24 ` Anna-Maria Behnsen
2024-01-10 10:20 ` Pierre Gondois
2024-01-12 10:56 ` Anna-Maria Behnsen
2024-01-12 13:39 ` Pierre Gondois [this message]
2024-01-12 14:52 ` Thomas Gleixner
2024-01-15 12:40 ` Pierre Gondois
2024-01-15 13:10 ` Anna-Maria Behnsen
2024-01-15 13:29 ` Vincent Guittot
2024-01-15 15:41 ` Pierre Gondois
2024-01-22 10:22 ` Anna-Maria Behnsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f1617e-0088-4bd9-bea6-e89c63b0e2ae@arm.com \
--to=pierre.gondois@arm.com \
--cc=anna-maria@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox