From: Johannes Berg <johannes@sipsolutions.net>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame_data
Date: Mon, 28 Oct 2019 13:12:47 +0100 [thread overview]
Message-ID: <d0fc94581e0dce37d993c55edaae8fc40eaa7601.camel@sipsolutions.net> (raw)
In-Reply-To: <20191027181600.11149-1-navid.emamdoost@gmail.com> (sfid-20191027_191610_218836_6E8601E7)
On Sun, 2019-10-27 at 13:15 -0500, Navid Emamdoost wrote:
> In the implementation of cfg80211_inform_single_bss_frame_data() the
> allocated memory for ies is leaked in case of an error. Release ies if
> cfg80211_bss_update() fails.
I'm pretty sure it's more complicated than this patch (and the previous
one) - we already do free this at least in the case that "new =
kzalloc(...)" fails in cfg80211_bss_update().
Your Fixes: tag is also wrong, back then we didn't even have the dynamic
allocation of the IEs.
I'm dropping this patch and the other and will make a note to eventually
look at the lifetime issue here you point out, but if you want to work
on it instead let me know.
johannes
next prev parent reply other threads:[~2019-10-28 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 18:15 [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame_data Navid Emamdoost
2019-10-28 12:12 ` Johannes Berg [this message]
2019-10-28 14:46 ` Navid Emamdoost
2019-11-04 8:25 ` [cfg80211] 17e52ab494: stack_segment:#[##] kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0fc94581e0dce37d993c55edaae8fc40eaa7601.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox